From: Hans de Goede <hdegoede@redhat.com>
To: Mogens Jensen <mogens-jensen@protonmail.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Dean Wallace <duffydack73@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
Stable <stable@vger.kernel.org>,
Johannes Stezenbach <js@sig21.net>,
Carlo Caione <carlo@endlessm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)
Date: Sun, 2 Dec 2018 13:25:29 +0100 [thread overview]
Message-ID: <3e12e051-b874-187d-d4f5-e146f59c659b@redhat.com> (raw)
In-Reply-To: <3iO9ehQbZm_haTV0IuZ0qhsVHR0QLUbTgRJT8ZenGuRsnz2_uBvO93f0bHVYnsApibUT16JsJ0dgphLhUBd-u0t-lDBNsbvvlKWTgq8XOlw=@protonmail.com>
Hi,
On 01-11-18 07:55, Mogens Jensen wrote:
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Wednesday, October 31, 2018 9:29 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>
>> Hi,
>>
>> On 31-10-18 07:02, Mogens Jensen wrote:
>>
>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>> On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdegoede@redhat.com wrote:
>>>
>>>> Hi,
>>>> On 30-10-18 19:56, Mogens Jensen wrote:
>>>>
>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>> On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdegoede@redhat.com wrote:
>>>>>
>>>>>> Hi,
>>>>>> On 30-10-18 16:46, Hans de Goede wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>> On 30-10-18 16:04, Pierre-Louis Bossart wrote:
>>>>>>>
>>>>>>>> In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking for both clocks to be on might work though,
>>>>>>>
>>>>>>> Ok, so we need to have a DMI based quirk for the Swanky and maybe also
>>>>>>> the clapper to use plt_clk_0 there. Asking for 2 clks if we only need
>>>>>>> one does not seem like a good plan.
>>>>>>
>>>>>> Dean, Mogens,
>>>>>> To write a proper patch for this I'm going to need DMI strings
>>>>>> from your devices.
>>>>>> Can you please run (as normal user):
>>>>>> grep . /sys/class/dmi/id/* 2> /dev/null
>>>>>> And reply with the output of this command?
>>>>>> I have attached the output from a coreboot seabios based clapper.
>>>>
>>>> Thank you.
>>>>
>>>>> Should I still test 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and asoundrc from Dean? There seems to have been some development in the case since that request was made.
>>>>
>>>> Yes please test that, I expect that to also fix things for the
>>>> Clapper, but I need to have that confirmed before submitting a
>>>> patch upstream adding a quirk for the Clapper to use pmc_plt_clk_0
>>>> instead of pmc_plt_clk_3.
>>>> Regards,
>>>> Hans
>>>
>>> Unfortunately I only have access to longterm kernel 4.14 for building/running on this system, and 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch does not patch against 4.14.78. Can a test patch for 4.14 be created?
>>
>> Can you run (as root):
>>
>> for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat $i/clk_flags; echo; done
>>
>> When running a kernel with working audio?
>>
>> Then I can confirm that the Clapper is also using pmc_plt_clk_0, so that I can
>> fix this for the clapper for 4.18+
>>
>> I've just checked the 4.14 sources and in 4.14 the SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH
>> driver does not support mclk control yet, so for the 4.14 kernel the only way to
>> fix this is to revert the 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
>> commit.
>>
>> Regards,
>>
>> Hans
>>
> Here is the output from the Clapper with 4.14.78 and working sound:
>
> /sys/kernel/debug/clk/pmc_plt_clk_0: 0x00000800
> /sys/kernel/debug/clk/pmc_plt_clk_1: 0x00000000
> /sys/kernel/debug/clk/pmc_plt_clk_2: 0x00000000
> /sys/kernel/debug/clk/pmc_plt_clk_3: 0x00000000
> /sys/kernel/debug/clk/pmc_plt_clk_4: 0x00000000
> /sys/kernel/debug/clk/pmc_plt_clk_5: 0x00000000
Ok, so your Clapper model indeed is also using clk 0 and not clk 3 as
expected. I've just submitted a patch upstream adding a quirk for this.
As for what the plan is with 4.14, I don't know. I believe that
reverting the commit causing the issue there is fine.
Regards,
Hans
next prev parent reply other threads:[~2018-12-02 12:25 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181025232517.ywnw54qibemosjws@picard>
2018-10-29 17:45 ` Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) Stephen Boyd
2018-10-29 17:52 ` Andy Shevchenko
2018-10-29 18:04 ` Andy Shevchenko
2018-10-29 19:08 ` Dean Wallace
2018-10-29 22:03 ` Pierre-Louis Bossart
2018-10-30 10:17 ` Hans de Goede
2018-10-30 11:05 ` Hans de Goede
2018-10-30 16:24 ` Andy Shevchenko
2018-10-30 11:19 ` Hans de Goede
2018-10-30 14:38 ` Dean Wallace
2018-10-30 14:48 ` Hans de Goede
2018-10-30 15:03 ` Andy Shevchenko
2018-10-30 15:25 ` Pierre-Louis Bossart
2018-10-30 15:04 ` Pierre-Louis Bossart
2018-10-30 15:46 ` Hans de Goede
2018-10-30 16:02 ` Hans de Goede
2018-10-30 16:27 ` Pierre-Louis Bossart
2018-10-30 18:31 ` Hans de Goede
2018-10-30 16:03 ` Pierre-Louis Bossart
2018-10-30 16:04 ` Hans de Goede
2018-10-30 16:15 ` Dean Wallace
2018-10-31 11:04 ` Hans de Goede
2018-10-31 12:45 ` Dean Wallace
2018-10-31 20:07 ` Dean Wallace
2018-10-31 22:27 ` Pierre-Louis Bossart
2018-10-31 23:57 ` Dean Wallace
2018-11-01 10:37 ` Dean Wallace
2018-11-01 13:57 ` Hans de Goede
2018-11-01 14:28 ` Dean Wallace
2018-11-01 14:49 ` Hans de Goede
2018-11-01 15:29 ` Dean Wallace
2018-11-01 15:39 ` Dean Wallace
2018-11-01 15:50 ` Dean Wallace
2018-11-02 10:27 ` Hans de Goede
2018-11-02 11:15 ` Dean Wallace
2018-11-01 13:56 ` Hans de Goede
2018-10-30 18:56 ` Mogens Jensen
2018-10-30 19:10 ` Hans de Goede
2018-10-31 6:02 ` Mogens Jensen
2018-10-31 9:29 ` Hans de Goede
2018-10-31 10:03 ` Dean Wallace
2018-11-01 6:55 ` Mogens Jensen
2018-12-02 12:25 ` Hans de Goede [this message]
2019-01-17 5:58 ` Mogens Jensen
2019-01-17 9:12 ` Dean Wallace
2019-01-17 12:05 ` Hans de Goede
2019-01-17 13:05 ` Johannes Stezenbach
2019-01-17 13:16 ` Dean Wallace
2019-01-18 15:33 ` Hans de Goede
2019-01-17 19:30 ` Mogens Jensen
2019-01-18 15:35 ` Hans de Goede
2019-01-21 5:55 ` Mogens Jensen
2019-01-22 19:27 ` Pierre-Louis Bossart
2019-01-25 5:16 ` Mogens Jensen
2019-01-25 14:12 ` Pierre-Louis Bossart
2019-01-25 17:57 ` Pierre-Louis Bossart
2019-01-25 20:30 ` Andy Shevchenko
2019-01-24 10:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e12e051-b874-187d-d4f5-e146f59c659b@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=carlo@endlessm.com \
--cc=duffydack73@gmail.com \
--cc=js@sig21.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mogens-jensen@protonmail.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).