From: Roman Gushchin <guro@fb.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"Shakeel Butt" <shakeelb@google.com>,
Michal Hocko <mhocko@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
Rik van Riel <riel@surriel.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
"Stable@vger.kernel.org" <Stable@vger.kernel.org>
Subject: Re: Will the recent memory leak fixes be backported to longterm kernels?
Date: Fri, 2 Nov 2018 00:58:23 +0000 [thread overview]
Message-ID: <20181102005816.GA10297@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <PU1P153MB0169CB6382E0F047579D111DBFCF0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Fri, Nov 02, 2018 at 12:16:02AM +0000, Dexuan Cui wrote:
> Hi all,
> When debugging a memory leak issue (https://github.com/coreos/bugs/issues/2516)
> with v4.14.11-coreos, we noticed the same issue may have been fixed recently by
> Roman in the latest mainline (i.e. Linus's master branch) according to comment #7 of
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.launchpad.net_ubuntu_-2Bsource_linux_-2Bbug_1792349&d=DwIFAg&c=5VD0RTtNlTh3ycd41b3MUw&r=i6WobKxbeG3slzHSIOxTVtYIJw7qjCE6S0spDTKL-J4&m=mrT9jcrhFvVxDpVBlxihJg6S6U91rlevOJby7y1YynE&s=1eHLVA-oQGqMd2ujRPU8kZMbkShOuIDD5CUgpM1IzGI&e=, which lists these
> patches (I'm not sure if the 5-patch list is complete):
>
> 010cb21d4ede math64: prevent double calculation of DIV64_U64_ROUND_UP() arguments
> f77d7a05670d mm: don't miss the last page because of round-off error
> d18bf0af683e mm: drain memcg stocks on css offlining
> 71cd51b2e1ca mm: rework memcg kernel stack accounting
> f3a2fccbce15 mm: slowly shrink slabs with a relatively small number of objects
>
> Obviously at least some of the fixes are also needed in the longterm kernels like v4.14.y,
> but none of the 5 patches has the "Cc: stable@vger.kernel.org" tag? I'm wondering if
> these patches will be backported to the longterm kernels. BTW, the patches are not
> in v4.19, but I suppose they will be in v4.19.1-rc1?
Hello, Dexuan!
A couple of issues has been revealed recently, here are fixes
(hashes are from the next tree):
5f4b04528b5f mm: don't reclaim inodes with many attached pages
5a03b371ad6a mm: handle no memcg case in memcg_kmem_charge() properly
These two patches should be added to the serie.
Re stable backporting, I'd really wait for some time. Memory reclaim is a
quite complex and fragile area, so even if patches are correct by themselves,
they can easily cause a regression by revealing some other issues (as it was
with the inode reclaim case).
Thanks!
next prev parent reply other threads:[~2018-11-02 0:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 0:16 Will the recent memory leak fixes be backported to longterm kernels? Dexuan Cui
2018-11-02 0:45 ` Sasha Levin
2018-11-02 0:58 ` Roman Gushchin [this message]
2018-11-02 2:45 ` Dexuan Cui
2018-11-02 3:16 ` Roman Gushchin
2018-11-02 8:03 ` Michal Hocko
2018-11-02 15:48 ` Roman Gushchin
2018-11-02 16:13 ` Michal Hocko
2018-11-02 16:22 ` Roman Gushchin
2018-11-02 16:51 ` Michal Hocko
2018-11-02 17:25 ` Roman Gushchin
2018-11-02 17:48 ` Michal Hocko
2018-11-02 19:38 ` Roman Gushchin
2018-11-05 9:21 ` Michal Hocko
2018-12-28 10:50 ` Greg KH
2019-01-30 0:23 ` Sasha Levin
2019-01-30 5:58 ` Roman Gushchin
2018-11-02 16:01 ` Sasha Levin
2018-11-04 9:16 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102005816.GA10297@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=Kernel-team@fb.com \
--cc=Stable@vger.kernel.org \
--cc=decui@microsoft.com \
--cc=hannes@cmpxchg.org \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).