linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@linux.ibm.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>, Roman Gushchin <guro@fb.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>,
	Shakeel Butt <shakeelb@google.com>,
	Michal Hocko <mhocko@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Konstantin Khlebnikov <koct9i@gmail.com>,
	Matthew Wilcox <willy@infradead.org>,
	"Stable@vger.kernel.org" <Stable@vger.kernel.org>
Subject: Re: Will the recent memory leak fixes be backported to longterm kernels?
Date: Sun, 4 Nov 2018 11:16:12 +0200	[thread overview]
Message-ID: <20181104091611.GC7829@rapoport-lnx> (raw)
In-Reply-To: <20181102160122.GH194472@sasha-vm>

On Fri, Nov 02, 2018 at 12:01:22PM -0400, Sasha Levin wrote:
> On Fri, Nov 02, 2018 at 02:45:42AM +0000, Dexuan Cui wrote:
> >>From: Roman Gushchin <guro@fb.com>
> >>Sent: Thursday, November 1, 2018 17:58
> >>
> >>On Fri, Nov 02, 2018 at 12:16:02AM +0000, Dexuan Cui wrote:
> >>Hello, Dexuan!
> >>
> >>A couple of issues has been revealed recently, here are fixes
> >>(hashes are from the next tree):
> >>
> >>5f4b04528b5f mm: don't reclaim inodes with many attached pages
> >>5a03b371ad6a mm: handle no memcg case in memcg_kmem_charge()
> >>properly
> >>
> >>These two patches should be added to the serie.
> >
> >Thanks for the new info!
> >
> >>Re stable backporting, I'd really wait for some time. Memory reclaim is a
> >>quite complex and fragile area, so even if patches are correct by themselves,
> >>they can easily cause a regression by revealing some other issues (as it was
> >>with the inode reclaim case).
> >
> >I totally agree. I'm now just wondering if there is any temporary workaround,
> >even if that means we have to run the kernel with some features disabled or
> >with a suboptimal performance?
> 
> I'm not sure what workload you're seeing it on, but if you could merge
> these 7 patches and see that it solves the problem you're seeing and
> doesn't cause any regressions it'll be a useful test for the rest of us.

AFAIK, with Roman's patches backported to Ubuntu version of 4.15, the
problem reported at [1] is solved.

[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1792349
 
> --
> Thanks,
> Sasha
> 

-- 
Sincerely yours,
Mike.


      reply	other threads:[~2018-11-04  9:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02  0:16 Will the recent memory leak fixes be backported to longterm kernels? Dexuan Cui
2018-11-02  0:45 ` Sasha Levin
2018-11-02  0:58 ` Roman Gushchin
2018-11-02  2:45   ` Dexuan Cui
2018-11-02  3:16     ` Roman Gushchin
2018-11-02  8:03     ` Michal Hocko
2018-11-02 15:48       ` Roman Gushchin
2018-11-02 16:13         ` Michal Hocko
2018-11-02 16:22           ` Roman Gushchin
2018-11-02 16:51             ` Michal Hocko
2018-11-02 17:25               ` Roman Gushchin
2018-11-02 17:48                 ` Michal Hocko
2018-11-02 19:38                   ` Roman Gushchin
2018-11-05  9:21                     ` Michal Hocko
2018-12-28 10:50                       ` Greg KH
2019-01-30  0:23                         ` Sasha Levin
2019-01-30  5:58                           ` Roman Gushchin
2018-11-02 16:01     ` Sasha Levin
2018-11-04  9:16       ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181104091611.GC7829@rapoport-lnx \
    --to=rppt@linux.ibm.com \
    --cc=Kernel-team@fb.com \
    --cc=Stable@vger.kernel.org \
    --cc=decui@microsoft.com \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=riel@surriel.com \
    --cc=sashal@kernel.org \
    --cc=shakeelb@google.com \
    --cc=tj@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).