linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: Manish Narani <manish.narani@xilinx.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	michal.simek@xilinx.com, mchehab@kernel.org,
	amit.kucheria@linaro.org, sudeep.holla@arm.com,
	leoyang.li@nxp.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node
Date: Mon, 5 Nov 2018 13:56:44 +0100	[thread overview]
Message-ID: <20181105125644.GA7937@zn.tnic> (raw)
In-Reply-To: <1540447621-22870-6-git-send-email-manish.narani@xilinx.com>

On Thu, Oct 25, 2018 at 11:37:00AM +0530, Manish Narani wrote:
> Add ddrc memory controller node in dts. The size mentioned in dts is
> 0x30000, because we need to access DDR_QOS INTR registers located at
> 0xFD090208 from this driver.
> 
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 29ce234..a81d3b16 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -355,6 +355,13 @@
>  			xlnx,bus-width = <64>;
>  		};
>  
> +		mc: memory-controller@fd070000 {
> +			compatible = "xlnx,zynqmp-ddrc-2.40a";
> +			reg = <0x0 0xfd070000 0x0 0x30000>;
> +			interrupt-parent = <&gic>;
> +			interrupts = <0 112 4>;
> +		};
> +
>  		gem0: ethernet@ff0b0000 {
>  			compatible = "cdns,zynqmp-gem", "cdns,gem";
>  			status = "disabled";
> -- 

Ok, talking to Mark on IRC, he says those DT changes normally go through
the arm-soc tree.

And I'm fine with that except if we do that, then the EDAC changes
go through my tree and those drivers could end up temporarily broken
depending on the merge order and timing.

So should we perhaps make an arm-soc shared, immutable branch which you
guys export for me with those DT changes applied, which I can merge into
my tree and apply the EDAC changes ontop.

This is what we've been doing with the tip tree until now and it has
proven successful.

Thoughts?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-11-05 12:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  6:06 [PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-10-25  6:06 ` [PATCH v10 1/6] edac: synopsys: Add error handling for NULL in probe() Manish Narani
2018-10-25  6:06 ` [PATCH v10 2/6] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-10-25  6:06 ` [PATCH v10 3/6] edac: synopsys: Add macro defines for ZynqMP DDRC Manish Narani
2018-10-25  6:06 ` [PATCH v10 4/6] edac: synopsys: Add EDAC ECC support " Manish Narani
2018-10-25  6:07 ` [PATCH v10 5/6] arm64: zynqmp: Add DDRC node Manish Narani
2018-11-05 12:56   ` Borislav Petkov [this message]
2018-11-05 13:06     ` Michal Simek
2018-11-05 13:20       ` Borislav Petkov
2018-11-05 13:32         ` Michal Simek
2018-11-05 13:42           ` Borislav Petkov
2018-11-05 13:45             ` Michal Simek
2018-11-05 14:51             ` Olof Johansson
2018-11-05 19:47               ` Borislav Petkov
2018-11-05 20:38                 ` Olof Johansson
2018-11-05 20:43                   ` Borislav Petkov
2018-11-06  6:46                     ` Michal Simek
2018-11-06  9:22                       ` Borislav Petkov
2018-11-06 11:54   ` Michal Simek
2018-10-25  6:07 ` [PATCH v10 6/6] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
2018-11-02  8:38 ` [PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-11-02  8:58   ` Borislav Petkov
2018-11-06 10:03 ` Borislav Petkov
2018-11-06 10:42   ` Manish Narani
2018-11-06 10:58     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105125644.GA7937@zn.tnic \
    --to=bp@alien8.de \
    --cc=amit.kucheria@linaro.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).