linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter
@ 2018-11-05  2:38 Randy Dunlap
  2018-11-05  8:19 ` Miquel Raynal
  2018-11-05 22:58 ` Boris Brezillon
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-11-05  2:38 UTC (permalink / raw)
  To: LKML, linux-mtd
  Cc: Boris Brezillon, Miquel Raynal, Richard Weinberger, Andrew Morton

From: Randy Dunlap <rdunlap@infradead.org>

Remove kernel-doc notation for a deleted function parameter to prevent
a kernel-doc warning:

../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'

Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
---

 drivers/mtd/nand/raw/nand_base.c |    1 -
 1 file changed, 1 deletion(-)

--- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
+++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
@@ -590,7 +590,6 @@ retry:
 
 /**
  * panic_nand_wait - [GENERIC] wait until the command is done
- * @mtd: MTD device structure
  * @chip: NAND chip structure
  * @timeo: timeout
  *



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter
  2018-11-05  2:38 [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter Randy Dunlap
@ 2018-11-05  8:19 ` Miquel Raynal
  2018-11-05 22:58 ` Boris Brezillon
  1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2018-11-05  8:19 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, linux-mtd, Boris Brezillon, Richard Weinberger, Andrew Morton

Hi Randy,

Subject prefix should be "mtd: rawnand:".

Randy Dunlap <rdunlap@infradead.org> wrote on Sun, 4 Nov 2018 18:38:35
-0800:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
> 
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
> 
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> ---

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter
  2018-11-05  2:38 [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter Randy Dunlap
  2018-11-05  8:19 ` Miquel Raynal
@ 2018-11-05 22:58 ` Boris Brezillon
  1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-11-05 22:58 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, linux-mtd, Miquel Raynal, Richard Weinberger, Andrew Morton

On Sun, 4 Nov 2018 18:38:35 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
> 
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
> 
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>

Queued to the fixes branch.

Thanks,

Boris

> ---
> 
>  drivers/mtd/nand/raw/nand_base.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
> +++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
> @@ -590,7 +590,6 @@ retry:
>  
>  /**
>   * panic_nand_wait - [GENERIC] wait until the command is done
> - * @mtd: MTD device structure
>   * @chip: NAND chip structure
>   * @timeo: timeout
>   *
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-05 22:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05  2:38 [PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter Randy Dunlap
2018-11-05  8:19 ` Miquel Raynal
2018-11-05 22:58 ` Boris Brezillon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).