* [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-11-06 14:38 Yangtao Li
2018-11-11 11:29 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2018-11-06 14:38 UTC (permalink / raw)
To: rjw, pavel, len.brown; +Cc: linux-pm, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
kernel/power/qos.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 86d72ffb811b..b7a82502857a 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -184,7 +184,7 @@ static inline void pm_qos_set_value(struct pm_qos_constraints *c, s32 value)
c->target_value = value;
}
-static int pm_qos_dbg_show_requests(struct seq_file *s, void *unused)
+static int pm_qos_debug_show(struct seq_file *s, void *unused)
{
struct pm_qos_object *qos = (struct pm_qos_object *)s->private;
struct pm_qos_constraints *c;
@@ -245,18 +245,7 @@ static int pm_qos_dbg_show_requests(struct seq_file *s, void *unused)
return 0;
}
-static int pm_qos_dbg_open(struct inode *inode, struct file *file)
-{
- return single_open(file, pm_qos_dbg_show_requests,
- inode->i_private);
-}
-
-static const struct file_operations pm_qos_debug_fops = {
- .open = pm_qos_dbg_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(pm_qos_debug);
/**
* pm_qos_update_target - manages the constraints list and calls the notifiers
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-06 14:38 [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-11-11 11:29 ` Pavel Machek
2018-12-11 10:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2018-11-11 11:29 UTC (permalink / raw)
To: Yangtao Li; +Cc: rjw, len.brown, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Tue 2018-11-06 09:38:06, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-11 11:29 ` Pavel Machek
@ 2018-12-11 10:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-11 10:44 UTC (permalink / raw)
To: Pavel Machek, Yangtao Li; +Cc: len.brown, linux-pm, linux-kernel
On Sunday, November 11, 2018 12:29:55 PM CET Pavel Machek wrote:
>
> --V88s5gaDVPzZ0KCq
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Tue 2018-11-06 09:38:06, Yangtao Li wrote:
> > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> >=20
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-11 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 14:38 [PATCH] PM / QoS: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-11-11 11:29 ` Pavel Machek
2018-12-11 10:44 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).