* [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype'
@ 2018-11-07 2:22 YueHaibing
2018-11-07 19:23 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-07 2:22 UTC (permalink / raw)
To: linux-edac, ravi, arvino55, bp, mchehab; +Cc: linux-kernel, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/edac/i82975x_edac.c:378:16: warning:
variable 'dtype' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
084a4fccef39 ("edac: move dimm properties to struct dimm_info")
Also remove function i82975x_dram_type and move the comment and the
assignment to the single called place.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: remove unnecessary function i82975x_dram_type
---
drivers/edac/i82975x_edac.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
index 892815e..7f4a14c 100644
--- a/drivers/edac/i82975x_edac.c
+++ b/drivers/edac/i82975x_edac.c
@@ -358,14 +358,6 @@ static int dual_channel_active(void __iomem *mch_window)
return dualch;
}
-static enum dev_type i82975x_dram_type(void __iomem *mch_window, int rank)
-{
- /*
- * ECC is possible on i92975x ONLY with DEV_X8
- */
- return DEV_X8;
-}
-
static void i82975x_init_csrows(struct mem_ctl_info *mci,
struct pci_dev *pdev, void __iomem *mch_window)
{
@@ -375,7 +367,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
u32 cumul_size, nr_pages;
int index, chan;
struct dimm_info *dimm;
- enum dev_type dtype;
last_cumul_size = 0;
@@ -413,7 +404,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
* [0-7] for single-channel; i.e. csrow->nr_channels = 1
* [0-3] for dual-channel; i.e. csrow->nr_channels = 2
*/
- dtype = i82975x_dram_type(mch_window, index);
for (chan = 0; chan < csrow->nr_channels; chan++) {
dimm = mci->csrows[index]->channels[chan]->dimm;
@@ -423,7 +413,10 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci,
(chan == 0) ? 'A' : 'B',
index);
dimm->grain = 1 << 7; /* 128Byte cache-line resolution */
- dimm->dtype = i82975x_dram_type(mch_window, index);
+ /*
+ * ECC is possible on i92975x ONLY with DEV_X8
+ */
+ dimm->dtype = DEV_X8;
dimm->mtype = MEM_DDR2; /* I82975x supports only DDR2 */
dimm->edac_mode = EDAC_SECDED; /* only supported */
}
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype'
2018-11-07 2:22 [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype' YueHaibing
@ 2018-11-07 19:23 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2018-11-07 19:23 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-edac, ravi, arvino55, mchehab, linux-kernel
On Wed, Nov 07, 2018 at 10:22:37AM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/edac/i82975x_edac.c:378:16: warning:
> variable 'dtype' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> 084a4fccef39 ("edac: move dimm properties to struct dimm_info")
>
> Also remove function i82975x_dram_type and move the comment and the
> assignment to the single called place.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: remove unnecessary function i82975x_dram_type
> ---
> drivers/edac/i82975x_edac.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-07 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 2:22 [PATCH v2 -next] edac: i82975x: remove set but not used variable 'dtype' YueHaibing
2018-11-07 19:23 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).