linux-next: Signed-off-by missing for commit in the drm-intel tree

linux-next: Signed-off-by missing for commit in the drm-intel tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi all,

Commit

  35b876db4a42 ("drm/i915/dsc: Add slice_row_per_frame in DSC PPS programming")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

[Rodrigo Vivi]

On Wed, Nov 07, 2018 at 06:59:29AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   35b876db4a42 ("drm/i915/dsc: Add slice_row_per_frame in DSC PPS programming")
> 
> is missing a Signed-off-by from its committer.

It seems the tag "Suggested-by:" tricked out our maintainer tools.

from dim:

# check for committer sign-off
if ! git show -s $sha1 | grep -qi "S.*-by:.*$committer"  ; then

-----

I will send a patch to our tools to spell signed-off-by directly.

Thanks for reporting this out.
Rodrigo.

> 
> -- 
> Cheers,
> Stephen Rothwell



> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

[Manasi Navare]

On Tue, Nov 06, 2018 at 04:00:34PM -0800, Rodrigo Vivi wrote:
> On Wed, Nov 07, 2018 at 06:59:29AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   35b876db4a42 ("drm/i915/dsc: Add slice_row_per_frame in DSC PPS programming")
> > 
> > is missing a Signed-off-by from its committer.
> 
> It seems the tag "Suggested-by:" tricked out our maintainer tools.

Hmm yea that makes sense since it did have suggested-by: me (committer)
so it skipped adding my sign-off.

Thanks for catching this and fixing it in tools.

Manasi

> 
> from dim:
> 
> # check for committer sign-off
> if ! git show -s $sha1 | grep -qi "S.*-by:.*$committer"  ; then
> 
> -----
> 
> I will send a patch to our tools to spell signed-off-by directly.
> 
> Thanks for reporting this out.
> Rodrigo.
> 
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> 
> 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: linux-next: Signed-off-by missing for commit in the drm-intel tree

[Matt Roper]

On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote:
> On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote:
> > Hi Matt,
> > 
> > Always use the dim tooling when applying patches, it will do the right
> > thing with regards to adding the S-o-b.
> 
> fd.o server rejects any pushes that haven't been done by dim, so how did
> this get through?

I definitely used dim for all of these patches, but I'm not sure how I
lost my s-o-b on this one.  Maybe when I edited the commit message after
'dim extract-tags' I accidentally deleted an extra line when I removed
the extract-tags marker?  It's the only patch where the line is missing,
so it's almost certainly human error on my part rather than something
dim did wrong.

> Matt, can you pls figure out and type up the patch to
> plug that hole?

Are you referring to a patch for dim here?  The i915 patch has already
landed, so we can't change its commit message now.


Matt

> 
> Thanks, Daniel
> 
> > 
> > Regards, Joonas
> > 
> > Quoting Stephen Rothwell (2021-07-15 07:18:54)
> > > Hi all,
> > > 
> > > Commit
> > > 
> > >   db47fe727e1f ("drm/i915/step: s/<platform>_revid_tbl/<platform>_revids")
> > > 
> > > is missing a Signed-off-by from its committer.
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

Re: linux-next: Signed-off-by missing for commit in the drm-intel tree

[Daniel Vetter]

On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote:
> Hi Matt,
> 
> Always use the dim tooling when applying patches, it will do the right
> thing with regards to adding the S-o-b.

fd.o server rejects any pushes that haven't been done by dim, so how did
this get through? Matt, can you pls figure out and type up the patch to
plug that hole?

Thanks, Daniel

> 
> Regards, Joonas
> 
> Quoting Stephen Rothwell (2021-07-15 07:18:54)
> > Hi all,
> > 
> > Commit
> > 
> >   db47fe727e1f ("drm/i915/step: s/<platform>_revid_tbl/<platform>_revids")
> > 
> > is missing a Signed-off-by from its committer.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: linux-next: Signed-off-by missing for commit in the drm-intel tree

[Joonas Lahtinen]

Hi Matt,

Always use the dim tooling when applying patches, it will do the right
thing with regards to adding the S-o-b.

Regards, Joonas

Quoting Stephen Rothwell (2021-07-15 07:18:54)
> Hi all,
> 
> Commit
> 
>   db47fe727e1f ("drm/i915/step: s/<platform>_revid_tbl/<platform>_revids")
> 
> is missing a Signed-off-by from its committer.
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the drm-intel tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Hi all,

Commit

  db47fe727e1f ("drm/i915/step: s/<platform>_revid_tbl/<platform>_revids")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the drm-intel tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi all,

Commit

  8e525cb4a622 ("drm/i915/execlists: Move RPCS setup to context pin")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]