* [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
@ 2018-09-27 5:01 Vignesh R
2018-10-05 15:10 ` Lokesh Vutla
2018-10-05 19:10 ` Nishanth Menon
0 siblings, 2 replies; 5+ messages in thread
From: Vignesh R @ 2018-09-27 5:01 UTC (permalink / raw)
To: Tero Kristo
Cc: Nishanth Menon, Rob Herring, linux-arm-kernel, devicetree,
linux-kernel, Vignesh R
cbass_wakeup interconnect which is the parent of wakeup_uart node
defines address-cells=1 and size-cells=1, therefore fix up reg property
of wakeup_uart node accordingly. Otherwise, this UART instance fails to
probe if enabled.
Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Based on next-20180926
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index ee56959f4af8..c617393ea767 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -44,7 +44,7 @@
wkup_uart0: serial@42300000 {
compatible = "ti,am654-uart";
- reg = <0x00 0x42300000 0x00 0x100>;
+ reg = <0x42300000 0x100>;
reg-shift = <2>;
reg-io-width = <4>;
interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
2018-09-27 5:01 [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address Vignesh R
@ 2018-10-05 15:10 ` Lokesh Vutla
2018-11-07 21:00 ` Nishanth Menon
2018-10-05 19:10 ` Nishanth Menon
1 sibling, 1 reply; 5+ messages in thread
From: Lokesh Vutla @ 2018-10-05 15:10 UTC (permalink / raw)
To: Vignesh R, Tero Kristo
Cc: Nishanth Menon, devicetree, linux-kernel, Rob Herring, linux-arm-kernel
On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
> cbass_wakeup interconnect which is the parent of wakeup_uart node
> defines address-cells=1 and size-cells=1, therefore fix up reg property
> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> probe if enabled.
>
> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
2018-09-27 5:01 [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address Vignesh R
2018-10-05 15:10 ` Lokesh Vutla
@ 2018-10-05 19:10 ` Nishanth Menon
1 sibling, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2018-10-05 19:10 UTC (permalink / raw)
To: Vignesh R
Cc: Tero Kristo, Rob Herring, linux-arm-kernel, devicetree, linux-kernel
On 05:01-20180927, Vignesh R wrote:
> cbass_wakeup interconnect which is the parent of wakeup_uart node
> defines address-cells=1 and size-cells=1, therefore fix up reg property
> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> probe if enabled.
>
> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>
> Based on next-20180926
>
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index ee56959f4af8..c617393ea767 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -44,7 +44,7 @@
>
> wkup_uart0: serial@42300000 {
> compatible = "ti,am654-uart";
> - reg = <0x00 0x42300000 0x00 0x100>;
> + reg = <0x42300000 0x100>;
> reg-shift = <2>;
> reg-io-width = <4>;
> interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;
Thanks. Tero: we should probably queue for rc fixes. wkup_uart is used
by System Firmware logs (if enabled), so kernel usage is limited to some
specific platforms. This is a valid fix and my miss..
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
2018-10-05 15:10 ` Lokesh Vutla
@ 2018-11-07 21:00 ` Nishanth Menon
2018-11-09 16:45 ` Tero Kristo
0 siblings, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2018-11-07 21:00 UTC (permalink / raw)
To: Vutla, Lokesh
Cc: R, Vignesh, Kristo, Tero, devicetree, linux-kernel, Rob Herring,
linux-arm-kernel
On 10:10-20181005, Vutla, Lokesh wrote:
>
>
> On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
> > cbass_wakeup interconnect which is the parent of wakeup_uart node
> > defines address-cells=1 and size-cells=1, therefore fix up reg property
> > of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> > probe if enabled.
> >
> > Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Tero:
Could we pick this up for rc2? looks like $subject might be good to fix
up to:
arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address
instead of
arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
could be fixed locally.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
2018-11-07 21:00 ` Nishanth Menon
@ 2018-11-09 16:45 ` Tero Kristo
0 siblings, 0 replies; 5+ messages in thread
From: Tero Kristo @ 2018-11-09 16:45 UTC (permalink / raw)
To: Nishanth Menon, Vutla, Lokesh
Cc: R, Vignesh, devicetree, linux-kernel, Rob Herring, linux-arm-kernel
On 07/11/2018 23:00, Nishanth Menon wrote:
> On 10:10-20181005, Vutla, Lokesh wrote:
>>
>>
>> On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
>>> cbass_wakeup interconnect which is the parent of wakeup_uart node
>>> defines address-cells=1 and size-cells=1, therefore fix up reg property
>>> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
>>> probe if enabled.
>>>
>>> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>
>> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
>
> Tero:
>
> Could we pick this up for rc2? looks like $subject might be good to fix
> up to:
> arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address
> instead of
> arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
>
> could be fixed locally.
>
Thanks, queued up for 4.20-rc.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-09 16:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 5:01 [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address Vignesh R
2018-10-05 15:10 ` Lokesh Vutla
2018-11-07 21:00 ` Nishanth Menon
2018-11-09 16:45 ` Tero Kristo
2018-10-05 19:10 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).