* [PATCH 0/2] fpga: altera-cvp: clean checkpatch faults
@ 2018-11-08 1:13 capetry.dev
2018-11-08 1:13 ` [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier capetry.dev
2018-11-08 1:13 ` [PATCH 2/2] fpga: altera-cvp: Fix function definition argument capetry.dev
0 siblings, 2 replies; 4+ messages in thread
From: capetry.dev @ 2018-11-08 1:13 UTC (permalink / raw)
To: atull, mdf, linux-fpga, linux-kernel
From: Carlos A Petry <capetry.dev@gmail.com>
Insert missing or malformed SPDX-License-Identifier tag
WARNING: Missing or malformed SPDX-License-Identifier tag
Fix function definition argument 'struct altera_cvp_conf *'
WARNING: function definition argument 'struct altera_cvp_conf *'
Run checkpatch and all problem was fixed in the file.
This is my first contribution to the Kernel Project,
please let me know if something is wrong, thanks.
Carlos A Petry (2):
fpga: altera-cvp: Insert SPDX-License-Identifier
fpga: altera-cvp: Fix function definition argument
drivers/fpga/altera-cvp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier
2018-11-08 1:13 [PATCH 0/2] fpga: altera-cvp: clean checkpatch faults capetry.dev
@ 2018-11-08 1:13 ` capetry.dev
2018-11-12 23:08 ` Anatolij Gustschin
2018-11-08 1:13 ` [PATCH 2/2] fpga: altera-cvp: Fix function definition argument capetry.dev
1 sibling, 1 reply; 4+ messages in thread
From: capetry.dev @ 2018-11-08 1:13 UTC (permalink / raw)
To: atull, mdf, linux-fpga, linux-kernel
From: Carlos A Petry <capetry.dev@gmail.com>
Fix the following checkpatch warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Carlos A Petry <capetry.dev@gmail.com>
---
drivers/fpga/altera-cvp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 610a1558e..45b7c8c0b 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* FPGA Manager Driver for Altera Arria/Cyclone/Stratix CvP
*
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] fpga: altera-cvp: Fix function definition argument
2018-11-08 1:13 [PATCH 0/2] fpga: altera-cvp: clean checkpatch faults capetry.dev
2018-11-08 1:13 ` [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier capetry.dev
@ 2018-11-08 1:13 ` capetry.dev
1 sibling, 0 replies; 4+ messages in thread
From: capetry.dev @ 2018-11-08 1:13 UTC (permalink / raw)
To: atull, mdf, linux-fpga, linux-kernel
From: Carlos A Petry <capetry.dev@gmail.com>
Fix the following checkpatch warning:
WARNING: function definition argument 'struct altera_cvp_conf *'
Signed-off-by: Carlos A Petry <capetry.dev@gmail.com>
---
drivers/fpga/altera-cvp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 45b7c8c0b..150a9f5dd 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -66,7 +66,8 @@ struct altera_cvp_conf {
struct fpga_manager *mgr;
struct pci_dev *pci_dev;
void __iomem *map;
- void (*write_data)(struct altera_cvp_conf *, u32);
+ void (*write_data)(struct altera_cvp_conf *conf,
+ u32 data);
char mgr_name[64];
u8 numclks;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier
2018-11-08 1:13 ` [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier capetry.dev
@ 2018-11-12 23:08 ` Anatolij Gustschin
0 siblings, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2018-11-12 23:08 UTC (permalink / raw)
To: capetry.dev; +Cc: atull, mdf, linux-fpga, linux-kernel
On Wed, 7 Nov 2018 23:13:11 -0200
capetry.dev@gmail.com capetry.dev@gmail.com wrote:
...
>diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
>index 610a1558e..45b7c8c0b 100644
>--- a/drivers/fpga/altera-cvp.c
>+++ b/drivers/fpga/altera-cvp.c
>@@ -1,3 +1,4 @@
>+// SPDX-License-Identifier: GPL-2.0
when SPDX identifier is in place, shouldn't the GPL boilerplate below
be removed?
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-12 23:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 1:13 [PATCH 0/2] fpga: altera-cvp: clean checkpatch faults capetry.dev
2018-11-08 1:13 ` [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier capetry.dev
2018-11-12 23:08 ` Anatolij Gustschin
2018-11-08 1:13 ` [PATCH 2/2] fpga: altera-cvp: Fix function definition argument capetry.dev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).