Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files

From: Vinod Koul <vkoul@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files
Date: Fri, 9 Nov 2018 13:40:43 +0530	[thread overview]
Message-ID: <20181109081043.GN12092@vkoul-mobl> (raw)
In-Reply-To: <20181109050058.GI12092@vkoul-mobl>

On 09-11-18, 10:30, Vinod Koul wrote:

> > > +       clocks {
> > > +               xo_board: xo_board {
> > 
> > Build your dtbs with "W=12" and fix any warnings. You should get a
> > warning about '_'.
> 
> I did built it with W=1 though, so _ is not allowed?

I have fixed most of these with the exception of mmc-ddr-1_8v, as this
is documented in mmc bindings, so cant change this one. For this one I
am going to update gcc driver as well

> > > +       cpus {
> > > +               #address-cells = <1>;
> > > +               #size-cells = <0>;
> > > +
> > > +               CPU0: cpu@0 {
> > 
> > unit address is wrong.
> 
> Sorry am not sure I follow, can you please explain how..

Fixed now, thanks to Bjorn.

> > > +       memory@80000000 {
> > > +               device_type = "memory";
> > > +               /* We expect the bootloader to fill in the reg */
> > 
> > Can't you put in a default or base address at least.
> 
> Okay will try

Added now, will send update shortly

-- 
~Vinod