From: Rob Herring <robh+dt@kernel.org>
To: Vinod <vkoul@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files
Date: Thu, 8 Nov 2018 15:45:28 -0600 [thread overview]
Message-ID: <CAL_JsqKsCpofdsP_TojGxeCkv59r5Ce7-4Sz1B1V_QCL1eQDVg@mail.gmail.com> (raw)
In-Reply-To: <20181108184009.18430-2-vkoul@kernel.org>
On Thu, Nov 8, 2018 at 12:40 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> Add base dts files for QCS404 chipset along with cpu, timer,
> gcc and uart2 nodes.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 175 +++++++++++++++++++++++++++++++++++
> 1 file changed, 175 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/qcs404.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> new file mode 100644
> index 000000000000..b77d1198ba79
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -0,0 +1,175 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2018, Linaro Limited
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clock/qcom,gcc-qcs404.h>
> +
> +/ {
> + interrupt-parent = <&intc>;
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + chosen { };
> +
> + clocks {
> + xo_board: xo_board {
Build your dtbs with "W=12" and fix any warnings. You should get a
warning about '_'.
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <19200000>;
> + };
> + };
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + CPU0: cpu@0 {
unit address is wrong.
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x100>;
> + enable-method = "psci";
> + next-level-cache = <&L2_0>;
> + };
> +
> + CPU1: cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x101>;
> + enable-method = "psci";
> + next-level-cache = <&L2_0>;
> + };
> +
> + CPU2: cpu@2 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x102>;
> + enable-method = "psci";
> + next-level-cache = <&L2_0>;
> + };
> +
> + CPU3: cpu@3 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53";
> + reg = <0x103>;
> + enable-method = "psci";
> + next-level-cache = <&L2_0>;
> + };
> +
> + L2_0: l2-cache {
> + compatible = "cache";
> + cache-level = <2>;
> + };
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + /* We expect the bootloader to fill in the reg */
Can't you put in a default or base address at least.
> + reg = <0 0x0 0 0>;
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + soc: soc@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0 0xffffffff>;
> + compatible = "simple-bus";
> +
> + gcc: clock-controller@1800000 {
> + compatible = "qcom,gcc-qcs404";
> + reg = <0x01800000 0x80000>;
> + #clock-cells = <1>;
> +
> + assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>;
> + assigned-clock-rates = <19200000>;
> + };
> +
> + blsp1_uart2: serial@78b1000 {
> + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
> + reg = <0x078b1000 0x200>;
> + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>;
> + clock-names = "core", "iface";
> + status = "okay";
> + };
> +
> + intc: interrupt-controller@b000000 {
> + compatible = "qcom,msm-qgic2";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + reg = <0x0b000000 0x1000>,
> + <0x0b002000 0x1000>;
> + };
> +
> + timer@b120000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + compatible = "arm,armv7-timer-mem";
> + reg = <0x0b120000 0x1000>;
> + clock-frequency = <19200000>;
> +
> + frame@b121000 {
> + frame-number = <0>;
> + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b121000 0x1000>,
> + <0x0b122000 0x1000>;
> + };
> +
> + frame@b123000 {
> + frame-number = <1>;
> + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b123000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@b124000 {
> + frame-number = <2>;
> + interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b124000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@b125000 {
> + frame-number = <3>;
> + interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b125000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@b126000 {
> + frame-number = <4>;
> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b126000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@b127000 {
> + frame-number = <5>;
> + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0xb127000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@b128000 {
> + frame-number = <6>;
> + interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x0b128000 0x1000>;
> + status = "disabled";
> + };
> + };
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 2 0xff08>,
> + <GIC_PPI 3 0xff08>,
> + <GIC_PPI 4 0xff08>,
> + <GIC_PPI 1 0xff08>;
> + };
> +};
> --
> 2.14.4
>
next prev parent reply other threads:[~2018-11-08 21:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 18:39 [PATCH v4 00/18] arm64: dts: qcom: qcs404: Add Device tree nodes Vinod Koul
2018-11-08 18:39 ` [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files Vinod Koul
2018-11-08 21:45 ` Rob Herring [this message]
2018-11-09 5:00 ` Vinod Koul
2018-11-09 8:10 ` Vinod Koul
2018-11-08 18:39 ` [PATCH v4 02/18] arm64: dts: qcom: qcs404-evb: add dts files for EVBs Vinod Koul
2018-11-08 18:39 ` [PATCH v4 03/18] arm64: dts: qcom: qcs404: Add reserved-memory regions Vinod Koul
2018-11-08 18:39 ` [PATCH v4 04/18] arm64: dts: qcom: qcs404: Add RPM GLINK related nodes Vinod Koul
2018-11-08 18:39 ` [PATCH v4 05/18] arm64: dts: qcom: qcs404: Add PMS405 RPM regulators Vinod Koul
2018-11-08 18:39 ` [PATCH v4 06/18] arm64: dts: qcom: qcs404: add smp2p nodes Vinod Koul
2018-11-08 18:39 ` [PATCH v4 07/18] arm64: dts: qcom: qcs404: Add TLMM pinctrl node Vinod Koul
2018-11-08 18:39 ` [PATCH v4 08/18] arm64: dts: qcom: qcs404: Add sdcc1 node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 09/18] arm64: dts: qcom: pms405: add spmi node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 10/18] arm64: dts: qcom: qcs404: " Vinod Koul
2018-11-08 18:40 ` [PATCH v4 11/18] arm64: dts: qcom: pms405: add rtc node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 12/18] arm64: dts: qcom: pms405: add gpios Vinod Koul
2018-11-08 21:42 ` Rob Herring
2018-11-09 5:02 ` Vinod Koul
2018-11-08 18:40 ` [PATCH v4 13/18] arm64: dts: qcom: qcs404: Add scm firmware node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 14/18] arm64: dts: qcom: qcs404: Add remoteproc nodes Vinod Koul
2018-11-08 18:40 ` [PATCH v4 15/18] arm64: dts: qcom: qcs404: add prng-ee node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 16/18] arm64: dts: qcom: qcs404: Add BAM DMA node Vinod Koul
2018-11-08 18:40 ` [PATCH v4 17/18] arm64: dts: qcom: qcs404: Use BAM DMA for serial uart2 Vinod Koul
2018-11-08 18:40 ` [PATCH v4 18/18] arm64: dts: qcom: pms405: Add pon and pwrkey nodes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKsCpofdsP_TojGxeCkv59r5Ce7-4Sz1B1V_QCL1eQDVg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).