From: Gerd Hoffmann <kraxel@redhat.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Robert Foss <robert.foss@collabora.com>,
David Airlie <airlied@linux.ie>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization
Date: Fri, 9 Nov 2018 11:13:54 +0100 [thread overview]
Message-ID: <20181109101354.dc7cv4i4etu3bkhh@sirius.home.kraxel.org> (raw)
In-Reply-To: <CACvgo53vCBbgmu4OV4e0WeOYQSXNk=3qwyRBtPx+XAcCSZO8aQ@mail.gmail.com>
On Mon, Nov 05, 2018 at 05:25:05PM +0000, Emil Velikov wrote:
> On Mon, 5 Nov 2018 at 11:42, Robert Foss <robert.foss@collabora.com> wrote:
> >
> > When the execbuf call receives an in-fence it will get the dma_fence
> > related to that fence fd and wait on it before submitting the draw call.
> >
> > On the out-fence side we get fence returned by the submitted draw call
> > and attach it to a sync_file and send the sync_file fd to userspace. On
> > error -1 is returned to userspace.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
> > ---
> >
> > Changes since v3:
> > - Move all in_fence handling to the same VIRTGPU_EXECBUF_FENCE_FD_IN block
> Fwiw my suggestion was to explicitly document whether the IOCTL can
> support, simultaneously, IN and OUT fence.
Yes, that would be good. Code looks like it is supposed to work, but
explicitly saying so in the commit message would be nice.
Also: should we use separate fields for in/out fds?
cheers,
Gerd
next prev parent reply other threads:[~2018-11-09 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 11:41 [PATCH v4 0/4] virgl: fence fd support Robert Foss
2018-11-05 11:41 ` [PATCH v4 1/4] drm/virtio: add virtio_gpu_alloc_fence() Robert Foss
2018-11-05 11:41 ` [PATCH v4 2/4] drm/virtio: add uapi for in and out explicit fences Robert Foss
2018-11-05 11:41 ` [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization Robert Foss
2018-11-05 17:25 ` Emil Velikov
2018-11-05 18:08 ` Robert Foss
2018-11-09 10:13 ` Gerd Hoffmann [this message]
2018-11-09 17:13 ` Robert Foss
2018-11-12 9:10 ` Gerd Hoffmann
2018-11-05 11:41 ` [PATCH v4 4/4] drm/virtio: bump driver version after explicit synchronization addition Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109101354.dc7cv4i4etu3bkhh@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=emil.velikov@collabora.com \
--cc=gustavo.padovan@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.foss@collabora.com \
--cc=robh@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).