From: Vinod Koul <vkoul@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Sriharsha Allenki <sallenki@codeaurora.org>,
Anu Ramanathan <anur@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding
Date: Fri, 9 Nov 2018 16:36:47 +0530 [thread overview]
Message-ID: <20181109110647.GS12092@vkoul-mobl> (raw)
In-Reply-To: <20181109063134.GA20049@tiger>
On 09-11-18, 14:31, Shawn Guo wrote:
> On Fri, Nov 09, 2018 at 10:38:19AM +0530, Vinod Koul wrote:
> > On 08-11-18, 15:04, Shawn Guo wrote:
> > > +
> > > +- #phy-cells:
> > > + Value type: <u32>
> > > + Definition: Should be 0.
> >
> > I dont quite understand the definition that it should be 0, maybe you
> > mean allowed value is 0, if so why have this property?
>
> The property is defined by generic phy bindings phy/phy-bindings.txt.
> I can add a pointer to it if you think that's necessary. The property
> should be 0 for our device, because there is zero number cell in phy
> specifier from dwc3 node as shown in the example.
That makes sense, also does it make sense it mention the properties in
phy/phy-bindings.txt, why not refer that here for the properties we use
and vlaues.
>
> dwc3@78c0000 {
> ...
> phys = <&usb2_phy_prim>;
> phy-names = "usb2-phy";
> }
>
> And for that reason, we can use the generic .of_xlate implementation
> of_phy_simple_xlate() provided by phy core. There are some comments
> in kernel doc of of_phy_simple_xlate() which might be helpful.
>
> Shawn
--
~Vinod
next prev parent reply other threads:[~2018-11-09 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 7:04 [PATCH 0/2] Add Synopsys High-Speed USB PHY driver for Qualcomm SoCs Shawn Guo
2018-11-08 7:04 ` [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding Shawn Guo
2018-11-09 5:08 ` Vinod Koul
2018-11-09 6:31 ` Shawn Guo
2018-11-09 11:06 ` Vinod Koul [this message]
[not found] ` <5bea0ed8.1c69fb81.8715.38b2@mx.google.com>
2018-11-13 3:42 ` Shawn Guo
2018-11-13 4:59 ` Shawn Guo
2018-11-17 15:13 ` Rob Herring
2018-11-19 6:55 ` Shawn Guo
2018-11-19 7:10 ` Vivek Gautam
2018-11-19 9:15 ` Shawn Guo
2018-11-08 7:04 ` [PATCH 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver Shawn Guo
2018-11-09 5:22 ` Vinod Koul
2018-11-09 6:52 ` Shawn Guo
2018-11-09 11:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109110647.GS12092@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=anur@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).