From: Shawn Guo <shawn.guo@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>, kishon <kishon@ti.com>,
sallenki@codeaurora.org, anur@codeaurora.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
vkoul@kernel.org, linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding
Date: Mon, 19 Nov 2018 17:15:27 +0800 [thread overview]
Message-ID: <20181119091523.GC10788@dragon> (raw)
In-Reply-To: <CAFp+6iGmsLT8UOk+-4zOKkYxJbkhqy=oDw2ZqrXLDCGbF8uTHA@mail.gmail.com>
On Mon, Nov 19, 2018 at 12:40:59PM +0530, Vivek Gautam wrote:
> On Mon, Nov 19, 2018 at 12:29 PM Shawn Guo <shawn.guo@linaro.org> wrote:
> >
> > On Sat, Nov 17, 2018 at 09:13:38AM -0600, Rob Herring wrote:
> > <snip>
> > > > > > +- qcom,init-seq:
> > > > > > + Value type: <u32 array>
> > > > > > + Definition: Should contain a sequence of <offset value delay> tuples to
> > > > > > + program 'value' into phy register at 'offset' with 'delay'
> > > > > > + in us afterwards.
> > > > >
> > > > > If we wanted this type of thing in DT, we'd have a generic binding (or
> > > > > forth).
> > > >
> > > > Right now, this is a qualcomm usb phy specific bindings - first used in
> > > > qcom,usb-hs-phy.txt and I extended it a bit for my phy. As this is not
> > > > a so good hardware description, I'm a little hesitated to make it
> > > > generic for other platforms to use in general. What about we put off it
> > > > a little bit until we see more platforms need the same thing?
> > >
> > > I'm not saying I want it generic. Quite the opposite. I don't think we
> > > should have it either generically or vendor specific. The main thing I
> > > have a problem with is the timing information because then we're more
> > > that just data. Without that we're talking about a bunch of properties
> > > for register fields or just raw register values in DT. That becomes
> > > more of a judgement call. There's not too much value in making a
> > > driver translate a bunch of properties just to stuff them into
> > > registers on init. But then just allowing any raw register value to be
> > > in DT could be easily abused.
> >
> > Rob,
> >
> > I agree with your comments. Honestly, I'm not comfortable with this
> > 'qcom,init-seq' thing in the first impression. The similar existence in
> > mainline qcom,usb-hs-phy.txt makes me think it might be acceptable with
> > the timing data added. Okay, I know your position on this now.
> >
> > @Sriharsha,
> >
> > Seeing that 'qcom,init-seq' is being configured with the exactly same
> > values for both HS phys in SoC level dts file (qcs404.dtsi), I think
> > such settings can be moved into driver code as SoC specific data.
> > Unless you have a different view on this, I will do it with v4.
>
> phy-qcom-qmp and phy-qcom-qusb2 have been maintaining such SoC specific
> init sequences in the drivers if you would like to have pointers from them.
Thanks for the pointer, Vivek. That helps.
Shawn
next prev parent reply other threads:[~2018-11-19 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 7:04 [PATCH 0/2] Add Synopsys High-Speed USB PHY driver for Qualcomm SoCs Shawn Guo
2018-11-08 7:04 ` [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding Shawn Guo
2018-11-09 5:08 ` Vinod Koul
2018-11-09 6:31 ` Shawn Guo
2018-11-09 11:06 ` Vinod Koul
[not found] ` <5bea0ed8.1c69fb81.8715.38b2@mx.google.com>
2018-11-13 3:42 ` Shawn Guo
2018-11-13 4:59 ` Shawn Guo
2018-11-17 15:13 ` Rob Herring
2018-11-19 6:55 ` Shawn Guo
2018-11-19 7:10 ` Vivek Gautam
2018-11-19 9:15 ` Shawn Guo [this message]
2018-11-08 7:04 ` [PATCH 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver Shawn Guo
2018-11-09 5:22 ` Vinod Koul
2018-11-09 6:52 ` Shawn Guo
2018-11-09 11:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119091523.GC10788@dragon \
--to=shawn.guo@linaro.org \
--cc=anur@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).