[PATCH] drivers/android/binder.c: Remove duplicate header

[PATCH] drivers/android/binder.c: Remove duplicate header

[Brajeswar Ghosh]

Remove binder_trace.h which is included more than once

Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
---
 drivers/android/binder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index cb30a524d16d..719f35a5c04b 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -5852,6 +5852,5 @@ static int __init binder_init(void)
 device_initcall(binder_init);
 
 #define CREATE_TRACE_POINTS
-#include "binder_trace.h"
 
 MODULE_LICENSE("GPL v2");
-- 
2.17.1

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

[Greg KH]

On Fri, Nov 09, 2018 at 09:44:25AM +0530, Brajeswar Ghosh wrote:
> Remove binder_trace.h which is included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index cb30a524d16d..719f35a5c04b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5852,6 +5852,5 @@ static int __init binder_init(void)
>  device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");

Are you sure about this?  Did you test the tracepoint functionality
after removing that line?  I think you just broke it :(

thanks,

greg k-h

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5784 bytes --]

Hi Brajeswar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Brajeswar-Ghosh/drivers-android-binder-c-Remove-duplicate-header/20181109-154717
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/android/binder.o: In function `binder_free_buf':
>> binder.c:(.text+0x3c46): undefined reference to `__tracepoint_binder_transaction_buffer_release'
   binder.c:(.text+0x3c91): undefined reference to `__tracepoint_binder_transaction_buffer_release'
   drivers/android/binder.o: In function `binder_transaction':
>> binder.c:(.text+0x4a85): undefined reference to `__tracepoint_binder_transaction'
   binder.c:(.text+0x4af8): undefined reference to `__tracepoint_binder_transaction'
>> binder.c:(.text+0x4c33): undefined reference to `__tracepoint_binder_transaction_alloc_buf'
   binder.c:(.text+0x4c90): undefined reference to `__tracepoint_binder_transaction_alloc_buf'
>> binder.c:(.text+0x522b): undefined reference to `__tracepoint_binder_transaction_node_to_ref'
   binder.c:(.text+0x5279): undefined reference to `__tracepoint_binder_transaction_node_to_ref'
>> binder.c:(.text+0x549b): undefined reference to `__tracepoint_binder_transaction_ref_to_node'
   binder.c:(.text+0x54ee): undefined reference to `__tracepoint_binder_transaction_ref_to_node'
>> binder.c:(.text+0x55fd): undefined reference to `__tracepoint_binder_transaction_ref_to_ref'
   binder.c:(.text+0x5655): undefined reference to `__tracepoint_binder_transaction_ref_to_ref'
>> binder.c:(.text+0x61c5): undefined reference to `__tracepoint_binder_transaction_failed_buffer_release'
   binder.c:(.text+0x6220): undefined reference to `__tracepoint_binder_transaction_failed_buffer_release'
   drivers/android/binder.o: In function `binder_thread_write':
>> binder.c:(.text+0x6656): undefined reference to `__tracepoint_binder_command'
   binder.c:(.text+0x66a1): undefined reference to `__tracepoint_binder_command'
   drivers/android/binder.o: In function `binder_put_node_cmd':
>> binder.c:(.text+0x7976): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x79d1): undefined reference to `__tracepoint_binder_return'
   drivers/android/binder.o: In function `binder_thread_read':
>> binder.c:(.text+0x7bf9): undefined reference to `__tracepoint_binder_wait_for_work'
   binder.c:(.text+0x7c71): undefined reference to `__tracepoint_binder_wait_for_work'
   binder.c:(.text+0x810e): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x8161): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x824e): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x82a1): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x888e): undefined reference to `__tracepoint_binder_return'
   drivers/android/binder.o:binder.c:(.text+0x88e1): more undefined references to `__tracepoint_binder_return' follow
   drivers/android/binder.o: In function `binder_thread_read':
>> binder.c:(.text+0x8bcf): undefined reference to `__tracepoint_binder_transaction_fd_recv'
   binder.c:(.text+0x8c39): undefined reference to `__tracepoint_binder_transaction_fd_recv'
   binder.c:(.text+0x8ebe): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x8f11): undefined reference to `__tracepoint_binder_return'
>> binder.c:(.text+0x90b2): undefined reference to `__tracepoint_binder_transaction_received'
   binder.c:(.text+0x90fb): undefined reference to `__tracepoint_binder_transaction_received'
   binder.c:(.text+0x9172): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x91bb): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x947d): undefined reference to `__tracepoint_binder_return'
   binder.c:(.text+0x94c5): undefined reference to `__tracepoint_binder_return'
   drivers/android/binder.o: In function `binder_ioctl_write_read.isra.11':
>> binder.c:(.text+0x9796): undefined reference to `__tracepoint_binder_write_done'
   binder.c:(.text+0x97e1): undefined reference to `__tracepoint_binder_write_done'
>> binder.c:(.text+0x98e6): undefined reference to `__tracepoint_binder_read_done'
   binder.c:(.text+0x9931): undefined reference to `__tracepoint_binder_read_done'
   drivers/android/binder.o: In function `binder_ioctl':
>> binder.c:(.text+0x9ab6): undefined reference to `__tracepoint_binder_ioctl'
   binder.c:(.text+0x9b11): undefined reference to `__tracepoint_binder_ioctl'
>> binder.c:(.text+0xa106): undefined reference to `__tracepoint_binder_ioctl_done'
   binder.c:(.text+0xa155): undefined reference to `__tracepoint_binder_ioctl_done'
   drivers/android/binder.o: In function `binder_translate_fd.isra.10':
>> binder.c:(.text.unlikely+0x37a): undefined reference to `__tracepoint_binder_transaction_fd_send'
   binder.c:(.text.unlikely+0x3cc): undefined reference to `__tracepoint_binder_transaction_fd_send'
>> drivers/android/binder.o:(__jump_table+0x8): undefined reference to `__tracepoint_binder_transaction_fd_send'
>> drivers/android/binder.o:(__jump_table+0x14): undefined reference to `__tracepoint_binder_transaction_buffer_release'
>> drivers/android/binder.o:(__jump_table+0x20): undefined reference to `__tracepoint_binder_transaction'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66013 bytes --]

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

[Greg KH]

On Fri, Nov 09, 2018 at 10:40:14PM +0800, kbuild test robot wrote:
> Hi Brajeswar,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.20-rc1 next-20181109]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Brajeswar-Ghosh/drivers-android-binder-c-Remove-duplicate-header/20181109-154717
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):

<snip>

Yeah, I was right :(

Always test-build your patches.

greg k-h

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

[Souptick Joarder]

On Fri, Nov 9, 2018 at 8:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Nov 09, 2018 at 10:40:14PM +0800, kbuild test robot wrote:
> > Hi Brajeswar,
> >
> > Thank you for the patch! Yet something to improve:
> >
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.20-rc1 next-20181109]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/Brajeswar-Ghosh/drivers-android-binder-c-Remove-duplicate-header/20181109-154717
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> > All errors (new ones prefixed by >>):
>
> <snip>
>
> Yeah, I was right :(
>
> Always test-build your patches.

Sorry about it. It was a mistake from our side.

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3521 bytes --]

Hi Brajeswar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Brajeswar-Ghosh/drivers-android-binder-c-Remove-duplicate-header/20181109-154717
config: i386-randconfig-i3-201844 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/android/binder.o: In function `__read_once_size':
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_return'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_return'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_return'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_buffer_release'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_buffer_release'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_buffer_release'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_wait_for_work'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_fd_recv'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_wait_for_work'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_fd_recv'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_fd_recv'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_wait_for_work'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_received'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_received'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_received'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_alloc_buf'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_failed_buffer_release'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction'
>> include/linux/compiler.h:182: undefined reference to `__tracepoint_binder_transaction_alloc_buf'

vim +182 include/linux/compiler.h

d976441f Andrey Ryabinin       2015-10-19  178  
d976441f Andrey Ryabinin       2015-10-19  179  static __always_inline
d976441f Andrey Ryabinin       2015-10-19  180  void __read_once_size(const volatile void *p, void *res, int size)
230fa253 Christian Borntraeger 2014-11-25  181  {
d976441f Andrey Ryabinin       2015-10-19 @182  	__READ_ONCE_SIZE;
230fa253 Christian Borntraeger 2014-11-25  183  }
d976441f Andrey Ryabinin       2015-10-19  184  

:::::: The code at line 182 was first introduced by commit
:::::: d976441f44bc5d48635d081d277aa76556ffbf8b compiler, atomics, kasan: Provide READ_ONCE_NOCHECK()

:::::: TO: Andrey Ryabinin <aryabinin@virtuozzo.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28540 bytes --]