linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/3] i2c-omap: Enable i2c-omap driver for AM654 SoCs
@ 2018-11-08  9:19 Vignesh R
  2018-11-08  9:19 ` [PATCH v3 1/3] dt-bindings: i2c-omap: Add new compatible " Vignesh R
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Vignesh R @ 2018-11-08  9:19 UTC (permalink / raw)
  To: Wolfram Sang, Tony Lindgren
  Cc: Vignesh R, Rob Herring, Grygorii Strashko, linux-omap, linux-i2c,
	devicetree, linux-kernel

Couple of patches to enable i2c-omap driver to be used with TI's new
AM654 platforms.

v3:
Rebase onto v4.20-rc1
Collect Reviewed-by's on v2
Add a patch to MAINTAINERS for i2c-omap.c

Vignesh R (3):
  dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
  i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3
  MAINTAINERS: Add entry for i2c-omap driver

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 MAINTAINERS                                        | 8 ++++++++
 drivers/i2c/busses/Kconfig                         | 2 +-
 3 files changed, 15 insertions(+), 3 deletions(-)

-- 
2.19.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3 1/3] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
  2018-11-08  9:19 [PATCH v3 0/3] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
@ 2018-11-08  9:19 ` Vignesh R
  2018-11-08  9:19 ` [PATCH v3 2/3] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
  2018-11-08  9:19 ` [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver Vignesh R
  2 siblings, 0 replies; 10+ messages in thread
From: Vignesh R @ 2018-11-08  9:19 UTC (permalink / raw)
  To: Wolfram Sang, Tony Lindgren
  Cc: Vignesh R, Rob Herring, Grygorii Strashko, linux-omap, linux-i2c,
	devicetree, linux-kernel

AM654 SoCs have same I2C IP as OMAP SoCs. Add new compatible to
handle AM654 SoCs. While at that reformat the existing compatible list
for older SoCs to list one valid compatible per line.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
index 7e49839d4124..4b90ba9f31b7 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
@@ -1,8 +1,12 @@
 I2C for OMAP platforms
 
 Required properties :
-- compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
-  or "ti,omap4-i2c"
+- compatible : Must be
+	"ti,omap2420-i2c" for OMAP2420 SoCs
+	"ti,omap2430-i2c" for OMAP2430 SoCs
+	"ti,omap3-i2c" for OMAP3 SoCs
+	"ti,omap4-i2c" for OMAP4+ SoCs
+	"ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
 - ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
 - #address-cells = <1>;
 - #size-cells = <0>;
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 2/3] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3
  2018-11-08  9:19 [PATCH v3 0/3] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
  2018-11-08  9:19 ` [PATCH v3 1/3] dt-bindings: i2c-omap: Add new compatible " Vignesh R
@ 2018-11-08  9:19 ` Vignesh R
  2018-11-08  9:19 ` [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver Vignesh R
  2 siblings, 0 replies; 10+ messages in thread
From: Vignesh R @ 2018-11-08  9:19 UTC (permalink / raw)
  To: Wolfram Sang, Tony Lindgren
  Cc: Vignesh R, Rob Herring, Grygorii Strashko, linux-omap, linux-i2c,
	devicetree, linux-kernel

Allow I2C_OMAP to be built for K3 platforms.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 56ccb1ea7da5..77dc94b44011 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -752,7 +752,7 @@ config I2C_OCORES
 
 config I2C_OMAP
 	tristate "OMAP I2C adapter"
-	depends on ARCH_OMAP
+	depends on ARCH_OMAP || ARCH_K3
 	default y if MACH_OMAP_H3 || MACH_OMAP_OSK
 	help
 	  If you say yes to this option, support will be included for the
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-08  9:19 [PATCH v3 0/3] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
  2018-11-08  9:19 ` [PATCH v3 1/3] dt-bindings: i2c-omap: Add new compatible " Vignesh R
  2018-11-08  9:19 ` [PATCH v3 2/3] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
@ 2018-11-08  9:19 ` Vignesh R
  2018-11-08  9:23   ` Wolfram Sang
  2 siblings, 1 reply; 10+ messages in thread
From: Vignesh R @ 2018-11-08  9:19 UTC (permalink / raw)
  To: Wolfram Sang, Tony Lindgren
  Cc: Vignesh R, Rob Herring, Grygorii Strashko, linux-omap, linux-i2c,
	devicetree, linux-kernel

Add separate entry for i2c-omap and add my name as reviewer for this
driver.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8d4c874a5d6e..6519eea4813e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10821,6 +10821,14 @@ L:	linux-omap@vger.kernel.org
 S:	Maintained
 F:	arch/arm/mach-omap2/omap_hwmod.*
 
+OMAP I2C DRIVER
+R:	Vignesh R <vigneshr@ti.com>
+L:	linux-omap@vger.kernel.org
+L:	linux-i2c@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/i2c/i2c-omap.txt
+F:	drivers/i2c/busses/i2c-omap.c
+
 OMAP IMAGING SUBSYSTEM (OMAP3 ISP and OMAP4 ISS)
 M:	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
 L:	linux-media@vger.kernel.org
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-08  9:19 ` [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver Vignesh R
@ 2018-11-08  9:23   ` Wolfram Sang
  2018-11-08 12:28     ` Vignesh R
  0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2018-11-08  9:23 UTC (permalink / raw)
  To: Vignesh R
  Cc: Wolfram Sang, Tony Lindgren, Rob Herring, Grygorii Strashko,
	linux-omap, linux-i2c, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

On Thu, Nov 08, 2018 at 02:49:31PM +0530, Vignesh R wrote:
> Add separate entry for i2c-omap and add my name as reviewer for this
> driver.

Thanks for stepping up, yet out of curiosity: why not maintainer?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-08  9:23   ` Wolfram Sang
@ 2018-11-08 12:28     ` Vignesh R
  2018-11-08 15:02       ` Tony Lindgren
  0 siblings, 1 reply; 10+ messages in thread
From: Vignesh R @ 2018-11-08 12:28 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Wolfram Sang, Tony Lindgren, Rob Herring, Strashko, Grygorii,
	linux-omap, linux-i2c, devicetree, linux-kernel



On 08/11/18 2:53 PM, Wolfram Sang wrote:
> On Thu, Nov 08, 2018 at 02:49:31PM +0530, Vignesh R wrote:
>> Add separate entry for i2c-omap and add my name as reviewer for this
>> driver.
> 
> Thanks for stepping up, yet out of curiosity: why not maintainer?
> 

I wasn't sure whether the convention is to add Reviewer or Maintainer
entry for individual driver. I would be glad to change entry to maintainer.


-- 
Regards
Vignesh

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-08 12:28     ` Vignesh R
@ 2018-11-08 15:02       ` Tony Lindgren
  2018-11-09 15:55         ` Wolfram Sang
  0 siblings, 1 reply; 10+ messages in thread
From: Tony Lindgren @ 2018-11-08 15:02 UTC (permalink / raw)
  To: Vignesh R
  Cc: Wolfram Sang, Wolfram Sang, Rob Herring, Strashko, Grygorii,
	linux-omap, linux-i2c, devicetree, linux-kernel

* Vignesh R <vigneshr@ti.com> [181108 12:28]:
> 
> 
> On 08/11/18 2:53 PM, Wolfram Sang wrote:
> > On Thu, Nov 08, 2018 at 02:49:31PM +0530, Vignesh R wrote:
> >> Add separate entry for i2c-omap and add my name as reviewer for this
> >> driver.
> > 
> > Thanks for stepping up, yet out of curiosity: why not maintainer?
> > 
> 
> I wasn't sure whether the convention is to add Reviewer or Maintainer
> entry for individual driver. I would be glad to change entry to maintainer.

Great, yes please do!

Regards,

Tony

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-08 15:02       ` Tony Lindgren
@ 2018-11-09 15:55         ` Wolfram Sang
  2018-11-09 15:56           ` Wolfram Sang
  0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2018-11-09 15:55 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Vignesh R, Wolfram Sang, Rob Herring, Strashko, Grygorii,
	linux-omap, linux-i2c, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Thu, Nov 08, 2018 at 07:02:31AM -0800, Tony Lindgren wrote:
> * Vignesh R <vigneshr@ti.com> [181108 12:28]:
> > 
> > 
> > On 08/11/18 2:53 PM, Wolfram Sang wrote:
> > > On Thu, Nov 08, 2018 at 02:49:31PM +0530, Vignesh R wrote:
> > >> Add separate entry for i2c-omap and add my name as reviewer for this
> > >> driver.
> > > 
> > > Thanks for stepping up, yet out of curiosity: why not maintainer?
> > > 
> > 
> > I wasn't sure whether the convention is to add Reviewer or Maintainer
> > entry for individual driver. I would be glad to change entry to maintainer.
> 
> Great, yes please do!

Cool, thanks all! Tony, I took the liberty to interpret this message as
an Acked-by so I could apply V3 of this series right away.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-09 15:55         ` Wolfram Sang
@ 2018-11-09 15:56           ` Wolfram Sang
  2018-11-09 16:10             ` Tony Lindgren
  0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2018-11-09 15:56 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Vignesh R, Wolfram Sang, Rob Herring, Strashko, Grygorii,
	linux-omap, linux-i2c, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

> Cool, thanks all! Tony, I took the liberty to interpret this message as
> an Acked-by so I could apply V3 of this series right away.

Doh, v4 I meant. Sorry for the noise.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver
  2018-11-09 15:56           ` Wolfram Sang
@ 2018-11-09 16:10             ` Tony Lindgren
  0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2018-11-09 16:10 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Vignesh R, Wolfram Sang, Rob Herring, Strashko, Grygorii,
	linux-omap, linux-i2c, devicetree, linux-kernel

* Wolfram Sang <wsa@the-dreams.de> [181109 15:56]:
> > Cool, thanks all! Tony, I took the liberty to interpret this message as
> > an Acked-by so I could apply V3 of this series right away.
> 
> Doh, v4 I meant. Sorry for the noise.

OK

Thanks,

Tony



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-11-09 16:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08  9:19 [PATCH v3 0/3] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
2018-11-08  9:19 ` [PATCH v3 1/3] dt-bindings: i2c-omap: Add new compatible " Vignesh R
2018-11-08  9:19 ` [PATCH v3 2/3] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
2018-11-08  9:19 ` [PATCH v3 3/3] MAINTAINERS: Add entry for i2c-omap driver Vignesh R
2018-11-08  9:23   ` Wolfram Sang
2018-11-08 12:28     ` Vignesh R
2018-11-08 15:02       ` Tony Lindgren
2018-11-09 15:55         ` Wolfram Sang
2018-11-09 15:56           ` Wolfram Sang
2018-11-09 16:10             ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).