* [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>
@ 2018-10-16 4:33 Masahiro Yamada
2018-10-16 11:59 ` Boris Brezillon
2018-11-11 20:53 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-10-16 4:33 UTC (permalink / raw)
To: linux-mtd, Boris Brezillon, Miquel Raynal
Cc: Masahiro Yamada, linux-kernel, Marek Vasut, Brian Norris,
Richard Weinberger, David Woodhouse
The reason of including <linux/bitops.h> here is just for BIT() and
GENMASK macros.
Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
macros from <linux/bitops.h> to a new <linux/bits.h> file"),
<linux/bits.h> is enough for such compile-time macros.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mtd/nand/raw/denali.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
index 57a5498..25c0060 100644
--- a/drivers/mtd/nand/raw/denali.h
+++ b/drivers/mtd/nand/raw/denali.h
@@ -7,7 +7,7 @@
#ifndef __DENALI_H__
#define __DENALI_H__
-#include <linux/bitops.h>
+#include <linux/bits.h>
#include <linux/completion.h>
#include <linux/mtd/rawnand.h>
#include <linux/spinlock_types.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>
2018-10-16 4:33 [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
@ 2018-10-16 11:59 ` Boris Brezillon
2018-11-11 20:53 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-10-16 11:59 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mtd, Miquel Raynal, linux-kernel, Marek Vasut,
Brian Norris, Richard Weinberger, David Woodhouse
On Tue, 16 Oct 2018 13:33:21 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
>
> drivers/mtd/nand/raw/denali.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
> index 57a5498..25c0060 100644
> --- a/drivers/mtd/nand/raw/denali.h
> +++ b/drivers/mtd/nand/raw/denali.h
> @@ -7,7 +7,7 @@
> #ifndef __DENALI_H__
> #define __DENALI_H__
>
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/completion.h>
> #include <linux/mtd/rawnand.h>
> #include <linux/spinlock_types.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>
2018-10-16 4:33 [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
2018-10-16 11:59 ` Boris Brezillon
@ 2018-11-11 20:53 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2018-11-11 20:53 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mtd, Boris Brezillon, linux-kernel, Marek Vasut,
Brian Norris, Richard Weinberger, David Woodhouse
Hi Masahiro,
Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Tue, 16 Oct
2018 13:33:21 +0900:
> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to nand/next.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-11 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 4:33 [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h> Masahiro Yamada
2018-10-16 11:59 ` Boris Brezillon
2018-11-11 20:53 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).