* [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type
@ 2018-11-13 8:45 Paolo Cretaro
2018-11-13 10:15 ` Cornelia Huck
2018-12-12 22:45 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Cretaro @ 2018-11-13 8:45 UTC (permalink / raw)
To: kwankhede, alex.williamson; +Cc: kvm, linux-kernel, Paolo Cretaro
Set add_mdev_supported_type as static since it is only used within
mdev_sysfs.c.
This fixes -Wmissing-prototypes gcc warning.
Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
---
drivers/vfio/mdev/mdev_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index 249472f05509..ce5dd219f2c8 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -92,8 +92,8 @@ static struct kobj_type mdev_type_ktype = {
.release = mdev_type_release,
};
-struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
- struct attribute_group *group)
+static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
+ struct attribute_group *group)
{
struct mdev_type *type;
int ret;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type
2018-11-13 8:45 [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type Paolo Cretaro
@ 2018-11-13 10:15 ` Cornelia Huck
2018-12-12 22:45 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2018-11-13 10:15 UTC (permalink / raw)
To: Paolo Cretaro; +Cc: kwankhede, alex.williamson, kvm, linux-kernel
On Tue, 13 Nov 2018 09:45:43 +0100
Paolo Cretaro <paolocretaro@gmail.com> wrote:
> Set add_mdev_supported_type as static since it is only used within
> mdev_sysfs.c.
> This fixes -Wmissing-prototypes gcc warning.
>
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index 249472f05509..ce5dd219f2c8 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -92,8 +92,8 @@ static struct kobj_type mdev_type_ktype = {
> .release = mdev_type_release,
> };
>
> -struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> - struct attribute_group *group)
> +static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> + struct attribute_group *group)
> {
> struct mdev_type *type;
> int ret;
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type
2018-11-13 8:45 [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type Paolo Cretaro
2018-11-13 10:15 ` Cornelia Huck
@ 2018-12-12 22:45 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2018-12-12 22:45 UTC (permalink / raw)
To: Paolo Cretaro; +Cc: kwankhede, kvm, linux-kernel
On Tue, 13 Nov 2018 09:45:43 +0100
Paolo Cretaro <paolocretaro@gmail.com> wrote:
> Set add_mdev_supported_type as static since it is only used within
> mdev_sysfs.c.
> This fixes -Wmissing-prototypes gcc warning.
>
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index 249472f05509..ce5dd219f2c8 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -92,8 +92,8 @@ static struct kobj_type mdev_type_ktype = {
> .release = mdev_type_release,
> };
>
> -struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> - struct attribute_group *group)
> +static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> + struct attribute_group *group)
> {
> struct mdev_type *type;
> int ret;
Applied to vfio next branch with Cornlia's review. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 8:45 [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type Paolo Cretaro
2018-11-13 10:15 ` Cornelia Huck
2018-12-12 22:45 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).