From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
Cc: Schrempf Frieder <frieder.schrempf@kontron.De>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Mark Brown <broonie@kernel.org>, Han Xu <han.xu@nxp.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"richard@nod.at" <richard@nod.at>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
David Wolfe <david.wolfe@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/9] spi: Add a driver for the Freescale/NXP QuadSPI controller
Date: Wed, 14 Nov 2018 11:46:51 +0100 [thread overview]
Message-ID: <20181114114651.6f995fc8@bbrezillon> (raw)
In-Reply-To: <VI1PR04MB572664063A0E237D2EB7203A99C30@VI1PR04MB5726.eurprd04.prod.outlook.com>
On Wed, 14 Nov 2018 10:43:00 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Hi Frieder,
>
> [..]
> > >
> > > Ok, I will have a look at what could make the chip selection fail in
> > > case of AHB read.
> >
> > Could you try with this change applied:
> >
> > @@ -503,7 +503,7 @@ static void fsl_qspi_select_mem(struct fsl_qspi *q, struct
> > spi_device *spi)
> > map_addr = q->memmap_phy;
> > else
> > map_addr = q->memmap_phy +
> > - 2 * q->devtype_data->ahb_buf_size;
> > + q->devtype_data->ahb_buf_size;
> >
> > qspi_writel(q, map_addr, q->iobase + QUADSPI_SFA1AD +
> > (i * 4));
> > }
> >
>
> I have tried above change and also have done few more changes but still AHB read for CS1 is falling.
Have plugged a scope on the CS1 line, to make sure it's properly
asserted when the memory is accessed?
>
> I guess we need to implement dynamic memory mapping [1] for AHB Read as was being done in previous driver implementation.
> Would try this and update you.
Sorry but I don't see why it would solve the problem we have here, but
if it does, I'd like to have a clear explanation ;-).
next prev parent reply other threads:[~2018-11-14 10:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 13:47 [PATCH v5 0/9] Port the FSL QSPI driver to the SPI framework Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 1/9] ARM: dts: Reflect change of FSL QSPI driver and remove unused properties Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 2/9] arm64: " Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 3/9] spi: Add a driver for the Freescale/NXP QuadSPI controller Schrempf Frieder
2018-11-14 8:39 ` Yogesh Narayan Gaur
2018-11-14 8:50 ` Schrempf Frieder
2018-11-14 9:03 ` Schrempf Frieder
2018-11-14 10:43 ` Yogesh Narayan Gaur
2018-11-14 10:46 ` Boris Brezillon [this message]
2018-11-14 11:07 ` Schrempf Frieder
2018-11-15 6:22 ` Yogesh Narayan Gaur
2018-11-15 11:43 ` Schrempf Frieder
2018-11-15 13:12 ` Boris Brezillon
2018-11-15 14:01 ` Schrempf Frieder
2018-11-16 5:41 ` Yogesh Narayan Gaur
2018-11-16 9:42 ` Schrempf Frieder
2018-11-16 9:46 ` Yogesh Narayan Gaur
2018-11-16 10:10 ` Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 4/9] dt-bindings: spi: Move the bindings for the FSL QSPI driver Schrempf Frieder
2018-11-16 22:59 ` Rob Herring
2018-11-13 13:47 ` [PATCH v5 5/9] dt-bindings: spi: Adjust " Schrempf Frieder
2018-11-16 22:59 ` Rob Herring
2018-11-13 13:47 ` [PATCH v5 6/9] mtd: fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 7/9] ARM: dts: ls1021a: Remove fsl,qspi-has-second-chip as it is not used Schrempf Frieder
2018-11-13 13:47 ` [PATCH v5 8/9] ARM64: dts: ls1046a: " Schrempf Frieder
2018-11-13 13:48 ` [PATCH v5 9/9] MAINTAINERS: Move the Freescale QSPI driver to the SPI framework Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114114651.6f995fc8@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=david.wolfe@nxp.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@nxp.com \
--cc=frieder.schrempf@kontron.De \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prabhakar.kushwaha@nxp.com \
--cc=richard@nod.at \
--cc=shawnguo@kernel.org \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).