From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 0/5] media: Allwinner A10 CSI support
Date: Thu, 15 Nov 2018 20:10:31 +0100 [thread overview]
Message-ID: <20181115191031.7jpb2g23fksof625@flea> (raw)
In-Reply-To: <CAGb2v66ygbcomUMkcv8qMCAs_qviFMPzpxj-F4=YBrpuLrdSUw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]
Hi,
On Wed, Nov 14, 2018 at 11:24:48AM +0800, Chen-Yu Tsai wrote:
> On Tue, Nov 13, 2018 at 4:24 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > Here is a series introducing the support for the A10 (and SoCs of the same
> > generation) CMOS Sensor Interface (called CSI, not to be confused with
> > MIPI-CSI, which isn't support by that IP).
> >
> > That interface is pretty straightforward, but the driver has a few issues
> > that I wanted to bring up:
> >
> > * The only board I've been testing this with has an ov5640 sensor
> > attached, which doesn't work with the upstream driver. Copying the
> > Allwinner init sequence works though, and this is how it has been
> > tested. Testing with a second sensor would allow to see if it's an
> > issue on the CSI side or the sensor side.
> > * When starting a capture, the last buffer to capture will fail due to
> > double buffering being used, and we don't have a next buffer for the
> > last frame. I'm not sure how to deal with that though. It seems like
> > some drivers use a scratch buffer in such a case, some don't care, so
> > I'm not sure which solution should be preferred.
> > * We don't have support for the ISP at the moment, but this can be added
> > eventually.
> >
> > * How to model the CSI module clock isn't really clear to me. It looks
> > like it goes through the CSI controller and then is muxed to one of the
> > CSI pin so that it can clock the sensor. I'm not quite sure how to
> > model it, if it should be a clock, the CSI driver being a clock
> > provider, or if the sensor should just use the module clock directly.
>
> Which clock are you talking about? MCLK? This seems to be fed directly from
> the CCU, as there doesn't seem to be controls for it within the CSI hardware
> block, and the diagram doesn't list it either. IMO you don't have to model it.
> The camera sensor device node would just take a reference to it directly.
Yeah, that what I went for, I guess we agree :)
> You would probably enable the (separate) pinmux setting in the CSI
> controller node.
I'll change that.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2018-11-15 19:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 8:24 [PATCH 0/5] media: Allwinner A10 CSI support Maxime Ripard
2018-11-13 8:24 ` [PATCH 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Maxime Ripard
2018-11-13 8:38 ` Sakari Ailus
2018-11-15 19:04 ` Maxime Ripard
2018-11-21 21:56 ` Sakari Ailus
2018-11-27 15:04 ` Maxime Ripard
2018-11-13 10:34 ` Sakari Ailus
2018-11-13 8:24 ` [PATCH 2/5] media: sunxi: Refactor the Makefile and Kconfig Maxime Ripard
2018-11-13 8:24 ` [PATCH 3/5] media: sunxi: Add A10 CSI driver Maxime Ripard
2018-11-13 8:57 ` Sakari Ailus
2018-11-13 12:24 ` Hans Verkuil
2018-11-13 15:19 ` Joe Perches
2018-11-13 15:39 ` Hans Verkuil
2018-11-15 20:51 ` Maxime Ripard
2018-11-21 22:01 ` Sakari Ailus
2018-11-22 13:58 ` Maxime Ripard
2018-11-13 12:48 ` Fabio Estevam
2018-11-13 13:37 ` Hans Verkuil
2018-11-13 14:13 ` Fabio Estevam
2018-11-13 14:46 ` Thomas Petazzoni
2018-11-13 8:24 ` [PATCH 4/5] ARM: dts: sun7i: Add CSI0 controller Maxime Ripard
2018-11-13 8:24 ` [PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support Maxime Ripard
2018-11-27 6:56 ` Jagan Teki
2018-11-27 10:31 ` Maxime Ripard
2018-11-27 11:00 ` Jagan Teki
2018-11-27 15:19 ` Maxime Ripard
2018-11-27 15:34 ` Jagan Teki
2018-11-13 12:30 ` [PATCH 0/5] media: Allwinner A10 CSI support Hans Verkuil
2018-11-13 13:52 ` Maxime Ripard
2018-11-13 14:01 ` Hans Verkuil
2018-11-13 15:52 ` Maxime Ripard
2018-11-13 16:00 ` Hans Verkuil
2018-11-13 16:55 ` Thomas Petazzoni
2018-11-13 17:15 ` Hans Verkuil
2018-11-14 3:24 ` Chen-Yu Tsai
2018-11-15 19:10 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115191031.7jpb2g23fksof625@flea \
--to=maxime.ripard@bootlin.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).