From: Jagan Teki <jagan@amarulasolutions.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
laurent.pinchart@ideasonboard.com,
linux-media <linux-media@vger.kernel.org>,
a.hajda@samsung.com, Chen-Yu Tsai <wens@csie.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support
Date: Tue, 27 Nov 2018 21:04:25 +0530 [thread overview]
Message-ID: <CAMty3ZC4LtAAb-09em8Cm8HTUtiK3oHvL8mynn8bhJr3Sgdvsg@mail.gmail.com> (raw)
In-Reply-To: <20181127151948.gaqodlnkiuh3vkud@flea>
On Tue, Nov 27, 2018 at 8:49 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Tue, Nov 27, 2018 at 04:30:55PM +0530, Jagan Teki wrote:
> > > > > +&i2c1 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&i2c1_pins_a>;
> > > > > + status = "okay";
> > > > > +
> > > > > + camera: camera@21 {
> > > > > + compatible = "ovti,ov5640";
> > > > > + reg = <0x21>;
> > > > > + clocks = <&ccu CLK_CSI0>;
> > > > > + clock-names = "xclk";
> > > > > + assigned-clocks = <&ccu CLK_CSI0>;
> > > > > + assigned-clock-rates = <24000000>;
> > > > > +
> > > > > + reset-gpios = <&pio 7 14 GPIO_ACTIVE_LOW>;
> > > > > + powerdown-gpios = <&pio 7 19 GPIO_ACTIVE_HIGH>;
> > > > > + AVDD-supply = <®_cam_avdd>;
> > > > > + DOVDD-supply = <®_cam_dovdd>;
> > > > > + DVDD-supply = <®_cam_dvdd>;
> > > > > +
> > > > > + port {
> > > > > + ov5640_to_csi: endpoint {
> > > > > + remote-endpoint = <&csi_from_ov5640>;
> > > > > + bus-width = <8>;
> > > > > + data-shift = <2>;
> > > > > + hsync-active = <1>; /* Active high */
> > > > > + vsync-active = <0>; /* Active low */
> > > > > + data-active = <1>; /* Active high */
> > > > > + pclk-sample = <1>; /* Rising */
> > > > > + };
> > > > > + };
> > > > > + };
> > > >
> > > > Does ov5640 need any further patches, wrt linux-next? I'm trying to
> > > > test this on top of linux-next but the slave id seems not detecting.
> > > >
> > > > [ 2.304711] ov5640 1-0021: Linked as a consumer to regulator.5
> > > > [ 2.310639] ov5640 1-0021: Linked as a consumer to regulator.6
> > > > [ 2.316592] ov5640 1-0021: Linked as a consumer to regulator.4
> > > > [ 2.351540] ov5640 1-0021: ov5640_init_slave_id: failed with -6
> > > > [ 2.357543] ov5640 1-0021: Dropping the link to regulator.5
> > > > [ 2.363224] ov5640 1-0021: Dropping the link to regulator.6
> > > > [ 2.368829] ov5640 1-0021: Dropping the link to regulator.4
> > > >
> > > > Here is the full log [1], please let me know if I miss anything, I
> > > > even tried to remove MCLK pin
> > >
> > > You seem to have made local modifications to your tree, what are they?
> > > This indicates that the communication over i2c doesn't work, what is
> > > your setup?
> >
> > I just used your commits on linux-next [2], with the setup similar in
> > Page 5 on datasheet[3]. The only difference is csi build issue, I have
> > updated similar fix you mentioned on sun6i_csi [4]
> >
> > [2] https://github.com/amarula/linux-amarula/commits/CSI-A20
> > [3] https://www.tme.eu/gb/Document/187887186b98a8f78b47da2774a34f4c/BPI-CAMERA.pdf
> > [4] https://github.com/amarula/linux-amarula/commit/a6762ecd38f000e2bd02dd255f6fd0c1ae755429#diff-0809a7f97ca58771c1cda186e73ec657
>
> That branch doesn't have any commit with the same ID that you have in
> your boot log.
I have created this branch for your reference, here is the clean log on this [5]
[5] https://paste.ubuntu.com/p/4bkFs5WG6c/
next prev parent reply other threads:[~2018-11-27 15:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 8:24 [PATCH 0/5] media: Allwinner A10 CSI support Maxime Ripard
2018-11-13 8:24 ` [PATCH 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Maxime Ripard
2018-11-13 8:38 ` Sakari Ailus
2018-11-15 19:04 ` Maxime Ripard
2018-11-21 21:56 ` Sakari Ailus
2018-11-27 15:04 ` Maxime Ripard
2018-11-13 10:34 ` Sakari Ailus
2018-11-13 8:24 ` [PATCH 2/5] media: sunxi: Refactor the Makefile and Kconfig Maxime Ripard
2018-11-13 8:24 ` [PATCH 3/5] media: sunxi: Add A10 CSI driver Maxime Ripard
2018-11-13 8:57 ` Sakari Ailus
2018-11-13 12:24 ` Hans Verkuil
2018-11-13 15:19 ` Joe Perches
2018-11-13 15:39 ` Hans Verkuil
2018-11-15 20:51 ` Maxime Ripard
2018-11-21 22:01 ` Sakari Ailus
2018-11-22 13:58 ` Maxime Ripard
2018-11-13 12:48 ` Fabio Estevam
2018-11-13 13:37 ` Hans Verkuil
2018-11-13 14:13 ` Fabio Estevam
2018-11-13 14:46 ` Thomas Petazzoni
2018-11-13 8:24 ` [PATCH 4/5] ARM: dts: sun7i: Add CSI0 controller Maxime Ripard
2018-11-13 8:24 ` [PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support Maxime Ripard
2018-11-27 6:56 ` Jagan Teki
2018-11-27 10:31 ` Maxime Ripard
2018-11-27 11:00 ` Jagan Teki
2018-11-27 15:19 ` Maxime Ripard
2018-11-27 15:34 ` Jagan Teki [this message]
2018-11-13 12:30 ` [PATCH 0/5] media: Allwinner A10 CSI support Hans Verkuil
2018-11-13 13:52 ` Maxime Ripard
2018-11-13 14:01 ` Hans Verkuil
2018-11-13 15:52 ` Maxime Ripard
2018-11-13 16:00 ` Hans Verkuil
2018-11-13 16:55 ` Thomas Petazzoni
2018-11-13 17:15 ` Hans Verkuil
2018-11-14 3:24 ` Chen-Yu Tsai
2018-11-15 19:10 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMty3ZC4LtAAb-09em8Cm8HTUtiK3oHvL8mynn8bhJr3Sgdvsg@mail.gmail.com \
--to=jagan@amarulasolutions.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).