* [PATCH net-next] net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait
@ 2018-11-16 10:25 YueHaibing
2018-11-18 5:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-16 10:25 UTC (permalink / raw)
To: davem, igor.russkikh, nikita.danilov, yana.esina
Cc: linux-kernel, netdev, YueHaibing
'err' always be 0 in the two places.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
index 7def1cb..1af6606 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
@@ -454,8 +454,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
(fw.val =
aq_hw_read_reg(self, HW_ATL_RPC_STATE_ADR),
fw.tid), 1000U, 100U);
- if (err < 0)
- goto err_exit;
if (fw.len == 0xFFFFU) {
err = hw_atl_utils_fw_rpc_call(self, sw.len);
@@ -463,8 +461,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
goto err_exit;
}
} while (sw.tid != fw.tid || 0xFFFFU == fw.len);
- if (err < 0)
- goto err_exit;
if (rpc) {
if (fw.len) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait
2018-11-16 10:25 [PATCH net-next] net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait YueHaibing
@ 2018-11-18 5:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-11-18 5:15 UTC (permalink / raw)
To: yuehaibing
Cc: igor.russkikh, nikita.danilov, yana.esina, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Fri, 16 Nov 2018 18:25:27 +0800
> 'err' always be 0 in the two places.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-18 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 10:25 [PATCH net-next] net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait YueHaibing
2018-11-18 5:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).