* [PATCH] powerpc: Rework btext_find_display to use of_stdout and device_type helpers
@ 2018-11-16 22:10 Rob Herring
2018-12-07 13:07 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2018-11-16 22:10 UTC (permalink / raw)
To: Michael Ellerman
Cc: devicetree, linux-kernel, Benjamin Herrenschmidt, Paul Mackerras,
linuxppc-dev
Remove directly accessing device_node.type pointer and use the accessors
instead. This will eventually allow removing the type pointer.
In the process, the of_stdout pointer can be used instead of finding the
stdout node again.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/powerpc/kernel/btext.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c
index b4241ed1456e..488b0875ed66 100644
--- a/arch/powerpc/kernel/btext.c
+++ b/arch/powerpc/kernel/btext.c
@@ -232,20 +232,12 @@ static int btext_initialize(struct device_node *np)
int __init btext_find_display(int allow_nonstdout)
{
- const char *name;
- struct device_node *np = NULL;
+ struct device_node *np = of_stdout;
int rc = -ENODEV;
- name = of_get_property(of_chosen, "linux,stdout-path", NULL);
- if (name != NULL) {
- np = of_find_node_by_path(name);
- if (np != NULL) {
- if (strcmp(np->type, "display") != 0) {
- printk("boot stdout isn't a display !\n");
- of_node_put(np);
- np = NULL;
- }
- }
+ if (!of_node_is_type(np, "display")) {
+ printk("boot stdout isn't a display !\n");
+ np = NULL;
}
if (np)
rc = btext_initialize(np);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc: Rework btext_find_display to use of_stdout and device_type helpers
2018-11-16 22:10 [PATCH] powerpc: Rework btext_find_display to use of_stdout and device_type helpers Rob Herring
@ 2018-12-07 13:07 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-12-07 13:07 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, linuxppc-dev, Paul Mackerras, linux-kernel
On Fri, 2018-11-16 at 22:10:59 UTC, Rob Herring wrote:
> Remove directly accessing device_node.type pointer and use the accessors
> instead. This will eventually allow removing the type pointer.
>
> In the process, the of_stdout pointer can be used instead of finding the
> stdout node again.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5b8d6be7b8dd286bd654e37d637ded
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-07 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 22:10 [PATCH] powerpc: Rework btext_find_display to use of_stdout and device_type helpers Rob Herring
2018-12-07 13:07 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).