* [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor
@ 2018-11-07 5:16 Z.q. Hou
2018-11-20 10:53 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Z.q. Hou @ 2018-11-07 5:16 UTC (permalink / raw)
To: linux-pci, linux-kernel, bhelgaas, lorenzo.pieralisi
Cc: Roy Zang, M.h. Lian, Z.q. Hou, stable
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
The order of parameters is not correct when invoking the outbound
window disable routine.
Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound
windows configured by bootloader").
Cc: stable@vger.kernel.org
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V2:
- Tagged this patch for stable.
- Reworded the commit description.
drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 3724d3ef7008..7aa9a82b7ebd 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
int i;
for (i = 0; i < PCIE_IATU_NUM; i++)
- dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
+ dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
}
static int ls1021_pcie_link_up(struct dw_pcie *pci)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor
2018-11-07 5:16 [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor Z.q. Hou
@ 2018-11-20 10:53 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2018-11-20 10:53 UTC (permalink / raw)
To: Z.q. Hou; +Cc: linux-pci, linux-kernel, bhelgaas, Roy Zang, M.h. Lian, stable
On Wed, Nov 07, 2018 at 05:16:49AM +0000, Z.q. Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The order of parameters is not correct when invoking the outbound
> window disable routine.
>
> Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound
> windows configured by bootloader").
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> V2:
> - Tagged this patch for stable.
> - Reworded the commit description.
>
> drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/controller-fixes for one of the upcoming -rc*.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 3724d3ef7008..7aa9a82b7ebd 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
> int i;
>
> for (i = 0; i < PCIE_IATU_NUM; i++)
> - dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
> + dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
> }
>
> static int ls1021_pcie_link_up(struct dw_pcie *pci)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-20 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 5:16 [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor Z.q. Hou
2018-11-20 10:53 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).