* [PATCH -next] drm/cirrus: Remove set but not used variable 'bo'
@ 2018-11-15 12:10 YueHaibing
2018-11-21 8:14 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-15 12:10 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, David Airlie, Thierry Reding,
Daniel Stone, Thomas Zimmermann, Adam Jackson
Cc: YueHaibing, virtualization, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/cirrus/cirrus_fbdev.c: In function 'cirrusfb_create':
drivers/gpu/drm/cirrus/cirrus_fbdev.c:172:20: warning:
variable 'bo' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
f9aa76a85248 ("drm/kms: driver for virtual cirrus under qemu")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
index 68ab182..4dd499c 100644
--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -169,7 +169,6 @@ static int cirrusfb_create(struct drm_fb_helper *helper,
struct drm_mode_fb_cmd2 mode_cmd;
void *sysram;
struct drm_gem_object *gobj = NULL;
- struct cirrus_bo *bo = NULL;
int size, ret;
mode_cmd.width = sizes->surface_width;
@@ -185,8 +184,6 @@ static int cirrusfb_create(struct drm_fb_helper *helper,
return ret;
}
- bo = gem_to_cirrus_bo(gobj);
-
sysram = vmalloc(size);
if (!sysram)
return -ENOMEM;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/cirrus: Remove set but not used variable 'bo'
2018-11-15 12:10 [PATCH -next] drm/cirrus: Remove set but not used variable 'bo' YueHaibing
@ 2018-11-21 8:14 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2018-11-21 8:14 UTC (permalink / raw)
To: YueHaibing
Cc: Dave Airlie, David Airlie, Thierry Reding, Daniel Stone,
Thomas Zimmermann, Adam Jackson, virtualization, dri-devel,
linux-kernel, kernel-janitors
On Thu, Nov 15, 2018 at 12:10:36PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/cirrus/cirrus_fbdev.c: In function 'cirrusfb_create':
> drivers/gpu/drm/cirrus/cirrus_fbdev.c:172:20: warning:
> variable 'bo' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> f9aa76a85248 ("drm/kms: driver for virtual cirrus under qemu")
queued for -next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-21 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 12:10 [PATCH -next] drm/cirrus: Remove set but not used variable 'bo' YueHaibing
2018-11-21 8:14 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).