From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, namhyung@kernel.org,
ak@linux.intel.com
Subject: Re: [PATCH 1/2] perf vendor events: Add stepping in CPUID string for x86
Date: Wed, 21 Nov 2018 09:22:43 -0300 [thread overview]
Message-ID: <20181121122243.GC6248@kernel.org> (raw)
In-Reply-To: <cc982c1b-0774-6f3e-a24a-3c3fba5c900b@linux.intel.com>
Em Thu, Nov 15, 2018 at 04:01:46PM -0500, Liang, Kan escreveu:
>
>
> On 11/15/2018 3:44 PM, Jiri Olsa wrote:
> > On Wed, Nov 14, 2018 at 01:24:15PM -0800, kan.liang@linux.intel.com wrote:
> > > From: Kan Liang <kan.liang@linux.intel.com>
> > >
> > > Perf tools cannot find the proper event list for Cascadelake server.
> > > Because Cascadelake server and Skylake server have the same CPU model
> > > number, which are used by perf tools to find the event list.
> > >
> > > The stepping for Skylake server is up to 4.
> > > The stepping for Cascadelake server starts from 5.
> > > The stepping can be used to distinguish between them.
> > >
> > > The stepping is added in get_cpuid_str().
> > > The stepping information for Skylake server is updated in mapfile.csv.
> > > A x86 specific strcmp_cpuid_cmp() function is added to handle two CPUID
> > > formats in mapfile.csv, "vendor-family-model-stepping" and
> > > "vendor-family-model".
> > > - If a cpuid-regular-expression from the mapfile.csv using the new
> > > stepping format, a cpuid-string generated on the machine must include
> > > stepping. Otherwise, it is a mismatch.
> > > - If the cpuid-regular-expression using the old non-stepping format,
> > > the stepping in the cpuid-string will be ignored.
> > >
> > > The script, which using environment string "PERF_CPUID" without stepping
> > > on Skylake server, will be broken. If so, users must fix their scripts.
> > >
> > > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> >
> > Reviewed-by: Jiri Olsa <jolsa@kernel.org>
> Thanks Jirka,
> Hi Arnaldo,
> Are you OK with the patch?
> If yes, I will go ahead to cleanup the *_cpuid_str() by moving them to
> header.c as promised. https://lkml.org/lkml/2018/11/15/929
> The new patch will be on top of this patch.
Looks ok after reading the discussion between you and Jiri, will now
look at the patch that Jiri reviewed.
- Arnaldo
next prev parent reply other threads:[~2018-11-21 12:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 21:24 [PATCH 1/2] perf vendor events: Add stepping in CPUID string for x86 kan.liang
[not found] ` <20181114212416.15665-2-kan.liang@linux.intel.com>
2018-11-15 13:21 ` [PATCH 2/2] perf vendor events: Add JSON metrics for Cascadelake server Jiri Olsa
[not found] ` <3ab97c73-c197-8555-1a35-b54636e667e6@linux.intel.com>
2018-11-15 15:14 ` Jiri Olsa
2018-11-21 12:51 ` Arnaldo Carvalho de Melo
2018-11-21 12:54 ` Arnaldo Carvalho de Melo
2018-11-21 13:02 ` Jiri Olsa
2018-11-21 13:10 ` Arnaldo Carvalho de Melo
2018-11-15 13:53 ` [PATCH 1/2] perf vendor events: Add stepping in CPUID string for x86 Jiri Olsa
2018-11-15 14:26 ` Liang, Kan
2018-11-15 15:18 ` Liang, Kan
2018-11-15 15:33 ` Jiri Olsa
2018-11-15 15:25 ` Jiri Olsa
2018-11-15 15:53 ` Liang, Kan
2018-11-15 20:02 ` Jiri Olsa
2018-11-15 20:44 ` Jiri Olsa
2018-11-15 21:01 ` Liang, Kan
2018-11-16 2:14 ` Arnaldo Carvalho de Melo
2018-11-20 13:55 ` Liang, Kan
2018-11-21 12:22 ` Arnaldo Carvalho de Melo [this message]
2018-11-22 7:14 ` [tip:perf/core] " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121122243.GC6248@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).