* [PATCH] soc/tegra: pmc: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-11-22 13:12 Yangtao Li
2018-11-22 15:13 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-11-22 13:12 UTC (permalink / raw)
To: thierry.reding, jonathanh, avienamo, mperttunen, andy.gross,
robh, vivek.gautam
Cc: linux-tegra, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/soc/tegra/pmc.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 1fa840e3d930..d42a1f5ced82 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -717,17 +717,7 @@ static int powergate_show(struct seq_file *s, void *data)
return 0;
}
-static int powergate_open(struct inode *inode, struct file *file)
-{
- return single_open(file, powergate_show, inode->i_private);
-}
-
-static const struct file_operations powergate_fops = {
- .open = powergate_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(powergate);
static int tegra_powergate_debugfs_init(void)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc/tegra: pmc: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-22 13:12 [PATCH] soc/tegra: pmc: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-11-22 15:13 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2018-11-22 15:13 UTC (permalink / raw)
To: Yangtao Li
Cc: jonathanh, avienamo, mperttunen, andy.gross, robh, vivek.gautam,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
On Thu, Nov 22, 2018 at 08:12:07AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/soc/tegra/pmc.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-22 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22 13:12 [PATCH] soc/tegra: pmc: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-11-22 15:13 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).