* [PATCH net-next] net: bcmgenet: remove HFB_CTRL access
@ 2018-11-20 23:17 Doug Berger
2018-11-23 19:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Doug Berger @ 2018-11-20 23:17 UTC (permalink / raw)
To: David S. Miller; +Cc: Florian Fainelli, netdev, linux-kernel, Doug Berger
Commit c5a54bbcecec ("net: bcmgenet: abort suspend on error")
mistakenly introduced register accesses that should not occur
in bcmgenet_wol_power_up_cfg().
Fixes: c5a54bbcecec ("net: bcmgenet: abort suspend on error")
Signed-off-by: Doug Berger <opendmb@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
index b3596e0ee47b..57582efa362d 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
@@ -191,10 +191,6 @@ void bcmgenet_wol_power_up_cfg(struct bcmgenet_priv *priv,
reg &= ~MPD_EN;
bcmgenet_umac_writel(priv, reg, UMAC_MPD_CTRL);
- reg = bcmgenet_hfb_reg_readl(priv, HFB_CTRL);
- reg &= ~(RBUF_HFB_EN | RBUF_ACPI_EN);
- bcmgenet_hfb_reg_writel(priv, reg, HFB_CTRL);
-
/* Disable CRC Forward */
reg = bcmgenet_umac_readl(priv, UMAC_CMD);
reg &= ~CMD_CRC_FWD;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: remove HFB_CTRL access
2018-11-20 23:17 [PATCH net-next] net: bcmgenet: remove HFB_CTRL access Doug Berger
@ 2018-11-23 19:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-11-23 19:10 UTC (permalink / raw)
To: opendmb; +Cc: f.fainelli, netdev, linux-kernel
From: Doug Berger <opendmb@gmail.com>
Date: Tue, 20 Nov 2018 15:17:01 -0800
> Commit c5a54bbcecec ("net: bcmgenet: abort suspend on error")
> mistakenly introduced register accesses that should not occur
> in bcmgenet_wol_power_up_cfg().
>
> Fixes: c5a54bbcecec ("net: bcmgenet: abort suspend on error")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-23 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 23:17 [PATCH net-next] net: bcmgenet: remove HFB_CTRL access Doug Berger
2018-11-23 19:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).