[PATCH v2] ARM: dts: r9a06g032: Correct the GIC DT node name

[PATCH v2] ARM: dts: r9a06g032: Correct the GIC DT node name

[Phil Edworthy]

Harmless mistake, but it's incorrect. The DT spec provides recommendations
for the node names:
"The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model. If appropriate, the
name should be one of the following choices:
...
interrupt-controller"

Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
v2:
 - Add commit log details about why
---
 arch/arm/boot/dts/r9a06g032.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
index 2322268bc862..4c1ab49c7d39 100644
--- a/arch/arm/boot/dts/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/r9a06g032.dtsi
@@ -173,7 +173,7 @@
 			status = "okay";
 		};
 
-		gic: gic@44101000 {
+		gic: interrupt-controller@44101000 {
 			compatible = "arm,cortex-a7-gic", "arm,gic-400";
 			interrupt-controller;
 			#interrupt-cells = <3>;
-- 
2.17.1

Re: [PATCH v2] ARM: dts: r9a06g032: Correct the GIC DT node name

[Geert Uytterhoeven]

On Wed, Nov 21, 2018 at 11:10 AM Phil Edworthy
<phil.edworthy@renesas.com> wrote:
> Harmless mistake, but it's incorrect. The DT spec provides recommendations
> for the node names:
> "The name of a node should be somewhat generic, reflecting the function
> of the device and not its precise programming model. If appropriate, the
> name should be one of the following choices:
> ...
> interrupt-controller"
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] ARM: dts: r9a06g032: Correct the GIC DT node name

[Simon Horman]

On Fri, Nov 23, 2018 at 10:24:06AM +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 21, 2018 at 11:10 AM Phil Edworthy
> <phil.edworthy@renesas.com> wrote:
> > Harmless mistake, but it's incorrect. The DT spec provides recommendations
> > for the node names:
> > "The name of a node should be somewhat generic, reflecting the function
> > of the device and not its precise programming model. If appropriate, the
> > name should be one of the following choices:
> > ...
> > interrupt-controller"
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v4.21.