linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: VMX: re-add ple_gap module parameter
@ 2018-11-23 17:02 Luiz Capitulino
  2018-11-23 17:42 ` Liran Alon
  0 siblings, 1 reply; 7+ messages in thread
From: Luiz Capitulino @ 2018-11-23 17:02 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: babu.moger, kvm, linux-kernel


Apparently, the ple_gap parameter was accidentally removed
by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
back.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 arch/x86/kvm/vmx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 4555077d69ce..be6f13f1c25f 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
  * refer SDM volume 3b section 21.6.13 & 22.1.3.
  */
 static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
+module_param(ple_gap, uint, 0444);
 
 static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
 module_param(ple_window, uint, 0444);
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-23 17:02 [PATCH] KVM: VMX: re-add ple_gap module parameter Luiz Capitulino
@ 2018-11-23 17:42 ` Liran Alon
  2018-11-23 18:26   ` Luiz Capitulino
  0 siblings, 1 reply; 7+ messages in thread
From: Liran Alon @ 2018-11-23 17:42 UTC (permalink / raw)
  To: Luiz Capitulino; +Cc: Paolo Bonzini, babu.moger, kvm, linux-kernel



> On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> 
> 
> Apparently, the ple_gap parameter was accidentally removed
> by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
> back.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Weird that nobody noticed this when patch was applied… Thanks.
Reviewed-by: Liran Alon <liran.alon@oracle.com>

> ---
> arch/x86/kvm/vmx.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4555077d69ce..be6f13f1c25f 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
>  * refer SDM volume 3b section 21.6.13 & 22.1.3.
>  */
> static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
> +module_param(ple_gap, uint, 0444);
> 
> static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
> module_param(ple_window, uint, 0444);
> -- 
> 2.17.2
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-23 17:42 ` Liran Alon
@ 2018-11-23 18:26   ` Luiz Capitulino
  2018-11-28 15:57     ` Moger, Babu
  0 siblings, 1 reply; 7+ messages in thread
From: Luiz Capitulino @ 2018-11-23 18:26 UTC (permalink / raw)
  To: Liran Alon; +Cc: Paolo Bonzini, babu.moger, kvm, linux-kernel

On Fri, 23 Nov 2018 19:42:53 +0200
Liran Alon <liran.alon@oracle.com> wrote:

> > On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > 
> > 
> > Apparently, the ple_gap parameter was accidentally removed
> > by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
> > back.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>  
> 
> Weird that nobody noticed this when patch was applied… Thanks.
> Reviewed-by: Liran Alon <liran.alon@oracle.com>

I forgot to mention that I noticed this because I have systems
disabling ple with ple_gap=0 in modprobe.conf. In those systems
kvm_intel won't load anymore.

> 
> > ---
> > arch/x86/kvm/vmx.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > index 4555077d69ce..be6f13f1c25f 100644
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -174,6 +174,7 @@ module_param_named(preemption_timer, enable_preemption_timer, bool, S_IRUGO);
> >  * refer SDM volume 3b section 21.6.13 & 22.1.3.
> >  */
> > static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
> > +module_param(ple_gap, uint, 0444);
> > 
> > static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
> > module_param(ple_window, uint, 0444);
> > -- 
> > 2.17.2
> >   
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* RE: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-23 18:26   ` Luiz Capitulino
@ 2018-11-28 15:57     ` Moger, Babu
  2018-11-28 16:03       ` Luiz Capitulino
  2018-11-28 16:11       ` Sasha Levin
  0 siblings, 2 replies; 7+ messages in thread
From: Moger, Babu @ 2018-11-28 15:57 UTC (permalink / raw)
  To: Luiz Capitulino, Liran Alon; +Cc: Paolo Bonzini, kvm, linux-kernel, stable

My bad.. Sorry about this. I think this should also go to
stable@vger.kernel.org

> -----Original Message-----
> From: Luiz Capitulino <lcapitulino@redhat.com>
> Sent: Friday, November 23, 2018 12:27 PM
> To: Liran Alon <liran.alon@oracle.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>; Moger, Babu
> <Babu.Moger@amd.com>; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
> 
> On Fri, 23 Nov 2018 19:42:53 +0200
> Liran Alon <liran.alon@oracle.com> wrote:
> 
> > > On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@redhat.com>
> wrote:
> > >
> > >
> > > Apparently, the ple_gap parameter was accidentally removed
> > > by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
> > > back.
> > >
> > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >
> > Weird that nobody noticed this when patch was applied… Thanks.
> > Reviewed-by: Liran Alon <liran.alon@oracle.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>

> 
> I forgot to mention that I noticed this because I have systems
> disabling ple with ple_gap=0 in modprobe.conf. In those systems
> kvm_intel won't load anymore.
> 
> >
> > > ---
> > > arch/x86/kvm/vmx.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > > index 4555077d69ce..be6f13f1c25f 100644
> > > --- a/arch/x86/kvm/vmx.c
> > > +++ b/arch/x86/kvm/vmx.c
> > > @@ -174,6 +174,7 @@ module_param_named(preemption_timer,
> enable_preemption_timer, bool, S_IRUGO);
> > >  * refer SDM volume 3b section 21.6.13 & 22.1.3.
> > >  */
> > > static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
> > > +module_param(ple_gap, uint, 0444);
> > >
> > > static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
> > > module_param(ple_window, uint, 0444);
> > > --
> > > 2.17.2
> > >
> >


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-28 15:57     ` Moger, Babu
@ 2018-11-28 16:03       ` Luiz Capitulino
  2018-11-28 16:11       ` Sasha Levin
  1 sibling, 0 replies; 7+ messages in thread
From: Luiz Capitulino @ 2018-11-28 16:03 UTC (permalink / raw)
  To: Moger, Babu; +Cc: Liran Alon, Paolo Bonzini, kvm, linux-kernel, stable

On Wed, 28 Nov 2018 15:57:53 +0000
"Moger, Babu" <Babu.Moger@amd.com> wrote:

> My bad.. Sorry about this. I think this should also go to
> stable@vger.kernel.org

No problem man, this happens. Thanks for the review!

> 
> > -----Original Message-----
> > From: Luiz Capitulino <lcapitulino@redhat.com>
> > Sent: Friday, November 23, 2018 12:27 PM
> > To: Liran Alon <liran.alon@oracle.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>; Moger, Babu
> > <Babu.Moger@amd.com>; kvm@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
> > 
> > On Fri, 23 Nov 2018 19:42:53 +0200
> > Liran Alon <liran.alon@oracle.com> wrote:
> >   
> > > > On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@redhat.com>  
> > wrote:  
> > > >
> > > >
> > > > Apparently, the ple_gap parameter was accidentally removed
> > > > by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
> > > > back.
> > > >
> > > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>  
> > >
> > > Weird that nobody noticed this when patch was applied… Thanks.
> > > Reviewed-by: Liran Alon <liran.alon@oracle.com>  
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> 
> > 
> > I forgot to mention that I noticed this because I have systems
> > disabling ple with ple_gap=0 in modprobe.conf. In those systems
> > kvm_intel won't load anymore.
> >   
> > >  
> > > > ---
> > > > arch/x86/kvm/vmx.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > > > index 4555077d69ce..be6f13f1c25f 100644
> > > > --- a/arch/x86/kvm/vmx.c
> > > > +++ b/arch/x86/kvm/vmx.c
> > > > @@ -174,6 +174,7 @@ module_param_named(preemption_timer,  
> > enable_preemption_timer, bool, S_IRUGO);  
> > > >  * refer SDM volume 3b section 21.6.13 & 22.1.3.
> > > >  */
> > > > static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
> > > > +module_param(ple_gap, uint, 0444);
> > > >
> > > > static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
> > > > module_param(ple_window, uint, 0444);
> > > > --
> > > > 2.17.2
> > > >  
> > >  
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-28 15:57     ` Moger, Babu
  2018-11-28 16:03       ` Luiz Capitulino
@ 2018-11-28 16:11       ` Sasha Levin
  2018-11-28 16:40         ` Paolo Bonzini
  1 sibling, 1 reply; 7+ messages in thread
From: Sasha Levin @ 2018-11-28 16:11 UTC (permalink / raw)
  To: Moger, Babu
  Cc: Luiz Capitulino, Liran Alon, Paolo Bonzini, kvm, linux-kernel, stable

On Wed, Nov 28, 2018 at 03:57:53PM +0000, Moger, Babu wrote:
>My bad.. Sorry about this. I think this should also go to
>stable@vger.kernel.org

Please actually add the stable tag in the commit message if you intend
for this patch to go in stable.

--
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
  2018-11-28 16:11       ` Sasha Levin
@ 2018-11-28 16:40         ` Paolo Bonzini
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2018-11-28 16:40 UTC (permalink / raw)
  To: Sasha Levin, Moger, Babu
  Cc: Luiz Capitulino, Liran Alon, kvm, linux-kernel, stable

On 28/11/18 17:11, Sasha Levin wrote:
> On Wed, Nov 28, 2018 at 03:57:53PM +0000, Moger, Babu wrote:
>> My bad.. Sorry about this. I think this should also go to
>> stable@vger.kernel.org
> 
> Please actually add the stable tag in the commit message if you intend
> for this patch to go in stable.

No worries, the patch is already on its way to Linus with the stable tag.

Paolo


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-28 16:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23 17:02 [PATCH] KVM: VMX: re-add ple_gap module parameter Luiz Capitulino
2018-11-23 17:42 ` Liran Alon
2018-11-23 18:26   ` Luiz Capitulino
2018-11-28 15:57     ` Moger, Babu
2018-11-28 16:03       ` Luiz Capitulino
2018-11-28 16:11       ` Sasha Levin
2018-11-28 16:40         ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).