From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
Boqun Feng <boqun.feng@gmail.com>, Borislav Petkov <bp@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] locking/atomics: build atomic headers as required
Date: Fri, 23 Nov 2018 15:09:43 -0800 [thread overview]
Message-ID: <20181123150943.ddf22393b568131a3383fd02@linux-foundation.org> (raw)
In-Reply-To: <20181123153321.8561-1-mark.rutland@arm.com>
On Fri, 23 Nov 2018 15:33:21 +0000 Mark Rutland <mark.rutland@arm.com> wrote:
> Andrew and Ingo report that the check-atomics.sh script is simply too
> slow to run for every kernel build, and it's impractical to make it
> faster without rewriting it in something other than shell.
>
> Rather than committing the generated headers, let's regenerate these
> as-required for a pristine tree.
>
> That ensures they're always up-to-date, allows them to be built in
> parallel, and avoid redundant rebuilds, which is a 2-8s saving per
> incremental build. Since the results are not committed, it's very
> obvious that they should not be modified directly. If we need to
> generate more headers in future, it's easy to extend Makefile.genheader
> to permit this.
>
> I've verified that this works in the cases we previously had issues with
> (out-of-tree builds and where scripts have no execute permissions), and
> have tested these cases for both x86_64 and arm64.
Seems like a reasonable compromise. I'll take a copy for testing now,
shall drop that when this appears in tip->linux-next.
next prev parent reply other threads:[~2018-11-23 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 15:33 [PATCH] locking/atomics: build atomic headers as required Mark Rutland
2018-11-23 15:48 ` Mark Rutland
2018-11-23 23:09 ` Andrew Morton [this message]
2018-11-26 8:46 ` Peter Zijlstra
2018-11-26 9:04 ` Mark Rutland
2018-11-26 9:33 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123150943.ddf22393b568131a3383fd02@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).