From: Mark Rutland <mark.rutland@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@kernel.org, Boqun Feng <boqun.feng@gmail.com>,
Borislav Petkov <bp@suse.de>, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] locking/atomics: build atomic headers as required
Date: Mon, 26 Nov 2018 09:04:48 +0000 [thread overview]
Message-ID: <20181126090448.5onnooknto67tzoa@salmiak> (raw)
In-Reply-To: <20181126084621.GL2113@hirez.programming.kicks-ass.net>
On Mon, Nov 26, 2018 at 09:46:21AM +0100, Peter Zijlstra wrote:
> On Fri, Nov 23, 2018 at 03:33:21PM +0000, Mark Rutland wrote:
> > Andrew and Ingo report that the check-atomics.sh script is simply too
> > slow to run for every kernel build, and it's impractical to make it
> > faster without rewriting it in something other than shell.
> >
> > Rather than committing the generated headers, let's regenerate these
> > as-required for a pristine tree.
>
> Thing is, I '_never_' have a pristine tree. Now, I would also be in a
> position to know if something with the atomics changed, but that can't help
> other people that never use pristine trees.
Just to be clear, regardless of whether the tree is pristine, the headers will
be rebuilt iff their dependencies have changed. It's just that they
*definitely* have to be built for a pristine tree.
So perhaps I just need to clarify the commit message? Or do you envisage a
problem with that?
I've realised I missed the fallbacks and library script from the dependency
list, so I can also fix that for v2.
> Could we perhaps get an explicit 'genatomics' target or something to
> check/force-update this stuff?
If that's preferable, I can have a go.
Thanks,
Mark.
next prev parent reply other threads:[~2018-11-26 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 15:33 [PATCH] locking/atomics: build atomic headers as required Mark Rutland
2018-11-23 15:48 ` Mark Rutland
2018-11-23 23:09 ` Andrew Morton
2018-11-26 8:46 ` Peter Zijlstra
2018-11-26 9:04 ` Mark Rutland [this message]
2018-11-26 9:33 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126090448.5onnooknto67tzoa@salmiak \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).