From: Brian Masney <masneyb@onstation.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Question about "regulator: core: Only count load for enabled consumers" in -next
Date: Sun, 25 Nov 2018 18:24:50 -0500 [thread overview]
Message-ID: <20181125232450.GA3774@basecamp> (raw)
In-Reply-To: <CAD=FV=VuPerEgPPiUKk7-Ck9aVz=oR1CAAzg+0wag1WTrTGKxg@mail.gmail.com>
Hi Doug,
On Sun, Nov 25, 2018 at 09:20:02AM -0800, Doug Anderson wrote:
> On Sun, Nov 25, 2018 at 1:37 AM Brian Masney <masneyb@onstation.org> wrote:
> > I bisected the issue to the following commit:
> >
> > 5451781dadf8 ("regulator: core: Only count load for enabled consumers")
> >
> > We have to increase the load for the sdhci in device tree in order for
> > the phone to boot properly. This change was made with the commit:
> >
> > 03864e57770a ("ARM: dts: qcom: msm8974-hammerhead: increase load on l20
> > for sdhci")
>
> You have a 200 mA system load on this regulator?
Yes.
> I guess this is a workaround for drivers that don't set the load
> properly themselves?
I'm honestly not sure when the load should be set in the driver or in
device tree. None of the drivers in drivers/mmc/ call
regulator_set_load. The dt bindings describes the regulator-system-load
property in Documentation/devicetree/bindings/regulator/regulator.txt.
I see that there are 8 users of regulator-system-load but most are all
addressing this same issue with the SD card.
qcom-msm8974-sony-xperia-castor.dts sets the load to 500 mA but all of
the other msm8974-based SOCs use 200 mA. I'm not sure if this is
correct.
> I wonder if there is a bug in my patch where the system load doesn't
> take effect if nobody ever calls set_load. Let's see... Does the
> below fix things for you? It's totally untested and whitespace
> damaged but I wanted to get a response out quick and I'm just walking
> out the door. I'll test more / dig more either tonight or at work
> tomorrow:
>
> +++ b/drivers/regulator/core.c
> @@ -1344,6 +1344,12 @@ static int set_machine_constraints(struct
> regulator_dev *rdev,
> rdev_err(rdev, "failed to set initial mode: %d\n", ret);
> return ret;
> }
> + } else if (rdev->constraints->system_load) {
> + /*
> + * We'll only apply the initial system load if an
> + * initial mode wasn't specified.
> + */
> + drms_uA_update(rdev);
> }
Yes, this patch corrects the issue for me. You can add my tags if you
end up applying it:
Reported-by: Brian Masney <masneyb@onstation.org>
Tested-by: Brian Masney <masneyb@onstation.org>
Feel free to send me any other patches if you'd like me to do
additional testing.
Thanks for the quick response!
Brian
next prev parent reply other threads:[~2018-11-25 23:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 9:37 Question about "regulator: core: Only count load for enabled consumers" in -next Brian Masney
2018-11-25 17:20 ` Doug Anderson
2018-11-25 23:24 ` Brian Masney [this message]
2018-11-26 12:50 ` Mark Brown
2018-11-26 17:43 ` Doug Anderson
2018-11-26 17:59 ` Mark Brown
2018-11-26 18:11 ` Doug Anderson
2018-11-26 18:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181125232450.GA3774@basecamp \
--to=masneyb@onstation.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).