From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: masneyb@onstation.org, Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Question about "regulator: core: Only count load for enabled consumers" in -next
Date: Mon, 26 Nov 2018 17:59:45 +0000 [thread overview]
Message-ID: <20181126175945.GL9715@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=V4WFYoKLQ72pico4HCGgLDTae7xougivv6VWOSoPhLpg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Mon, Nov 26, 2018 at 09:43:42AM -0800, Doug Anderson wrote:
> NOTE: another option would be to change the regulator driver to just
> force this rail to a high power mode and never let it change. That's
> what we're doing on a SDM845-based board. When the regulator is off
> the mode doesn't matter and as per the above argument we always want
> it in high power mode when it's on.
You should never need to modify the driver for this, the regulator
framework will only change things if it's been given permission to do
so - simply don't specify a regulator-allowed-modes property and the
mode will be left alone (we should probably still use -initial-mode if
it's specified but I'd need to check if we actually do).
> > I see that there are 8 users of regulator-system-load but most are all
> > addressing this same issue with the SD card.
> > qcom-msm8974-sony-xperia-castor.dts sets the load to 500 mA but all of
> > the other msm8974-based SOCs use 200 mA. I'm not sure if this is
> > correct.
> Interestingly enough I think the max load here is specified by the SD
> card specification. My quick reading of the SD spec shows that you
> could do all sorts of complex negotiation with the card about how much
> load it could take up but Linux didn't actually support that. If I'm
> reading it right the default is 200 mA.
I'd like to see how closely hardware adheres to the spec too...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-26 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 9:37 Question about "regulator: core: Only count load for enabled consumers" in -next Brian Masney
2018-11-25 17:20 ` Doug Anderson
2018-11-25 23:24 ` Brian Masney
2018-11-26 12:50 ` Mark Brown
2018-11-26 17:43 ` Doug Anderson
2018-11-26 17:59 ` Mark Brown [this message]
2018-11-26 18:11 ` Doug Anderson
2018-11-26 18:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126175945.GL9715@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).