linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node
@ 2018-11-26 14:21 Govind Singh
  2018-11-26 14:31 ` Fabio Estevam
  2018-11-26 14:44 ` Vinod Koul
  0 siblings, 2 replies; 5+ messages in thread
From: Govind Singh @ 2018-11-26 14:21 UTC (permalink / raw)
  To: andy.gross, bjorn.andersson, devicetree
  Cc: linux-arm-kernel, linux-kernel, linux-arm-msm, Govind Singh

Add device node for the ath10k SNOC platform driver probe
and add resources required for WCN3990 on qcs404 soc.
Optional clock and regulator controls are not yet available in
upstream, hence add them once available.

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/qcs404.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 9ca4f061ecc5..1a401a32d4a1 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -958,6 +958,25 @@
 				status = "disabled";
 			};
 		};
+
+		wifi: wifi@0A000000 {
+			compatible = "qcom,wcn3990-wifi";
+			reg = <0x0A000000 0x800000>;
+			reg-names = "membase";
+			memory-region = <&wlan_msa_mem>;
+			interrupts = <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 284 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 285 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 
 	timer {
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node
  2018-11-26 14:21 [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node Govind Singh
@ 2018-11-26 14:31 ` Fabio Estevam
  2018-11-26 14:44 ` Vinod Koul
  1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-11-26 14:31 UTC (permalink / raw)
  To: govinds
  Cc: Andy Gross, Bjorn Andersson,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, linux-arm-msm

On Mon, Nov 26, 2018 at 12:22 PM Govind Singh <govinds@codeaurora.org> wrote:

> +
> +               wifi: wifi@0A000000 {

Please remove the leading zero. Building with W=1 would warn you about that.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node
  2018-11-26 14:21 [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node Govind Singh
  2018-11-26 14:31 ` Fabio Estevam
@ 2018-11-26 14:44 ` Vinod Koul
  2018-11-26 16:58   ` Govind Singh
  1 sibling, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2018-11-26 14:44 UTC (permalink / raw)
  To: Govind Singh
  Cc: andy.gross, bjorn.andersson, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm

Hi Govind,

On 26-11-18, 19:51, Govind Singh wrote:
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on qcs404 soc.
> Optional clock and regulator controls are not yet available in
> upstream, hence add them once available.
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/qcs404.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 9ca4f061ecc5..1a401a32d4a1 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -958,6 +958,25 @@
>  				status = "disabled";
>  			};
>  		};
> +
> +		wifi: wifi@0A000000 {

Please remove leading 0 from node

> +			compatible = "qcom,wcn3990-wifi";
> +			reg = <0x0A000000 0x800000>;
> +			reg-names = "membase";
> +			memory-region = <&wlan_msa_mem>;
> +			interrupts = <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 284 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 285 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
> +		};
>  	};
>  
>  	timer {

This file is sorted alphabetically and reg values. So this should be
between blsp1_uart2 and intc node, can you please change that

Also please compile this with W=12

Lastly, I am not sure, but should the wifi node be always enabled?
Should it not be enabled in the board dts file? Bjorn..?

Thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node
  2018-11-26 14:44 ` Vinod Koul
@ 2018-11-26 16:58   ` Govind Singh
  2018-11-26 17:25     ` Vinod Koul
  0 siblings, 1 reply; 5+ messages in thread
From: Govind Singh @ 2018-11-26 16:58 UTC (permalink / raw)
  To: Vinod Koul
  Cc: andy.gross, bjorn.andersson, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm

Hi Vinod,

Thanks for the review.

On 2018-11-26 20:14, Vinod Koul wrote:
> Hi Govind,
> 
> On 26-11-18, 19:51, Govind Singh wrote:
>> Add device node for the ath10k SNOC platform driver probe
>> and add resources required for WCN3990 on qcs404 soc.
>> Optional clock and regulator controls are not yet available in
>> upstream, hence add them once available.
>> 
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs404.dtsi | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi 
>> b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> index 9ca4f061ecc5..1a401a32d4a1 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> @@ -958,6 +958,25 @@
>>  				status = "disabled";
>>  			};
>>  		};
>> +
>> +		wifi: wifi@0A000000 {
> 
> Please remove leading 0 from node
> 

Sure, i will change in v2.

>> +			compatible = "qcom,wcn3990-wifi";
>> +			reg = <0x0A000000 0x800000>;
>> +			reg-names = "membase";
>> +			memory-region = <&wlan_msa_mem>;
>> +			interrupts = <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 284 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 285 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>;
>> +		};
>>  	};
>> 
>>  	timer {
> 
> This file is sorted alphabetically and reg values. So this should be
> between blsp1_uart2 and intc node, can you please change that
> 
> Also please compile this with W=12
> 

Sure, i will change in v2.

> Lastly, I am not sure, but should the wifi node be always enabled?
> Should it not be enabled in the board dts file? Bjorn..?
> 

yes, i some how missed this.
I will mark the status disabled by default and enable from qcs404 evb 
dts.

> Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node
  2018-11-26 16:58   ` Govind Singh
@ 2018-11-26 17:25     ` Vinod Koul
  0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2018-11-26 17:25 UTC (permalink / raw)
  To: Govind Singh
  Cc: andy.gross, bjorn.andersson, devicetree, linux-arm-kernel,
	linux-kernel, linux-arm-msm

Hi Govind,

On 26-11-18, 22:28, Govind Singh wrote:
> On 2018-11-26 20:14, Vinod Koul wrote:
> > On 26-11-18, 19:51, Govind Singh wrote:

> > Lastly, I am not sure, but should the wifi node be always enabled?
> > Should it not be enabled in the board dts file? Bjorn..?
> > 
> 
> yes, i some how missed this.
> I will mark the status disabled by default and enable from qcs404 evb dts.

No issues, also we have two DTS EVB-1000 and EVB-4000, please choose
accordingly and if common please use qcs404-evb.dtsi

-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-26 17:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 14:21 [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node Govind Singh
2018-11-26 14:31 ` Fabio Estevam
2018-11-26 14:44 ` Vinod Koul
2018-11-26 16:58   ` Govind Singh
2018-11-26 17:25     ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).