From: Greg KH <gregkh@linuxfoundation.org>
To: kys@microsoft.com
Cc: will.deacon@arm.com, catalin.marinas@armm.com,
mark.rutland@arm.com, marc.zyngier@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
sthemmin@microsoft.com, Michael.H.Kelley@microsoft.com,
vkuznets@redhat.com, Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor
Date: Mon, 26 Nov 2018 20:19:46 +0100 [thread overview]
Message-ID: <20181126191946.GB32208@kroah.com> (raw)
In-Reply-To: <20181122031059.16338-2-kys@linuxonhyperv.com>
On Thu, Nov 22, 2018 at 03:10:57AM +0000, kys@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/arch/arm64/hyperv/hv_hvc.S
> @@ -0,0 +1,54 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
Using SPDX is good, but:
> +
> +/*
> + * Microsoft Hyper-V hypervisor invocation routines
> + *
> + * Copyright (C) 2018, Microsoft, Inc.
> + *
> + * Author : Michael Kelley <mikelley@microsoft.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published
> + * by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
> + * NON INFRINGEMENT. See the GNU General Public License for more
> + * details.
No need for these two paragraphs at all. If you add them now, someone
will just come along later and rip them out. Please don't include them
in the first place.
Not to mention the first paragraph doesn't make sense, think about
"which" version 2 the FSF published (hint, there was 5 or 7 or so...)
That's why we have one in the kernel tree for everyone to rely on.
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-26 19:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 3:09 [PATCH 0/4] Hyper-V: Enable Linux guests on Hyper-V on ARM64 kys
2018-11-22 3:10 ` [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files kys
2018-11-22 3:10 ` [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor kys
2018-11-26 19:19 ` Greg KH [this message]
2018-12-07 13:42 ` Will Deacon
2018-12-07 14:43 ` Marc Zyngier
2018-12-12 5:00 ` Michael Kelley
2018-12-13 11:23 ` Marc Zyngier
2019-01-04 20:05 ` Michael Kelley
2019-01-21 4:38 ` Michael Kelley
2018-11-22 3:10 ` [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ kys
2018-11-26 19:21 ` Greg KH
2018-11-26 19:47 ` Michael Kelley
2018-11-26 19:57 ` Greg KH
2018-11-26 20:56 ` Michael Kelley
2018-11-27 6:20 ` Greg KH
2018-11-27 10:19 ` Will Deacon
2018-12-03 1:47 ` Michael Kelley
2018-11-22 3:10 ` [PATCH 4/4] Drivers: hv: Enable CONFIG_HYPERV on ARM64 kys
2018-11-26 19:18 ` [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files Greg KH
2018-11-26 20:21 ` Joshua R. Poulson
2018-11-27 3:06 ` KY Srinivasan
2018-12-07 13:42 ` Will Deacon
2018-12-12 1:19 ` Michael Kelley
2018-12-10 17:43 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126191946.GB32208@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.H.Kelley@microsoft.com \
--cc=apw@canonical.com \
--cc=catalin.marinas@armm.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).