From: Michael Kelley <mikelley@microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>, KY Srinivasan <kys@microsoft.com>
Cc: "will.deacon@arm.com" <will.deacon@arm.com>,
"catalin.marinas@armm.com" <catalin.marinas@armm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
vkuznets <vkuznets@redhat.com>
Subject: RE: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ
Date: Mon, 26 Nov 2018 19:47:41 +0000 [thread overview]
Message-ID: <CY4PR21MB07735AB610D4BFD3EB7556D5D7D70@CY4PR21MB0773.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20181126192101.GC32208@kroah.com>
From: Greg KH <gregkh@linuxfoundation.org> Monday, November 26, 2018 11:21 AM
> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > index 0d6271cce198..8d97bd3a13a6 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -109,6 +109,10 @@ void hyperv_vector_handler(struct pt_regs *regs);
> > void hv_setup_vmbus_irq(void (*handler)(void));
> > void hv_remove_vmbus_irq(void);
> >
> > +/* On x86/x64, there isn't a real IRQ to be enabled/disable */
> > +static inline void hv_enable_vmbus_irq(void) {}
> > +static inline void hv_disable_vmbus_irq(void) {}
> > +
> > void hv_setup_kexec_handler(void (*handler)(void));
> > void hv_remove_kexec_handler(void);
> > void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
> > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > index 166c2501de17..d0bb09a4bd73 100644
> > --- a/drivers/hv/hv.c
> > +++ b/drivers/hv/hv.c
> > @@ -307,6 +307,7 @@ int hv_synic_init(unsigned int cpu)
> > hv_set_siefp(siefp.as_uint64);
> >
> > /* Setup the shared SINT. */
> > + hv_enable_vmbus_irq();
> > hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
> >
> > shared_sint.vector = HYPERVISOR_CALLBACK_VECTOR;
> > @@ -434,6 +435,7 @@ int hv_synic_cleanup(unsigned int cpu)
> > /* Disable the global synic bit */
> > sctrl.enable = 0;
> > hv_set_synic_state(sctrl.as_uint64);
> > + hv_disable_vmbus_irq();
> >
> > return 0;
> > }
> > --
> > 2.19.1
>
> You created "null" hooks that do nothing, for no one in this patch
> series, why?
>
hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
implementations in the ARM64 code in patch 2 of this series. The
implementations are in the new file arch/arm64/hyperv/mshyperv.c.
Or am I misunderstanding your point?
Michael
next prev parent reply other threads:[~2018-11-26 19:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 3:09 [PATCH 0/4] Hyper-V: Enable Linux guests on Hyper-V on ARM64 kys
2018-11-22 3:10 ` [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files kys
2018-11-22 3:10 ` [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor kys
2018-11-26 19:19 ` Greg KH
2018-12-07 13:42 ` Will Deacon
2018-12-07 14:43 ` Marc Zyngier
2018-12-12 5:00 ` Michael Kelley
2018-12-13 11:23 ` Marc Zyngier
2019-01-04 20:05 ` Michael Kelley
2019-01-21 4:38 ` Michael Kelley
2018-11-22 3:10 ` [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ kys
2018-11-26 19:21 ` Greg KH
2018-11-26 19:47 ` Michael Kelley [this message]
2018-11-26 19:57 ` Greg KH
2018-11-26 20:56 ` Michael Kelley
2018-11-27 6:20 ` Greg KH
2018-11-27 10:19 ` Will Deacon
2018-12-03 1:47 ` Michael Kelley
2018-11-22 3:10 ` [PATCH 4/4] Drivers: hv: Enable CONFIG_HYPERV on ARM64 kys
2018-11-26 19:18 ` [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files Greg KH
2018-11-26 20:21 ` Joshua R. Poulson
2018-11-27 3:06 ` KY Srinivasan
2018-12-07 13:42 ` Will Deacon
2018-12-12 1:19 ` Michael Kelley
2018-12-10 17:43 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR21MB07735AB610D4BFD3EB7556D5D7D70@CY4PR21MB0773.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=apw@canonical.com \
--cc=catalin.marinas@armm.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).