[PATCH] misc/pvpanic: resolve compile errors for arch=um

[PATCH] misc/pvpanic: resolve compile errors for arch=um

[Peng Hao]

Resolve compile error for arch=um
pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 drivers/misc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 642626a..f417b06 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -515,7 +515,7 @@ config MISC_RTSX
 
 config PVPANIC
 	tristate "pvpanic device support"
-	depends on ACPI || OF
+	depends on HAS_IOMEM && (ACPI || OF)
 	help
 	  This driver provides support for the pvpanic device.  pvpanic is
 	  a paravirtualized device provided by QEMU; it lets a virtual machine
-- 
1.8.3.1

Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

[Greg KH]

On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> Resolve compile error for arch=um
> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  drivers/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What commit is this fixing?  What broke and when did it break?

thanks,

greg k-h

Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

[Greg KH]

On Tue, Nov 27, 2018 at 08:27:03AM +0800, peng.hao2@zte.com.cn wrote:
> >On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> >> Resolve compile error for arch=um
> >> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> >>
> >> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> >> ---
> >>  drivers/misc/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >What commit is this fixing?  What broke and when did it break?
> kbuildtestrobot reports this compile  error for arch=um.
> here is content:
> " head:   24438e46268c721e14c5c888386af85c9e1c5db1
> commit: 77703e0b0326a1fb06b5cb5b468a633472c5a8e9 [10/26] misc/pvpanic : break dependency on ACPI

Ah, it is breaking because of your patch, not a patch in the kernel
today.  So please integrate this patch into your latest patch series
when you redo your patches.

thanks,

greg k-h

Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

[Greg KH]

On Tue, Nov 27, 2018 at 03:47:28PM +0800, peng.hao2@zte.com.cn wrote:
> >> >On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> >> >> Resolve compile error for arch=um
> >> >> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> >> >>
> >> >> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> >> >> ---
> >> >>  drivers/misc/Kconfig | 2 +-
> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> >What commit is this fixing?  What broke and when did it break?
> >> kbuildtestrobot reports this compile  error for arch=um.
> >> here is content:
> >> " head:   24438e46268c721e14c5c888386af85c9e1c5db1
> >> commit: 77703e0b0326a1fb06b5cb5b468a633472c5a8e9 [10/26] misc/pvpanic : break dependency on ACPI
> >
> >Ah, it is breaking because of your patch, not a patch in the kernel
> >today.  So please integrate this patch into your latest patch series
> >when you redo your patches.
> >
> The series of patches has merged into "char-misc-next"
> (https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-next),
> Do I need to re-send the entire series of patches ? 

Ah, I didn't realize that.  Ok, let me go dig this back up and add it
to my tree, sorry for the noise...

greg k-h