* [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings
[not found] <201811280723.DnTk8AXL%fengguang.wu@intel.com>
@ 2018-11-27 23:21 ` kbuild test robot
2018-11-29 23:37 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-11-27 23:21 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: kbuild-all, Leon Romanovsky, Doug Ledford, Yishai Hadas,
Mark Bloch, Matan Barak, Ariel Levkovich, linux-rdma,
linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma for-next
head: 07f05f40d956d40f32852a7b3ff109a72d254cf9
commit: 7106a9769715bb4c0448927a29aa3b505855871c [31/37] RDMA/uverbs: Make write() handlers return 0 on success
uverbs_cmd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1092,10 +1092,7 @@ static int ib_uverbs_create_cq(struct uv
sizeof(cmd.comp_channel), ib_uverbs_create_cq_cb,
NULL);
- if (IS_ERR(obj))
- return PTR_ERR(obj);
-
- return 0;
+ return PTR_ERR_OR_ZERO(obj);
}
static int ib_uverbs_ex_create_cq_cb(struct uverbs_attr_bundle *attrs,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings
2018-11-27 23:21 ` [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings kbuild test robot
@ 2018-11-29 23:37 ` Jason Gunthorpe
2018-12-03 17:23 ` Doug Ledford
0 siblings, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2018-11-29 23:37 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Leon Romanovsky, Doug Ledford, Yishai Hadas,
Mark Bloch, Ariel Levkovich, linux-rdma, linux-kernel
On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> ---
applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings
2018-11-29 23:37 ` Jason Gunthorpe
@ 2018-12-03 17:23 ` Doug Ledford
2018-12-03 20:47 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Doug Ledford @ 2018-12-03 17:23 UTC (permalink / raw)
To: Jason Gunthorpe, kbuild test robot
Cc: kbuild-all, Leon Romanovsky, Yishai Hadas, Mark Bloch,
Ariel Levkovich, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote:
> On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> > From: kbuild test robot <fengguang.wu@intel.com>
> >
> > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> > Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> > ---
>
> applied to for-next, thanks
>
> Jason
This caused a conflict with your make write() handlers use a consistent
flow series, which I fixed up during git am run. Just FYI in case you
want to check out the conflict spot as a double check (but it was a
simple fixup).
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings
2018-12-03 17:23 ` Doug Ledford
@ 2018-12-03 20:47 ` Jason Gunthorpe
0 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2018-12-03 20:47 UTC (permalink / raw)
To: Doug Ledford
Cc: kbuild test robot, kbuild-all, Leon Romanovsky, Yishai Hadas,
Mark Bloch, Ariel Levkovich, linux-rdma, linux-kernel
On Mon, Dec 03, 2018 at 12:23:35PM -0500, Doug Ledford wrote:
> On Thu, 2018-11-29 at 16:37 -0700, Jason Gunthorpe wrote:
> > On Wed, Nov 28, 2018 at 07:21:30AM +0800, kbuild test robot wrote:
> > > From: kbuild test robot <fengguang.wu@intel.com>
> > >
> > > drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> > >
> > >
> > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> > >
> > > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> > >
> > > Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
> > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> >
> > applied to for-next, thanks
> >
> > Jason
>
> This caused a conflict with your make write() handlers use a consistent
> flow series, which I fixed up during git am run. Just FYI in case you
> want to check out the conflict spot as a double check (but it was a
> simple fixup).
Looks OK to me thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-03 20:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201811280723.DnTk8AXL%fengguang.wu@intel.com>
2018-11-27 23:21 ` [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings kbuild test robot
2018-11-29 23:37 ` Jason Gunthorpe
2018-12-03 17:23 ` Doug Ledford
2018-12-03 20:47 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).