* [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
@ 2018-11-01 15:43 Vokáč Michal
[not found] ` <5bea0e99.1c69fb81.18be0.5162@mx.google.com>
2018-11-28 2:39 ` Shawn Guo
0 siblings, 2 replies; 8+ messages in thread
From: Vokáč Michal @ 2018-11-01 15:43 UTC (permalink / raw)
To: Rob Herring, Fabio Estevam
Cc: linux-arm-kernel, linux-kernel, NXP Linux Team, devicetree,
Sascha Hauer, Shawn Guo, Mark Rutland, Vokáč Michal,
Andrew Lunn
These are i.MX6S/DL based SBCs embedded in various Y Soft products.
All share the same board design but have slightly different HW
configuration.
Ursa
- i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
- parallel WVGA 7" LCD with touch panel
- 1x Eth (QCA8334 switch)
- USB OTG
- USB host (micro-B)
Draco
- i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
- parallel WVGA 7" LCD with touch panel
- 2x Eth (QCA8334 switch)
- USB OTG
- USB host (micro-B)
- RGB LED (I2C LP5562)
- 3.5mm audio jack + codec (LM49350)
Hydra
- i.MX6DL SoC, 2GB RAM DDR3, 4GB eMMC, microSD
- I2C OLED display, capacitive matrix keys
- 2x Eth (QCA8334 switch)
- USB OTG
- RGB LED (I2C LP5562)
- 3.5mm audio jack + codec (LM49350)
- HDMI
- miniPCIe slot
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
All the boards are booting fine but not everything is enabled/supported
yet though. There is few things that will need some effort to get them
fully working.
- HDMI: nothing specific, it just does not have the priority
- OLED display: reset signal inversion, wrong display resolution,...
- capacitive keys: polled driver for MPR121 needed as we do not have
the interrupt line
- Eth switch: need tweaks in i.MX RGMII pin group control registers
- audio codec: no existing driver yet (in mainline)
So expect patches targeting the mentioned issues and updates to the dts
files enabling additional HW.
CC-ing Andrew since he was interested in this board as it has a DSA
Ethernet switch populated.
Thanks,
Michal
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 535 +++++++++++++++++++++++++++++
arch/arm/boot/dts/imx6dl-yapp4-draco.dts | 57 +++
arch/arm/boot/dts/imx6dl-yapp4-hydra.dts | 33 ++
arch/arm/boot/dts/imx6dl-yapp4-ursa.dts | 53 +++
5 files changed, 681 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-draco.dts
create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b5bd3de..cf24410 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -441,6 +441,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6dl-wandboard.dtb \
imx6dl-wandboard-revb1.dtb \
imx6dl-wandboard-revd1.dtb \
+ imx6dl-yapp4-draco.dtb \
+ imx6dl-yapp4-hydra.dtb \
+ imx6dl-yapp4-ursa.dtb \
imx6q-apalis-eval.dtb \
imx6q-apalis-ixora.dtb \
imx6q-apalis-ixora-v1.1.dtb \
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
new file mode 100644
index 0000000..9925523
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -0,0 +1,535 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>
+
+/ {
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 32 64 128 255>;
+ default-brightness-level = <32>;
+ num-interpolated-steps = <8>;
+ power-supply = <&sw2_reg>;
+ status = "disabled";
+ };
+
+ lcd_display: display {
+ compatible = "fsl,imx-parallel-display";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interface-pix-fmt = "rgb24";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ipu1>;
+ status = "disabled";
+
+ port@0 {
+ reg = <0>;
+
+ lcd_display_in: endpoint {
+ remote-endpoint = <&ipu1_di0_disp0>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ lcd_display_out: endpoint {
+ remote-endpoint = <&lcd_panel_in>;
+ };
+ };
+ };
+
+ panel: panel {
+ compatible = "dataimage,scf0700c48ggu18";
+ power-supply = <&sw2_reg>;
+ status = "disabled";
+
+ port {
+ lcd_panel_in: endpoint {
+ remote-endpoint = <&lcd_display_out>;
+ };
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ reg_usb_otg_vbus: regulator@0 {
+ compatible = "regulator-fixed";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg_vbus>;
+ regulator-name = "usb_otg_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ status = "okay";
+ };
+
+ reg_usb_h1_vbus: regulator@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbh1_vbus>;
+ regulator-name = "usb_h1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ status = "disabled";
+ };
+
+ reg_pcie: regulator@2 {
+ compatible = "regulator-fixed";
+ reg = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pcie_reg>;
+ regulator-name = "MPCIE_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ status = "disabled";
+ };
+ };
+};
+
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-mode = "rgmii-id";
+ phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
+ phy-reset-duration = <20>;
+ phy-supply = <&sw2_reg>;
+ phy-handle = <ðphy0>;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ phy_port2: phy@1 {
+ reg = <1>;
+ };
+
+ phy_port3: phy@2 {
+ reg = <2>;
+ };
+
+ switch@0 {
+ compatible = "qca,qca8334";
+ reg = <0>;
+
+ switch_ports: ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethphy0: port@0 {
+ reg = <0>;
+ label = "cpu";
+ phy-mode = "rgmii";
+ ethernet = <&fec>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "eth2";
+ phy-handle = <&phy_port2>;
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "eth1";
+ phy-handle = <&phy_port3>;
+ };
+ };
+ };
+ };
+};
+
+&i2c2 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+
+ eeprom@57 {
+ compatible = "atmel,24c128";
+ reg = <0x57>;
+ pagesize = <64>;
+ status = "okay";
+ };
+
+ leds: leds@30 {
+ compatible = "ti,lp5562";
+ label = "lp5562_leds";
+ reg = <0x30>;
+ clock-mode = /bits/ 8 <1>;
+ status = "disabled";
+
+ chan0 {
+ chan-name = "R";
+ led-cur = /bits/ 8 <0x20>;
+ max-cur = /bits/ 8 <0x60>;
+ };
+
+ chan1 {
+ chan-name = "G";
+ led-cur = /bits/ 8 <0x20>;
+ max-cur = /bits/ 8 <0x60>;
+ };
+
+ chan2 {
+ chan-name = "B";
+ led-cur = /bits/ 8 <0x20>;
+ max-cur = /bits/ 8 <0x60>;
+ };
+
+ chan3 {
+ chan-name = "W";
+ led-cur = /bits/ 8 <0x0>;
+ max-cur = /bits/ 8 <0x0>;
+ };
+ };
+
+ pfuze200@8 {
+ compatible = "fsl,pfuze200";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pmic>;
+ reg = <0x8>;
+
+ regulators {
+ sw1a_reg: sw1ab {
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1875000>;
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-ramp-delay = <6250>;
+ };
+
+ sw2_reg: sw2 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sw3a_reg: sw3a {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <1975000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sw3b_reg: sw3b {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <1975000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ swbst_reg: swbst {
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5150000>;
+ };
+
+ snvs_reg: vsnvs {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ vref_reg: vrefddr {
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ vgen1_reg: vgen1 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1550000>;
+ };
+
+ vgen2_reg: vgen2 {
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1550000>;
+ };
+
+ vgen3_reg: vgen3 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen4_reg: vgen4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen5_reg: vgen5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ vgen6_reg: vgen6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+ };
+ };
+};
+
+&iomuxc {
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1B020
+ MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1B020
+ MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1B020
+ MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1B020
+ MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1B020
+ MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1B020
+ MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1B020
+ MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1B020
+ MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1B020
+ MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1B020
+ MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1B020
+ MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1B020
+ MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1B020
+ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1B020
+ MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1B010
+ MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1B010
+ MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1B098
+ >;
+ };
+
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b899
+ MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b899
+ >;
+ };
+
+ pinctrl_ipu1: ipu1grp {
+ fsl,pins = <
+ MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10
+ MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
+ MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
+ MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x10
+ MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x10
+ MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x10
+ MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0x10
+ MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0x10
+ MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0x10
+ MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0x10
+ MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0x10
+ MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0x10
+ MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0x10
+ MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0x10
+ MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0x10
+ MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0x10
+ MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0x10
+ MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0x10
+ MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0x10
+ MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0x10
+ MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0x10
+ MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0x10
+ MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0x10
+ MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0x10
+ MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0x10
+ MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0x10
+ MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0x10
+ >;
+ };
+
+ pinctrl_pcie: pciegrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b098
+ MX6QDL_PAD_KEY_COL4__GPIO4_IO14 0x1b098
+ MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b098
+ >;
+ };
+
+ pinctrl_pcie_reg: pciereggrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x1b098
+ >;
+ };
+
+ pinctrl_pmic: pmicgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b098
+ >;
+ };
+
+ pinctrl_backlight_pwm: pwm1grp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_9__PWM1_OUT 0x8
+ >;
+ };
+
+ pinctrl_uart1: uart1grp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0a8
+ MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0a8
+ >;
+ };
+
+ pinctrl_usbh1: usbh1grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D30__USB_H1_OC 0x1b098
+ >;
+ };
+
+ pinctrl_usbh1_vbus: usbh1-vbus {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x98
+ >;
+ };
+
+ pinctrl_usbotg: usbotggrp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1b098
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b098
+ >;
+ };
+
+ pinctrl_usbotg_vbus: usbotg-vbus {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x98
+ >;
+ };
+
+ pinctrl_usdhc3: usdhc3grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x1b018
+ MX6QDL_PAD_SD3_RST__GPIO7_IO08 0x1b018
+ MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
+ MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10059
+ MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17059
+ MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17059
+ MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17059
+ MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059
+ >;
+ };
+
+ pinctrl_usdhc4: usdhc4grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD4_CMD__SD4_CMD 0x1f069
+ MX6QDL_PAD_SD4_CLK__SD4_CLK 0x10069
+ MX6QDL_PAD_SD4_DAT0__SD4_DATA0 0x17069
+ MX6QDL_PAD_SD4_DAT1__SD4_DATA1 0x17069
+ MX6QDL_PAD_SD4_DAT2__SD4_DATA2 0x17069
+ MX6QDL_PAD_SD4_DAT3__SD4_DATA3 0x17069
+ MX6QDL_PAD_SD4_DAT4__SD4_DATA4 0x17069
+ MX6QDL_PAD_SD4_DAT5__SD4_DATA5 0x17069
+ MX6QDL_PAD_SD4_DAT6__SD4_DATA6 0x17069
+ MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17069
+ >;
+ };
+
+ pinctrl_wdog: wdoggrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_1__WDOG2_B 0x1b0b0
+ >;
+ };
+};
+
+&ipu1_di0_disp0 {
+ remote-endpoint = <&lcd_display_in>;
+};
+
+&pcie {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pcie>;
+ reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ vpcie-supply = <®_pcie>;
+ status = "disabled";
+};
+
+&pwm1 {
+ #pwm-cells = <3>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight_pwm>;
+ status = "disabled";
+};
+
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart1>;
+ status = "okay";
+};
+
+&usbh1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbh1>;
+ vbus-supply = <®_usb_h1_vbus>;
+ status = "disabled";
+};
+
+&usbotg {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ vbus-supply = <®_usb_otg_vbus>;
+ srp-disable;
+ hnp-disable;
+ adp-disable;
+ status = "okay";
+};
+
+&usbphy1 {
+ fsl,tx-d-cal = <106>;
+ status = "okay";
+};
+
+&usbphy2 {
+ fsl,tx-d-cal = <109>;
+ status = "disabled";
+};
+
+&usdhc3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc3>;
+ bus-width = <4>;
+ cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
+ wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
+ no-1-8-v;
+ keep-power-in-suspend;
+ enable-sdio-wakeup;
+ vmmc-supply = <&sw2_reg>;
+ status = "disabled";
+};
+
+&usdhc4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc4>;
+ bus-width = <8>;
+ non-removable;
+ no-1-8-v;
+ keep-power-in-suspend;
+ vmmc-supply = <&sw2_reg>;
+ status = "okay";
+};
+
+&wdog1 {
+ status = "disabled";
+};
+
+&wdog2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog>;
+ fsl,ext-reset-output;
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-draco.dts b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
new file mode 100644
index 0000000..fb62f31
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
+
+/dts-v1/;
+
+#include "imx6dl.dtsi"
+#include "imx6dl-yapp4-common.dtsi"
+
+/ {
+ model = "Y Soft IOTA Draco i.MX6Solo board";
+ compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
+
+ cpus {
+ /delete-node/ cpu@1;
+ };
+
+ memory@10000000 {
+ reg = <0x10000000 0x20000000>;
+ };
+};
+
+&backlight {
+ status = "okay";
+};
+
+&lcd_display {
+ status = "okay";
+};
+
+&leds {
+ status = "okay";
+};
+
+&panel {
+ status = "okay";
+};
+
+&pwm1 {
+ status = "okay";
+};
+
+®_usb_h1_vbus {
+ status = "okay";
+};
+
+&usbh1 {
+ status = "okay";
+};
+
+&usbphy2 {
+ status = "okay";
+};
+
+&usdhc3 {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
new file mode 100644
index 0000000..799fb4c
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
+
+/dts-v1/;
+
+#include "imx6dl.dtsi"
+#include "imx6dl-yapp4-common.dtsi"
+
+/ {
+ model = "Y Soft IOTA Hydra i.MX6DualLite board";
+ compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
+
+ memory@10000000 {
+ reg = <0x10000000 0x80000000>;
+ };
+};
+
+&leds {
+ status = "okay";
+};
+
+&pcie {
+ status = "okay";
+};
+
+®_pcie {
+ status = "okay";
+};
+
+&usdhc3 {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
new file mode 100644
index 0000000..23af972
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
+
+/dts-v1/;
+
+#include "imx6dl.dtsi"
+#include "imx6dl-yapp4-common.dtsi"
+
+/ {
+ model = "Y Soft IOTA Ursa i.MX6Solo board";
+ compatible = "ysoft,imx6dl-yapp4-ursa", "fsl,imx6dl";
+
+ cpus {
+ /delete-node/ cpu@1;
+ };
+
+ memory@10000000 {
+ reg = <0x10000000 0x20000000>;
+ };
+};
+
+&backlight {
+ status = "okay";
+};
+
+&lcd_display {
+ status = "okay";
+};
+
+&panel {
+ status = "okay";
+};
+
+&pwm1 {
+ status = "okay";
+};
+
+®_usb_h1_vbus {
+ status = "okay";
+};
+
+&switch_ports {
+ /delete-node/ port@2;
+};
+
+&usbh1 {
+ status = "okay";
+};
+
+&usbphy2 {
+ status = "okay";
+};
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
[not found] ` <5bea0e99.1c69fb81.18be0.5162@mx.google.com>
@ 2018-11-19 14:35 ` Vokáč Michal
2018-11-27 12:19 ` Vokáč Michal
0 siblings, 1 reply; 8+ messages in thread
From: Vokáč Michal @ 2018-11-19 14:35 UTC (permalink / raw)
To: Rob Herring
Cc: Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
devicetree, Sascha Hauer, Shawn Guo, Mark Rutland, Andrew Lunn
On 12.11.2018 17:41, Rob Herring wrote:
> On Thu, Nov 01, 2018 at 03:43:26PM +0000, Vokáč Michal wrote:
>> These are i.MX6S/DL based SBCs embedded in various Y Soft products.
>> All share the same board design but have slightly different HW
>> configuration.
>>
>> Ursa
>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>> - parallel WVGA 7" LCD with touch panel
>> - 1x Eth (QCA8334 switch)
>> - USB OTG
>> - USB host (micro-B)
>>
>> Draco
>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>> - parallel WVGA 7" LCD with touch panel
>> - 2x Eth (QCA8334 switch)
>> - USB OTG
>> - USB host (micro-B)
>> - RGB LED (I2C LP5562)
>> - 3.5mm audio jack + codec (LM49350)
>>
>> Hydra
>> - i.MX6DL SoC, 2GB RAM DDR3, 4GB eMMC, microSD
>> - I2C OLED display, capacitive matrix keys
>> - 2x Eth (QCA8334 switch)
>> - USB OTG
>> - RGB LED (I2C LP5562)
>> - 3.5mm audio jack + codec (LM49350)
>> - HDMI
>> - miniPCIe slot
>>
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>> ---
>>
>> All the boards are booting fine but not everything is enabled/supported
>> yet though. There is few things that will need some effort to get them
>> fully working.
>>
>> - HDMI: nothing specific, it just does not have the priority
>> - OLED display: reset signal inversion, wrong display resolution,...
>> - capacitive keys: polled driver for MPR121 needed as we do not have
>> the interrupt line
>> - Eth switch: need tweaks in i.MX RGMII pin group control registers
>> - audio codec: no existing driver yet (in mainline)
>>
>> So expect patches targeting the mentioned issues and updates to the dts
>> files enabling additional HW.
>>
>> CC-ing Andrew since he was interested in this board as it has a DSA
>> Ethernet switch populated.
>>
>> Thanks,
>> Michal
>>
>> arch/arm/boot/dts/Makefile | 3 +
>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 535 +++++++++++++++++++++++++++++
>> arch/arm/boot/dts/imx6dl-yapp4-draco.dts | 57 +++
>> arch/arm/boot/dts/imx6dl-yapp4-hydra.dts | 33 ++
>> arch/arm/boot/dts/imx6dl-yapp4-ursa.dts | 53 +++
>> 5 files changed, 681 insertions(+)
>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index b5bd3de..cf24410 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -441,6 +441,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>> imx6dl-wandboard.dtb \
>> imx6dl-wandboard-revb1.dtb \
>> imx6dl-wandboard-revd1.dtb \
>> + imx6dl-yapp4-draco.dtb \
>> + imx6dl-yapp4-hydra.dtb \
>> + imx6dl-yapp4-ursa.dtb \
>> imx6q-apalis-eval.dtb \
>> imx6q-apalis-ixora.dtb \
>> imx6q-apalis-ixora-v1.1.dtb \
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> new file mode 100644
>> index 0000000..9925523
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -0,0 +1,535 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +//
>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/pwm/pwm.h>
>> +
>> +/ {
>> + backlight: backlight {
>> + compatible = "pwm-backlight";
>> + pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>;
>> + brightness-levels = <0 32 64 128 255>;
>> + default-brightness-level = <32>;
>> + num-interpolated-steps = <8>;
>> + power-supply = <&sw2_reg>;
>> + status = "disabled";
>> + };
>> +
>> + lcd_display: display {
>> + compatible = "fsl,imx-parallel-display";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interface-pix-fmt = "rgb24";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ipu1>;
>> + status = "disabled";
>> +
>> + port@0 {
>> + reg = <0>;
>> +
>> + lcd_display_in: endpoint {
>> + remote-endpoint = <&ipu1_di0_disp0>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + lcd_display_out: endpoint {
>> + remote-endpoint = <&lcd_panel_in>;
>> + };
>> + };
>> + };
>> +
>> + panel: panel {
>> + compatible = "dataimage,scf0700c48ggu18";
>> + power-supply = <&sw2_reg>;
>> + status = "disabled";
>> +
>> + port {
>> + lcd_panel_in: endpoint {
>> + remote-endpoint = <&lcd_display_out>;
>> + };
>> + };
>> + };
>> +
>> + regulators {
>> + compatible = "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> These are all just individual board level regulators? If so, drop the
> simple-bus and move these up to the top-level.
Yes, individual regulators. I will move it.
>> +
>> + reg_usb_otg_vbus: regulator@0 {
>> + compatible = "regulator-fixed";
>> + reg = <0>;
>
> Dropping reg and unit-address in the process.
OK, I will remove it.
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usbotg_vbus>;
>> + regulator-name = "usb_otg_vbus";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + status = "okay";
>> + };
>> +
>> + reg_usb_h1_vbus: regulator@1 {
>> + compatible = "regulator-fixed";
>> + reg = <1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usbh1_vbus>;
>> + regulator-name = "usb_h1_vbus";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + status = "disabled";
>> + };
>> +
>> + reg_pcie: regulator@2 {
>> + compatible = "regulator-fixed";
>> + reg = <2>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pcie_reg>;
>> + regulator-name = "MPCIE_3V3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + status = "disabled";
>> + };
>> + };
>> +};
>> +
>> +&fec {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_enet>;
>> + phy-mode = "rgmii-id";
>> + phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
>> + phy-reset-duration = <20>;
>> + phy-supply = <&sw2_reg>;
>> + phy-handle = <ðphy0>;
>> + status = "okay";
>> +
>> + mdio {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + phy_port2: phy@1 {
>> + reg = <1>;
>> + };
>> +
>> + phy_port3: phy@2 {
>> + reg = <2>;
>> + };
>> +
>> + switch@0 {
>> + compatible = "qca,qca8334";
>> + reg = <0>;
>> +
>> + switch_ports: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ethphy0: port@0 {
>> + reg = <0>;
>> + label = "cpu";
>> + phy-mode = "rgmii";
>> + ethernet = <&fec>;
>> + fixed-link {
>> + speed = <1000>;
>> + full-duplex;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> + label = "eth2";
>> + phy-handle = <&phy_port2>;
>> + };
>> +
>> + port@3 {
>> + reg = <3>;
>> + label = "eth1";
>> + phy-handle = <&phy_port3>;
>> + };
>> + };
>> + };
>> + };
>> +};
>> +
>> +&i2c2 {
>> + clock-frequency = <100000>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_i2c2>;
>> + status = "okay";
>> +
>> + eeprom@57 {
>> + compatible = "atmel,24c128";
>> + reg = <0x57>;
>> + pagesize = <64>;
>> + status = "okay";
>> + };
>> +
>> + leds: leds@30 {
>
> led-controller@...
OK.
>> + compatible = "ti,lp5562";
>> + label = "lp5562_leds";
>> + reg = <0x30>;
>> + clock-mode = /bits/ 8 <1>;
>> + status = "disabled";
>
> Kind of strange to have these disables. I think disabled should mean
> present in the h/w, but not used/enabled. Either this should be present
> on all boards and enabled or be moved to the per board dts.
Parts that are populated on all boards are enabled here. Parts that are
populated only on some subset are disabled here and enabled in their
appropriate dts files. I took this approach to avoid duplication and to
make the maintenance easier.
My rough guess is that at least 50% of the device nodes would be removed
from this common file and put into each of the board files.
Sure I can do it but it seems very prone to mistakes to me.
>> +
>> + chan0 {
>> + chan-name = "R";
>> + led-cur = /bits/ 8 <0x20>;
>> + max-cur = /bits/ 8 <0x60>;
>> + };
>> +
>> + chan1 {
>> + chan-name = "G";
>> + led-cur = /bits/ 8 <0x20>;
>> + max-cur = /bits/ 8 <0x60>;
>> + };
>> +
>> + chan2 {
>> + chan-name = "B";
>> + led-cur = /bits/ 8 <0x20>;
>> + max-cur = /bits/ 8 <0x60>;
>> + };
>> +
>> + chan3 {
>> + chan-name = "W";
>> + led-cur = /bits/ 8 <0x0>;
>> + max-cur = /bits/ 8 <0x0>;
>> + };
>> + };
>> +
>> + pfuze200@8 {
>
> pmic@8
OK.
>> + compatible = "fsl,pfuze200";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pmic>;
>> + reg = <0x8>;
>> +
>> + regulators {
>> + sw1a_reg: sw1ab {
>> + regulator-min-microvolt = <300000>;
>> + regulator-max-microvolt = <1875000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-ramp-delay = <6250>;
>> + };
>> +
>> + sw2_reg: sw2 {
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + sw3a_reg: sw3a {
>> + regulator-min-microvolt = <400000>;
>> + regulator-max-microvolt = <1975000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + sw3b_reg: sw3b {
>> + regulator-min-microvolt = <400000>;
>> + regulator-max-microvolt = <1975000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + swbst_reg: swbst {
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5150000>;
>> + };
>> +
>> + snvs_reg: vsnvs {
>> + regulator-min-microvolt = <1000000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + vref_reg: vrefddr {
>> + regulator-boot-on;
>> + regulator-always-on;
>> + };
>> +
>> + vgen1_reg: vgen1 {
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <1550000>;
>> + };
>> +
>> + vgen2_reg: vgen2 {
>> + regulator-min-microvolt = <800000>;
>> + regulator-max-microvolt = <1550000>;
>> + };
>> +
>> + vgen3_reg: vgen3 {
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> +
>> + vgen4_reg: vgen4 {
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> +
>> + vgen5_reg: vgen5 {
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> +
>> + vgen6_reg: vgen6 {
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&iomuxc {
>> + pinctrl_enet: enetgrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1B020
>> + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1B020
>> + MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1B020
>> + MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1B020
>> + MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1B020
>> + MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1B020
>> + MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1B020
>> + MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1B020
>> + MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1B020
>> + MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1B020
>> + MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1B020
>> + MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1B020
>> + MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1B020
>> + MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1B020
>> + MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1B010
>> + MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1B010
>> + MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1B098
>> + >;
>> + };
>> +
>> + pinctrl_i2c2: i2c2grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b899
>> + MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b899
>> + >;
>> + };
>> +
>> + pinctrl_ipu1: ipu1grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10
>> + MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
>> + MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
>> + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x10
>> + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x10
>> + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x10
>> + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0x10
>> + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0x10
>> + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0x10
>> + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0x10
>> + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0x10
>> + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0x10
>> + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0x10
>> + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0x10
>> + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0x10
>> + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0x10
>> + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0x10
>> + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0x10
>> + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0x10
>> + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0x10
>> + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0x10
>> + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0x10
>> + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0x10
>> + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0x10
>> + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0x10
>> + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0x10
>> + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0x10
>> + >;
>> + };
>> +
>> + pinctrl_pcie: pciegrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b098
>> + MX6QDL_PAD_KEY_COL4__GPIO4_IO14 0x1b098
>> + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b098
>> + >;
>> + };
>> +
>> + pinctrl_pcie_reg: pciereggrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x1b098
>> + >;
>> + };
>> +
>> + pinctrl_pmic: pmicgrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b098
>> + >;
>> + };
>> +
>> + pinctrl_backlight_pwm: pwm1grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x8
>> + >;
>> + };
>> +
>> + pinctrl_uart1: uart1grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0a8
>> + MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0a8
>> + >;
>> + };
>> +
>> + pinctrl_usbh1: usbh1grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_EIM_D30__USB_H1_OC 0x1b098
>> + >;
>> + };
>> +
>> + pinctrl_usbh1_vbus: usbh1-vbus {
>> + fsl,pins = <
>> + MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x98
>> + >;
>> + };
>> +
>> + pinctrl_usbotg: usbotggrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1b098
>> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b098
>> + >;
>> + };
>> +
>> + pinctrl_usbotg_vbus: usbotg-vbus {
>> + fsl,pins = <
>> + MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x98
>> + >;
>> + };
>> +
>> + pinctrl_usdhc3: usdhc3grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x1b018
>> + MX6QDL_PAD_SD3_RST__GPIO7_IO08 0x1b018
>> + MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
>> + MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10059
>> + MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17059
>> + MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17059
>> + MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17059
>> + MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059
>> + >;
>> + };
>> +
>> + pinctrl_usdhc4: usdhc4grp {
>> + fsl,pins = <
>> + MX6QDL_PAD_SD4_CMD__SD4_CMD 0x1f069
>> + MX6QDL_PAD_SD4_CLK__SD4_CLK 0x10069
>> + MX6QDL_PAD_SD4_DAT0__SD4_DATA0 0x17069
>> + MX6QDL_PAD_SD4_DAT1__SD4_DATA1 0x17069
>> + MX6QDL_PAD_SD4_DAT2__SD4_DATA2 0x17069
>> + MX6QDL_PAD_SD4_DAT3__SD4_DATA3 0x17069
>> + MX6QDL_PAD_SD4_DAT4__SD4_DATA4 0x17069
>> + MX6QDL_PAD_SD4_DAT5__SD4_DATA5 0x17069
>> + MX6QDL_PAD_SD4_DAT6__SD4_DATA6 0x17069
>> + MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17069
>> + >;
>> + };
>> +
>> + pinctrl_wdog: wdoggrp {
>> + fsl,pins = <
>> + MX6QDL_PAD_GPIO_1__WDOG2_B 0x1b0b0
>> + >;
>> + };
>> +};
>> +
>> +&ipu1_di0_disp0 {
>> + remote-endpoint = <&lcd_display_in>;
>> +};
>> +
>> +&pcie {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_pcie>;
>> + reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
>> + vpcie-supply = <®_pcie>;
>> + status = "disabled";
>> +};
>> +
>> +&pwm1 {
>> + #pwm-cells = <3>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_backlight_pwm>;
>> + status = "disabled";
>> +};
>> +
>> +&uart1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_uart1>;
>> + status = "okay";
>> +};
>> +
>> +&usbh1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usbh1>;
>> + vbus-supply = <®_usb_h1_vbus>;
>> + status = "disabled";
>> +};
>> +
>> +&usbotg {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usbotg>;
>> + vbus-supply = <®_usb_otg_vbus>;
>> + srp-disable;
>> + hnp-disable;
>> + adp-disable;
>> + status = "okay";
>> +};
>> +
>> +&usbphy1 {
>> + fsl,tx-d-cal = <106>;
>> + status = "okay";
>> +};
>> +
>> +&usbphy2 {
>> + fsl,tx-d-cal = <109>;
>> + status = "disabled";
>> +};
>> +
>> +&usdhc3 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usdhc3>;
>> + bus-width = <4>;
>> + cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
>> + wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
>> + no-1-8-v;
>> + keep-power-in-suspend;
>> + enable-sdio-wakeup;
>> + vmmc-supply = <&sw2_reg>;
>> + status = "disabled";
>> +};
>> +
>> +&usdhc4 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usdhc4>;
>> + bus-width = <8>;
>> + non-removable;
>> + no-1-8-v;
>> + keep-power-in-suspend;
>> + vmmc-supply = <&sw2_reg>;
>> + status = "okay";
>> +};
>> +
>> +&wdog1 {
>> + status = "disabled";
>> +};
>> +
>> +&wdog2 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_wdog>;
>> + fsl,ext-reset-output;
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-draco.dts b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>> new file mode 100644
>> index 0000000..fb62f31
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>> @@ -0,0 +1,57 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +//
>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>> +
>> +/dts-v1/;
>> +
>> +#include "imx6dl.dtsi"
>> +#include "imx6dl-yapp4-common.dtsi"
>> +
>> +/ {
>> + model = "Y Soft IOTA Draco i.MX6Solo board";
>> + compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
>
> Is this documented?
Just the vendor prefix, not the board names. If I am supposed to add
those as well I would appreciate a hint what is the correct place to
add it. My impression is that only evaluation boards from SoC vendors
are documented.
Thank you,
Michal
>> +
>> + cpus {
>> + /delete-node/ cpu@1;
>> + };
>> +
>> + memory@10000000 {
>> + reg = <0x10000000 0x20000000>;
>> + };
>> +};
>> +
>> +&backlight {
>> + status = "okay";
>> +};
>> +
>> +&lcd_display {
>> + status = "okay";
>> +};
>> +
>> +&leds {
>> + status = "okay";
>> +};
>> +
>> +&panel {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
>> +
>> +®_usb_h1_vbus {
>> + status = "okay";
>> +};
>> +
>> +&usbh1 {
>> + status = "okay";
>> +};
>> +
>> +&usbphy2 {
>> + status = "okay";
>> +};
>> +
>> +&usdhc3 {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>> new file mode 100644
>> index 0000000..799fb4c
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>> @@ -0,0 +1,33 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +//
>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>> +
>> +/dts-v1/;
>> +
>> +#include "imx6dl.dtsi"
>> +#include "imx6dl-yapp4-common.dtsi"
>> +
>> +/ {
>> + model = "Y Soft IOTA Hydra i.MX6DualLite board";
>> + compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
>> +
>> + memory@10000000 {
>> + reg = <0x10000000 0x80000000>;
>> + };
>> +};
>> +
>> +&leds {
>> + status = "okay";
>> +};
>> +
>> +&pcie {
>> + status = "okay";
>> +};
>> +
>> +®_pcie {
>> + status = "okay";
>> +};
>> +
>> +&usdhc3 {
>> + status = "okay";
>> +};
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>> new file mode 100644
>> index 0000000..23af972
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>> @@ -0,0 +1,53 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +//
>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>> +
>> +/dts-v1/;
>> +
>> +#include "imx6dl.dtsi"
>> +#include "imx6dl-yapp4-common.dtsi"
>> +
>> +/ {
>> + model = "Y Soft IOTA Ursa i.MX6Solo board";
>> + compatible = "ysoft,imx6dl-yapp4-ursa", "fsl,imx6dl";
>> +
>> + cpus {
>> + /delete-node/ cpu@1;
>> + };
>> +
>> + memory@10000000 {
>> + reg = <0x10000000 0x20000000>;
>> + };
>> +};
>> +
>> +&backlight {
>> + status = "okay";
>> +};
>> +
>> +&lcd_display {
>> + status = "okay";
>> +};
>> +
>> +&panel {
>> + status = "okay";
>> +};
>> +
>> +&pwm1 {
>> + status = "okay";
>> +};
>> +
>> +®_usb_h1_vbus {
>> + status = "okay";
>> +};
>> +
>> +&switch_ports {
>> + /delete-node/ port@2;
>> +};
>> +
>> +&usbh1 {
>> + status = "okay";
>> +};
>> +
>> +&usbphy2 {
>> + status = "okay";
>> +};
>> --
>> 2.1.4
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-11-19 14:35 ` Vokáč Michal
@ 2018-11-27 12:19 ` Vokáč Michal
2018-12-11 9:27 ` Vokáč Michal
0 siblings, 1 reply; 8+ messages in thread
From: Vokáč Michal @ 2018-11-27 12:19 UTC (permalink / raw)
To: Rob Herring
Cc: Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
devicetree, Sascha Hauer, Shawn Guo, Mark Rutland, Andrew Lunn
On 19.11.2018 15:35, Vokáč Michal wrote:
> On 12.11.2018 17:41, Rob Herring wrote:
>> On Thu, Nov 01, 2018 at 03:43:26PM +0000, Vokáč Michal wrote:
>>> These are i.MX6S/DL based SBCs embedded in various Y Soft products.
>>> All share the same board design but have slightly different HW
>>> configuration.
>>>
>>> Ursa
>>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>>> - parallel WVGA 7" LCD with touch panel
>>> - 1x Eth (QCA8334 switch)
>>> - USB OTG
>>> - USB host (micro-B)
>>>
>>> Draco
>>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>>> - parallel WVGA 7" LCD with touch panel
>>> - 2x Eth (QCA8334 switch)
>>> - USB OTG
>>> - USB host (micro-B)
>>> - RGB LED (I2C LP5562)
>>> - 3.5mm audio jack + codec (LM49350)
>>>
>>> Hydra
>>> - i.MX6DL SoC, 2GB RAM DDR3, 4GB eMMC, microSD
>>> - I2C OLED display, capacitive matrix keys
>>> - 2x Eth (QCA8334 switch)
>>> - USB OTG
>>> - RGB LED (I2C LP5562)
>>> - 3.5mm audio jack + codec (LM49350)
>>> - HDMI
>>> - miniPCIe slot
>>>
>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>>> ---
>>>
>>> All the boards are booting fine but not everything is enabled/supported
>>> yet though. There is few things that will need some effort to get them
>>> fully working.
>>>
>>> - HDMI: nothing specific, it just does not have the priority
>>> - OLED display: reset signal inversion, wrong display resolution,...
>>> - capacitive keys: polled driver for MPR121 needed as we do not have
>>> the interrupt line
>>> - Eth switch: need tweaks in i.MX RGMII pin group control registers
>>> - audio codec: no existing driver yet (in mainline)
>>>
>>> So expect patches targeting the mentioned issues and updates to the dts
>>> files enabling additional HW.
>>>
>>> CC-ing Andrew since he was interested in this board as it has a DSA
>>> Ethernet switch populated.
>>>
>>> Thanks,
>>> Michal
>>>
>>> arch/arm/boot/dts/Makefile | 3 +
>>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 535 +++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/imx6dl-yapp4-draco.dts | 57 +++
>>> arch/arm/boot/dts/imx6dl-yapp4-hydra.dts | 33 ++
>>> arch/arm/boot/dts/imx6dl-yapp4-ursa.dts | 53 +++
>>> 5 files changed, 681 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index b5bd3de..cf24410 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -441,6 +441,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>> imx6dl-wandboard.dtb \
>>> imx6dl-wandboard-revb1.dtb \
>>> imx6dl-wandboard-revd1.dtb \
>>> + imx6dl-yapp4-draco.dtb \
>>> + imx6dl-yapp4-hydra.dtb \
>>> + imx6dl-yapp4-ursa.dtb \
>>> imx6q-apalis-eval.dtb \
>>> imx6q-apalis-ixora.dtb \
>>> imx6q-apalis-ixora-v1.1.dtb \
>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>> new file mode 100644
>>> index 0000000..9925523
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>> @@ -0,0 +1,535 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/pwm/pwm.h>
>>> +
>>> +/ {
>>> + backlight: backlight {
>>> + compatible = "pwm-backlight";
>>> + pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>;
>>> + brightness-levels = <0 32 64 128 255>;
>>> + default-brightness-level = <32>;
>>> + num-interpolated-steps = <8>;
>>> + power-supply = <&sw2_reg>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + lcd_display: display {
>>> + compatible = "fsl,imx-parallel-display";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + interface-pix-fmt = "rgb24";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_ipu1>;
>>> + status = "disabled";
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> +
>>> + lcd_display_in: endpoint {
>>> + remote-endpoint = <&ipu1_di0_disp0>;
>>> + };
>>> + };
>>> +
>>> + port@1 {
>>> + reg = <1>;
>>> +
>>> + lcd_display_out: endpoint {
>>> + remote-endpoint = <&lcd_panel_in>;
>>> + };
>>> + };
>>> + };
>>> +
>>> + panel: panel {
>>> + compatible = "dataimage,scf0700c48ggu18";
>>> + power-supply = <&sw2_reg>;
>>> + status = "disabled";
>>> +
>>> + port {
>>> + lcd_panel_in: endpoint {
>>> + remote-endpoint = <&lcd_display_out>;
>>> + };
>>> + };
>>> + };
>>> +
>>> + regulators {
>>> + compatible = "simple-bus";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>
>> These are all just individual board level regulators? If so, drop the
>> simple-bus and move these up to the top-level.
>
> Yes, individual regulators. I will move it.
>
>>> +
>>> + reg_usb_otg_vbus: regulator@0 {
>>> + compatible = "regulator-fixed";
>>> + reg = <0>;
>>
>> Dropping reg and unit-address in the process.
>
> OK, I will remove it.
>
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usbotg_vbus>;
>>> + regulator-name = "usb_otg_vbus";
>>> + regulator-min-microvolt = <5000000>;
>>> + regulator-max-microvolt = <5000000>;
>>> + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>> + status = "okay";
>>> + };
>>> +
>>> + reg_usb_h1_vbus: regulator@1 {
>>> + compatible = "regulator-fixed";
>>> + reg = <1>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usbh1_vbus>;
>>> + regulator-name = "usb_h1_vbus";
>>> + regulator-min-microvolt = <5000000>;
>>> + regulator-max-microvolt = <5000000>;
>>> + gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>> + status = "disabled";
>>> + };
>>> +
>>> + reg_pcie: regulator@2 {
>>> + compatible = "regulator-fixed";
>>> + reg = <2>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_pcie_reg>;
>>> + regulator-name = "MPCIE_3V3";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>> + status = "disabled";
>>> + };
>>> + };
>>> +};
>>> +
>>> +&fec {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_enet>;
>>> + phy-mode = "rgmii-id";
>>> + phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
>>> + phy-reset-duration = <20>;
>>> + phy-supply = <&sw2_reg>;
>>> + phy-handle = <ðphy0>;
>>> + status = "okay";
>>> +
>>> + mdio {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + phy_port2: phy@1 {
>>> + reg = <1>;
>>> + };
>>> +
>>> + phy_port3: phy@2 {
>>> + reg = <2>;
>>> + };
>>> +
>>> + switch@0 {
>>> + compatible = "qca,qca8334";
>>> + reg = <0>;
>>> +
>>> + switch_ports: ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + ethphy0: port@0 {
>>> + reg = <0>;
>>> + label = "cpu";
>>> + phy-mode = "rgmii";
>>> + ethernet = <&fec>;
>>> + fixed-link {
>>> + speed = <1000>;
>>> + full-duplex;
>>> + };
>>> + };
>>> +
>>> + port@2 {
>>> + reg = <2>;
>>> + label = "eth2";
>>> + phy-handle = <&phy_port2>;
>>> + };
>>> +
>>> + port@3 {
>>> + reg = <3>;
>>> + label = "eth1";
>>> + phy-handle = <&phy_port3>;
>>> + };
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&i2c2 {
>>> + clock-frequency = <100000>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_i2c2>;
>>> + status = "okay";
>>> +
>>> + eeprom@57 {
>>> + compatible = "atmel,24c128";
>>> + reg = <0x57>;
>>> + pagesize = <64>;
>>> + status = "okay";
>>> + };
>>> +
>>> + leds: leds@30 {
>>
>> led-controller@...
>
> OK.
>
>>> + compatible = "ti,lp5562";
>>> + label = "lp5562_leds";
>>> + reg = <0x30>;
>>> + clock-mode = /bits/ 8 <1>;
>>> + status = "disabled";
>>
>> Kind of strange to have these disables. I think disabled should mean
>> present in the h/w, but not used/enabled. Either this should be present
>> on all boards and enabled or be moved to the per board dts.
>
> Parts that are populated on all boards are enabled here. Parts that are
> populated only on some subset are disabled here and enabled in their
> appropriate dts files. I took this approach to avoid duplication and to
> make the maintenance easier.
>
> My rough guess is that at least 50% of the device nodes would be removed
> from this common file and put into each of the board files.
>
> Sure I can do it but it seems very prone to mistakes to me.
Hi Rob, gentle ping on this.
I would like to be sure how to proceed with this. Do you really want me
to move *all* nodes that are disabled in this common dtsi into the per
board dts?
All the boards use identical PCB. Anything that is disabled here is not
present on at least one of the boards. It means it is routed on the
board and the SoC has the capability but the parts are not populated.
So it is not only about the LED controller. What about the LCD, OLED,
backlight, USB..?
Thank you,
Michal
>>> +
>>> + chan0 {
>>> + chan-name = "R";
>>> + led-cur = /bits/ 8 <0x20>;
>>> + max-cur = /bits/ 8 <0x60>;
>>> + };
>>> +
>>> + chan1 {
>>> + chan-name = "G";
>>> + led-cur = /bits/ 8 <0x20>;
>>> + max-cur = /bits/ 8 <0x60>;
>>> + };
>>> +
>>> + chan2 {
>>> + chan-name = "B";
>>> + led-cur = /bits/ 8 <0x20>;
>>> + max-cur = /bits/ 8 <0x60>;
>>> + };
>>> +
>>> + chan3 {
>>> + chan-name = "W";
>>> + led-cur = /bits/ 8 <0x0>;
>>> + max-cur = /bits/ 8 <0x0>;
>>> + };
>>> + };
>>> +
>>> + pfuze200@8 {
>>
>> pmic@8
>
> OK.
>
>>> + compatible = "fsl,pfuze200";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_pmic>;
>>> + reg = <0x8>;
>>> +
>>> + regulators {
>>> + sw1a_reg: sw1ab {
>>> + regulator-min-microvolt = <300000>;
>>> + regulator-max-microvolt = <1875000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + regulator-ramp-delay = <6250>;
>>> + };
>>> +
>>> + sw2_reg: sw2 {
>>> + regulator-min-microvolt = <800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + sw3a_reg: sw3a {
>>> + regulator-min-microvolt = <400000>;
>>> + regulator-max-microvolt = <1975000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + sw3b_reg: sw3b {
>>> + regulator-min-microvolt = <400000>;
>>> + regulator-max-microvolt = <1975000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + swbst_reg: swbst {
>>> + regulator-min-microvolt = <5000000>;
>>> + regulator-max-microvolt = <5150000>;
>>> + };
>>> +
>>> + snvs_reg: vsnvs {
>>> + regulator-min-microvolt = <1000000>;
>>> + regulator-max-microvolt = <3000000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vref_reg: vrefddr {
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vgen1_reg: vgen1 {
>>> + regulator-min-microvolt = <800000>;
>>> + regulator-max-microvolt = <1550000>;
>>> + };
>>> +
>>> + vgen2_reg: vgen2 {
>>> + regulator-min-microvolt = <800000>;
>>> + regulator-max-microvolt = <1550000>;
>>> + };
>>> +
>>> + vgen3_reg: vgen3 {
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vgen4_reg: vgen4 {
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vgen5_reg: vgen5 {
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vgen6_reg: vgen6 {
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-always-on;
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&iomuxc {
>>> + pinctrl_enet: enetgrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1B020
>>> + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1B020
>>> + MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1B020
>>> + MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1B020
>>> + MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1B020
>>> + MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1B020
>>> + MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1B020
>>> + MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1B020
>>> + MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1B020
>>> + MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1B020
>>> + MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1B020
>>> + MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1B020
>>> + MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1B020
>>> + MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1B020
>>> + MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1B010
>>> + MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1B010
>>> + MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1B098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_i2c2: i2c2grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b899
>>> + MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b899
>>> + >;
>>> + };
>>> +
>>> + pinctrl_ipu1: ipu1grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10
>>> + MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
>>> + MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
>>> + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x10
>>> + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x10
>>> + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x10
>>> + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0x10
>>> + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0x10
>>> + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0x10
>>> + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0x10
>>> + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0x10
>>> + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0x10
>>> + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0x10
>>> + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0x10
>>> + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0x10
>>> + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0x10
>>> + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0x10
>>> + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0x10
>>> + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0x10
>>> + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0x10
>>> + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0x10
>>> + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0x10
>>> + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0x10
>>> + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0x10
>>> + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0x10
>>> + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0x10
>>> + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0x10
>>> + >;
>>> + };
>>> +
>>> + pinctrl_pcie: pciegrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b098
>>> + MX6QDL_PAD_KEY_COL4__GPIO4_IO14 0x1b098
>>> + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_pcie_reg: pciereggrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x1b098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_pmic: pmicgrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_backlight_pwm: pwm1grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x8
>>> + >;
>>> + };
>>> +
>>> + pinctrl_uart1: uart1grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0a8
>>> + MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0a8
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usbh1: usbh1grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_EIM_D30__USB_H1_OC 0x1b098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usbh1_vbus: usbh1-vbus {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x98
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usbotg: usbotggrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1b098
>>> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b098
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usbotg_vbus: usbotg-vbus {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x98
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usdhc3: usdhc3grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x1b018
>>> + MX6QDL_PAD_SD3_RST__GPIO7_IO08 0x1b018
>>> + MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
>>> + MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10059
>>> + MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17059
>>> + MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17059
>>> + MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17059
>>> + MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usdhc4: usdhc4grp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_SD4_CMD__SD4_CMD 0x1f069
>>> + MX6QDL_PAD_SD4_CLK__SD4_CLK 0x10069
>>> + MX6QDL_PAD_SD4_DAT0__SD4_DATA0 0x17069
>>> + MX6QDL_PAD_SD4_DAT1__SD4_DATA1 0x17069
>>> + MX6QDL_PAD_SD4_DAT2__SD4_DATA2 0x17069
>>> + MX6QDL_PAD_SD4_DAT3__SD4_DATA3 0x17069
>>> + MX6QDL_PAD_SD4_DAT4__SD4_DATA4 0x17069
>>> + MX6QDL_PAD_SD4_DAT5__SD4_DATA5 0x17069
>>> + MX6QDL_PAD_SD4_DAT6__SD4_DATA6 0x17069
>>> + MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17069
>>> + >;
>>> + };
>>> +
>>> + pinctrl_wdog: wdoggrp {
>>> + fsl,pins = <
>>> + MX6QDL_PAD_GPIO_1__WDOG2_B 0x1b0b0
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&ipu1_di0_disp0 {
>>> + remote-endpoint = <&lcd_display_in>;
>>> +};
>>> +
>>> +&pcie {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_pcie>;
>>> + reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
>>> + vpcie-supply = <®_pcie>;
>>> + status = "disabled";
>>> +};
>>> +
>>> +&pwm1 {
>>> + #pwm-cells = <3>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_backlight_pwm>;
>>> + status = "disabled";
>>> +};
>>> +
>>> +&uart1 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_uart1>;
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbh1 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usbh1>;
>>> + vbus-supply = <®_usb_h1_vbus>;
>>> + status = "disabled";
>>> +};
>>> +
>>> +&usbotg {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usbotg>;
>>> + vbus-supply = <®_usb_otg_vbus>;
>>> + srp-disable;
>>> + hnp-disable;
>>> + adp-disable;
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbphy1 {
>>> + fsl,tx-d-cal = <106>;
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbphy2 {
>>> + fsl,tx-d-cal = <109>;
>>> + status = "disabled";
>>> +};
>>> +
>>> +&usdhc3 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usdhc3>;
>>> + bus-width = <4>;
>>> + cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
>>> + wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
>>> + no-1-8-v;
>>> + keep-power-in-suspend;
>>> + enable-sdio-wakeup;
>>> + vmmc-supply = <&sw2_reg>;
>>> + status = "disabled";
>>> +};
>>> +
>>> +&usdhc4 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_usdhc4>;
>>> + bus-width = <8>;
>>> + non-removable;
>>> + no-1-8-v;
>>> + keep-power-in-suspend;
>>> + vmmc-supply = <&sw2_reg>;
>>> + status = "okay";
>>> +};
>>> +
>>> +&wdog1 {
>>> + status = "disabled";
>>> +};
>>> +
>>> +&wdog2 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_wdog>;
>>> + fsl,ext-reset-output;
>>> + status = "okay";
>>> +};
>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-draco.dts b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>> new file mode 100644
>>> index 0000000..fb62f31
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>> @@ -0,0 +1,57 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6dl.dtsi"
>>> +#include "imx6dl-yapp4-common.dtsi"
>>> +
>>> +/ {
>>> + model = "Y Soft IOTA Draco i.MX6Solo board";
>>> + compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
>>
>> Is this documented?
>
> Just the vendor prefix, not the board names. If I am supposed to add
> those as well I would appreciate a hint what is the correct place to
> add it. My impression is that only evaluation boards from SoC vendors
> are documented
Ping. There is a lot of boards from various vendors that are not
documented. That does not mean it is correct of course. So I think
"Documentation/devicetree/bindings/arm/ysoft.txt" is the way to go?
Also the format of those files does not seem really standardized. Can
you pick one of them as a good example, please?
Thank you,
Michal
>>> +
>>> + cpus {
>>> + /delete-node/ cpu@1;
>>> + };
>>> +
>>> + memory@10000000 {
>>> + reg = <0x10000000 0x20000000>;
>>> + };
>>> +};
>>> +
>>> +&backlight {
>>> + status = "okay";
>>> +};
>>> +
>>> +&lcd_display {
>>> + status = "okay";
>>> +};
>>> +
>>> +&leds {
>>> + status = "okay";
>>> +};
>>> +
>>> +&panel {
>>> + status = "okay";
>>> +};
>>> +
>>> +&pwm1 {
>>> + status = "okay";
>>> +};
>>> +
>>> +®_usb_h1_vbus {
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbh1 {
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbphy2 {
>>> + status = "okay";
>>> +};
>>> +
>>> +&usdhc3 {
>>> + status = "okay";
>>> +};
>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>> new file mode 100644
>>> index 0000000..799fb4c
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>> @@ -0,0 +1,33 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6dl.dtsi"
>>> +#include "imx6dl-yapp4-common.dtsi"
>>> +
>>> +/ {
>>> + model = "Y Soft IOTA Hydra i.MX6DualLite board";
>>> + compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
>>> +
>>> + memory@10000000 {
>>> + reg = <0x10000000 0x80000000>;
>>> + };
>>> +};
>>> +
>>> +&leds {
>>> + status = "okay";
>>> +};
>>> +
>>> +&pcie {
>>> + status = "okay";
>>> +};
>>> +
>>> +®_pcie {
>>> + status = "okay";
>>> +};
>>> +
>>> +&usdhc3 {
>>> + status = "okay";
>>> +};
>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>> new file mode 100644
>>> index 0000000..23af972
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>> @@ -0,0 +1,53 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6dl.dtsi"
>>> +#include "imx6dl-yapp4-common.dtsi"
>>> +
>>> +/ {
>>> + model = "Y Soft IOTA Ursa i.MX6Solo board";
>>> + compatible = "ysoft,imx6dl-yapp4-ursa", "fsl,imx6dl";
>>> +
>>> + cpus {
>>> + /delete-node/ cpu@1;
>>> + };
>>> +
>>> + memory@10000000 {
>>> + reg = <0x10000000 0x20000000>;
>>> + };
>>> +};
>>> +
>>> +&backlight {
>>> + status = "okay";
>>> +};
>>> +
>>> +&lcd_display {
>>> + status = "okay";
>>> +};
>>> +
>>> +&panel {
>>> + status = "okay";
>>> +};
>>> +
>>> +&pwm1 {
>>> + status = "okay";
>>> +};
>>> +
>>> +®_usb_h1_vbus {
>>> + status = "okay";
>>> +};
>>> +
>>> +&switch_ports {
>>> + /delete-node/ port@2;
>>> +};
>>> +
>>> +&usbh1 {
>>> + status = "okay";
>>> +};
>>> +
>>> +&usbphy2 {
>>> + status = "okay";
>>> +};
>>> --
>>> 2.1.4
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-11-01 15:43 [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards Vokáč Michal
[not found] ` <5bea0e99.1c69fb81.18be0.5162@mx.google.com>
@ 2018-11-28 2:39 ` Shawn Guo
2018-11-28 8:23 ` Vokáč Michal
1 sibling, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2018-11-28 2:39 UTC (permalink / raw)
To: Vokáč Michal
Cc: Rob Herring, Fabio Estevam, Mark Rutland, devicetree,
Andrew Lunn, Sascha Hauer, linux-kernel, NXP Linux Team,
linux-arm-kernel
On Thu, Nov 01, 2018 at 03:43:26PM +0000, Vokáč Michal wrote:
...
> +&usdhc3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc3>;
> + bus-width = <4>;
> + cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
> + wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
> + no-1-8-v;
> + keep-power-in-suspend;
> + enable-sdio-wakeup;
This property is deprecated. Please use "wakeup-source" instead.
Shawn
> + vmmc-supply = <&sw2_reg>;
> + status = "disabled";
> +};
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-11-28 2:39 ` Shawn Guo
@ 2018-11-28 8:23 ` Vokáč Michal
0 siblings, 0 replies; 8+ messages in thread
From: Vokáč Michal @ 2018-11-28 8:23 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Fabio Estevam, Mark Rutland, devicetree,
Andrew Lunn, Sascha Hauer, linux-kernel, NXP Linux Team,
linux-arm-kernel
On 28.11.2018 03:39, Shawn Guo wrote:
> On Thu, Nov 01, 2018 at 03:43:26PM +0000, Vokáč Michal wrote:
> ...
>> +&usdhc3 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_usdhc3>;
>> + bus-width = <4>;
>> + cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
>> + wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
>> + no-1-8-v;
>> + keep-power-in-suspend;
>> + enable-sdio-wakeup;
>
> This property is deprecated. Please use "wakeup-source" instead.
OK, I will fix that. Thanks for the heads up.
Michal
>> + vmmc-supply = <&sw2_reg>;
>> + status = "disabled";
>> +};
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-11-27 12:19 ` Vokáč Michal
@ 2018-12-11 9:27 ` Vokáč Michal
2018-12-11 12:36 ` Andrew Lunn
0 siblings, 1 reply; 8+ messages in thread
From: Vokáč Michal @ 2018-12-11 9:27 UTC (permalink / raw)
To: Rob Herring
Cc: Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
devicetree, Sascha Hauer, Shawn Guo, Mark Rutland, Andrew Lunn
On 27.11.2018 13:19, Vokáč Michal wrote:
> On 19.11.2018 15:35, Vokáč Michal wrote:
>> On 12.11.2018 17:41, Rob Herring wrote:
>>> On Thu, Nov 01, 2018 at 03:43:26PM +0000, Vokáč Michal wrote:
>>>> These are i.MX6S/DL based SBCs embedded in various Y Soft products.
>>>> All share the same board design but have slightly different HW
>>>> configuration.
>>>>
>>>> Ursa
>>>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>>>> - parallel WVGA 7" LCD with touch panel
>>>> - 1x Eth (QCA8334 switch)
>>>> - USB OTG
>>>> - USB host (micro-B)
>>>>
>>>> Draco
>>>> - i.MX6S SoC, 512MB RAM DDR3, 4GB eMMC, microSD
>>>> - parallel WVGA 7" LCD with touch panel
>>>> - 2x Eth (QCA8334 switch)
>>>> - USB OTG
>>>> - USB host (micro-B)
>>>> - RGB LED (I2C LP5562)
>>>> - 3.5mm audio jack + codec (LM49350)
>>>>
>>>> Hydra
>>>> - i.MX6DL SoC, 2GB RAM DDR3, 4GB eMMC, microSD
>>>> - I2C OLED display, capacitive matrix keys
>>>> - 2x Eth (QCA8334 switch)
>>>> - USB OTG
>>>> - RGB LED (I2C LP5562)
>>>> - 3.5mm audio jack + codec (LM49350)
>>>> - HDMI
>>>> - miniPCIe slot
>>>>
>>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>>>> ---
>>>>
>>>> All the boards are booting fine but not everything is enabled/supported
>>>> yet though. There is few things that will need some effort to get them
>>>> fully working.
>>>>
>>>> - HDMI: nothing specific, it just does not have the priority
>>>> - OLED display: reset signal inversion, wrong display resolution,...
>>>> - capacitive keys: polled driver for MPR121 needed as we do not have
>>>> the interrupt line
>>>> - Eth switch: need tweaks in i.MX RGMII pin group control registers
>>>> - audio codec: no existing driver yet (in mainline)
>>>>
>>>> So expect patches targeting the mentioned issues and updates to the dts
>>>> files enabling additional HW.
>>>>
>>>> CC-ing Andrew since he was interested in this board as it has a DSA
>>>> Ethernet switch populated.
>>>>
>>>> Thanks,
>>>> Michal
>>>>
>>>> arch/arm/boot/dts/Makefile | 3 +
>>>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 535 +++++++++++++++++++++++++++++
>>>> arch/arm/boot/dts/imx6dl-yapp4-draco.dts | 57 +++
>>>> arch/arm/boot/dts/imx6dl-yapp4-hydra.dts | 33 ++
>>>> arch/arm/boot/dts/imx6dl-yapp4-ursa.dts | 53 +++
>>>> 5 files changed, 681 insertions(+)
>>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>>> create mode 100644 arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>>>
>>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>>> index b5bd3de..cf24410 100644
>>>> --- a/arch/arm/boot/dts/Makefile
>>>> +++ b/arch/arm/boot/dts/Makefile
>>>> @@ -441,6 +441,9 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>>> imx6dl-wandboard.dtb \
>>>> imx6dl-wandboard-revb1.dtb \
>>>> imx6dl-wandboard-revd1.dtb \
>>>> + imx6dl-yapp4-draco.dtb \
>>>> + imx6dl-yapp4-hydra.dtb \
>>>> + imx6dl-yapp4-ursa.dtb \
>>>> imx6q-apalis-eval.dtb \
>>>> imx6q-apalis-ixora.dtb \
>>>> imx6q-apalis-ixora-v1.1.dtb \
>>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>>> new file mode 100644
>>>> index 0000000..9925523
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>>>> @@ -0,0 +1,535 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +//
>>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>>> +
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +#include <dt-bindings/pwm/pwm.h>
>>>> +
>>>> +/ {
>>>> + backlight: backlight {
>>>> + compatible = "pwm-backlight";
>>>> + pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>;
>>>> + brightness-levels = <0 32 64 128 255>;
>>>> + default-brightness-level = <32>;
>>>> + num-interpolated-steps = <8>;
>>>> + power-supply = <&sw2_reg>;
>>>> + status = "disabled";
>>>> + };
>>>> +
>>>> + lcd_display: display {
>>>> + compatible = "fsl,imx-parallel-display";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> + interface-pix-fmt = "rgb24";
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_ipu1>;
>>>> + status = "disabled";
>>>> +
>>>> + port@0 {
>>>> + reg = <0>;
>>>> +
>>>> + lcd_display_in: endpoint {
>>>> + remote-endpoint = <&ipu1_di0_disp0>;
>>>> + };
>>>> + };
>>>> +
>>>> + port@1 {
>>>> + reg = <1>;
>>>> +
>>>> + lcd_display_out: endpoint {
>>>> + remote-endpoint = <&lcd_panel_in>;
>>>> + };
>>>> + };
>>>> + };
>>>> +
>>>> + panel: panel {
>>>> + compatible = "dataimage,scf0700c48ggu18";
>>>> + power-supply = <&sw2_reg>;
>>>> + status = "disabled";
>>>> +
>>>> + port {
>>>> + lcd_panel_in: endpoint {
>>>> + remote-endpoint = <&lcd_display_out>;
>>>> + };
>>>> + };
>>>> + };
>>>> +
>>>> + regulators {
>>>> + compatible = "simple-bus";
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>
>>> These are all just individual board level regulators? If so, drop the
>>> simple-bus and move these up to the top-level.
>>
>> Yes, individual regulators. I will move it.
>>
>>>> +
>>>> + reg_usb_otg_vbus: regulator@0 {
>>>> + compatible = "regulator-fixed";
>>>> + reg = <0>;
>>>
>>> Dropping reg and unit-address in the process.
>>
>> OK, I will remove it.
>>
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usbotg_vbus>;
>>>> + regulator-name = "usb_otg_vbus";
>>>> + regulator-min-microvolt = <5000000>;
>>>> + regulator-max-microvolt = <5000000>;
>>>> + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>>> + enable-active-high;
>>>> + status = "okay";
>>>> + };
>>>> +
>>>> + reg_usb_h1_vbus: regulator@1 {
>>>> + compatible = "regulator-fixed";
>>>> + reg = <1>;
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usbh1_vbus>;
>>>> + regulator-name = "usb_h1_vbus";
>>>> + regulator-min-microvolt = <5000000>;
>>>> + regulator-max-microvolt = <5000000>;
>>>> + gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
>>>> + enable-active-high;
>>>> + status = "disabled";
>>>> + };
>>>> +
>>>> + reg_pcie: regulator@2 {
>>>> + compatible = "regulator-fixed";
>>>> + reg = <2>;
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_pcie_reg>;
>>>> + regulator-name = "MPCIE_3V3";
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
>>>> + enable-active-high;
>>>> + status = "disabled";
>>>> + };
>>>> + };
>>>> +};
>>>> +
>>>> +&fec {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_enet>;
>>>> + phy-mode = "rgmii-id";
>>>> + phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
>>>> + phy-reset-duration = <20>;
>>>> + phy-supply = <&sw2_reg>;
>>>> + phy-handle = <ðphy0>;
>>>> + status = "okay";
>>>> +
>>>> + mdio {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + phy_port2: phy@1 {
>>>> + reg = <1>;
>>>> + };
>>>> +
>>>> + phy_port3: phy@2 {
>>>> + reg = <2>;
>>>> + };
>>>> +
>>>> + switch@0 {
>>>> + compatible = "qca,qca8334";
>>>> + reg = <0>;
>>>> +
>>>> + switch_ports: ports {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + ethphy0: port@0 {
>>>> + reg = <0>;
>>>> + label = "cpu";
>>>> + phy-mode = "rgmii";
>>>> + ethernet = <&fec>;
>>>> + fixed-link {
>>>> + speed = <1000>;
>>>> + full-duplex;
>>>> + };
>>>> + };
>>>> +
>>>> + port@2 {
>>>> + reg = <2>;
>>>> + label = "eth2";
>>>> + phy-handle = <&phy_port2>;
>>>> + };
>>>> +
>>>> + port@3 {
>>>> + reg = <3>;
>>>> + label = "eth1";
>>>> + phy-handle = <&phy_port3>;
>>>> + };
>>>> + };
>>>> + };
>>>> + };
>>>> +};
>>>> +
>>>> +&i2c2 {
>>>> + clock-frequency = <100000>;
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_i2c2>;
>>>> + status = "okay";
>>>> +
>>>> + eeprom@57 {
>>>> + compatible = "atmel,24c128";
>>>> + reg = <0x57>;
>>>> + pagesize = <64>;
>>>> + status = "okay";
>>>> + };
>>>> +
>>>> + leds: leds@30 {
>>>
>>> led-controller@...
>>
>> OK.
>>
>>>> + compatible = "ti,lp5562";
>>>> + label = "lp5562_leds";
>>>> + reg = <0x30>;
>>>> + clock-mode = /bits/ 8 <1>;
>>>> + status = "disabled";
>>>
>>> Kind of strange to have these disables. I think disabled should mean
>>> present in the h/w, but not used/enabled. Either this should be present
>>> on all boards and enabled or be moved to the per board dts.
>>
>> Parts that are populated on all boards are enabled here. Parts that are
>> populated only on some subset are disabled here and enabled in their
>> appropriate dts files. I took this approach to avoid duplication and to
>> make the maintenance easier.
>>
>> My rough guess is that at least 50% of the device nodes would be removed
>> from this common file and put into each of the board files.
>>
>> Sure I can do it but it seems very prone to mistakes to me.
>
> Hi Rob, gentle ping on this.
>
> I would like to be sure how to proceed with this. Do you really want me
> to move *all* nodes that are disabled in this common dtsi into the per
> board dts?
>
> All the boards use identical PCB. Anything that is disabled here is not
> present on at least one of the boards. It means it is routed on the
> board and the SoC has the capability but the parts are not populated.
>
> So it is not only about the LED controller. What about the LCD, OLED,
> backlight, USB..?
Can anybody advice how to split these dts/dtsi files, please?
I am not sure what should reside in the common dtsi and what should
be moved into the per board dts in case my current solution is not
appropriate.
I could not find a good example among the in-tree DT files. The most
similar examples are either SBCs of the same form factor, yet different
PCB design (e.g. BeagleBone Black, Blue, Green) or COMs + base boards.
One possible option is to make the split at the SoC level. Everything
that is populated on all three boards would of course be part of the
common dtsi. Everything that is part of the SoC would also be part of
the common dtsi even if it is not used on all boards. And so marked
disabled.
E.g. PWM is used on two of the three boards for backlight. I would
specify the PWM in common dtsi including it's iomuxing. The backlight
would be specified in the per board dts as it requires additional IC
as well as the LCD panel itself. The iomuxing for the panel would be
part of the per board dts.
What about USB? The PHY is part of the SoC but it requires a connector
and a regulator that are populated only on some boards, etc.
Thank you,
Michal
>>>> +
>>>> + chan0 {
>>>> + chan-name = "R";
>>>> + led-cur = /bits/ 8 <0x20>;
>>>> + max-cur = /bits/ 8 <0x60>;
>>>> + };
>>>> +
>>>> + chan1 {
>>>> + chan-name = "G";
>>>> + led-cur = /bits/ 8 <0x20>;
>>>> + max-cur = /bits/ 8 <0x60>;
>>>> + };
>>>> +
>>>> + chan2 {
>>>> + chan-name = "B";
>>>> + led-cur = /bits/ 8 <0x20>;
>>>> + max-cur = /bits/ 8 <0x60>;
>>>> + };
>>>> +
>>>> + chan3 {
>>>> + chan-name = "W";
>>>> + led-cur = /bits/ 8 <0x0>;
>>>> + max-cur = /bits/ 8 <0x0>;
>>>> + };
>>>> + };
>>>> +
>>>> + pfuze200@8 {
>>>
>>> pmic@8
>>
>> OK.
>>
>>>> + compatible = "fsl,pfuze200";
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_pmic>;
>>>> + reg = <0x8>;
>>>> +
>>>> + regulators {
>>>> + sw1a_reg: sw1ab {
>>>> + regulator-min-microvolt = <300000>;
>>>> + regulator-max-microvolt = <1875000>;
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + regulator-ramp-delay = <6250>;
>>>> + };
>>>> +
>>>> + sw2_reg: sw2 {
>>>> + regulator-min-microvolt = <800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + sw3a_reg: sw3a {
>>>> + regulator-min-microvolt = <400000>;
>>>> + regulator-max-microvolt = <1975000>;
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + sw3b_reg: sw3b {
>>>> + regulator-min-microvolt = <400000>;
>>>> + regulator-max-microvolt = <1975000>;
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + swbst_reg: swbst {
>>>> + regulator-min-microvolt = <5000000>;
>>>> + regulator-max-microvolt = <5150000>;
>>>> + };
>>>> +
>>>> + snvs_reg: vsnvs {
>>>> + regulator-min-microvolt = <1000000>;
>>>> + regulator-max-microvolt = <3000000>;
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + vref_reg: vrefddr {
>>>> + regulator-boot-on;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + vgen1_reg: vgen1 {
>>>> + regulator-min-microvolt = <800000>;
>>>> + regulator-max-microvolt = <1550000>;
>>>> + };
>>>> +
>>>> + vgen2_reg: vgen2 {
>>>> + regulator-min-microvolt = <800000>;
>>>> + regulator-max-microvolt = <1550000>;
>>>> + };
>>>> +
>>>> + vgen3_reg: vgen3 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + vgen4_reg: vgen4 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + vgen5_reg: vgen5 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-always-on;
>>>> + };
>>>> +
>>>> + vgen6_reg: vgen6 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-always-on;
>>>> + };
>>>> + };
>>>> + };
>>>> +};
>>>> +
>>>> +&iomuxc {
>>>> + pinctrl_enet: enetgrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x1B020
>>>> + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x1B020
>>>> + MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x1B020
>>>> + MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x1B020
>>>> + MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x1B020
>>>> + MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x1B020
>>>> + MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x1B020
>>>> + MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x1B020
>>>> + MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1B020
>>>> + MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1B020
>>>> + MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1B020
>>>> + MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1B020
>>>> + MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1B020
>>>> + MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1B020
>>>> + MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x1B010
>>>> + MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1B010
>>>> + MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1B098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_i2c2: i2c2grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b899
>>>> + MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b899
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_ipu1: ipu1grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10
>>>> + MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
>>>> + MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
>>>> + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0x10
>>>> + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0x10
>>>> + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0x10
>>>> + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0x10
>>>> + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0x10
>>>> + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0x10
>>>> + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0x10
>>>> + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0x10
>>>> + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0x10
>>>> + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0x10
>>>> + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0x10
>>>> + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0x10
>>>> + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0x10
>>>> + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0x10
>>>> + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0x10
>>>> + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0x10
>>>> + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0x10
>>>> + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0x10
>>>> + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0x10
>>>> + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0x10
>>>> + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0x10
>>>> + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0x10
>>>> + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0x10
>>>> + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0x10
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_pcie: pciegrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b098
>>>> + MX6QDL_PAD_KEY_COL4__GPIO4_IO14 0x1b098
>>>> + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_pcie_reg: pciereggrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x1b098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_pmic: pmicgrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_backlight_pwm: pwm1grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x8
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_uart1: uart1grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0a8
>>>> + MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0a8
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usbh1: usbh1grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_EIM_D30__USB_H1_OC 0x1b098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usbh1_vbus: usbh1-vbus {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x98
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usbotg: usbotggrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1b098
>>>> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b098
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usbotg_vbus: usbotg-vbus {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x98
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usdhc3: usdhc3grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_EIM_A16__GPIO2_IO22 0x1b018
>>>> + MX6QDL_PAD_SD3_RST__GPIO7_IO08 0x1b018
>>>> + MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
>>>> + MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10059
>>>> + MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17059
>>>> + MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17059
>>>> + MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17059
>>>> + MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_usdhc4: usdhc4grp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_SD4_CMD__SD4_CMD 0x1f069
>>>> + MX6QDL_PAD_SD4_CLK__SD4_CLK 0x10069
>>>> + MX6QDL_PAD_SD4_DAT0__SD4_DATA0 0x17069
>>>> + MX6QDL_PAD_SD4_DAT1__SD4_DATA1 0x17069
>>>> + MX6QDL_PAD_SD4_DAT2__SD4_DATA2 0x17069
>>>> + MX6QDL_PAD_SD4_DAT3__SD4_DATA3 0x17069
>>>> + MX6QDL_PAD_SD4_DAT4__SD4_DATA4 0x17069
>>>> + MX6QDL_PAD_SD4_DAT5__SD4_DATA5 0x17069
>>>> + MX6QDL_PAD_SD4_DAT6__SD4_DATA6 0x17069
>>>> + MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17069
>>>> + >;
>>>> + };
>>>> +
>>>> + pinctrl_wdog: wdoggrp {
>>>> + fsl,pins = <
>>>> + MX6QDL_PAD_GPIO_1__WDOG2_B 0x1b0b0
>>>> + >;
>>>> + };
>>>> +};
>>>> +
>>>> +&ipu1_di0_disp0 {
>>>> + remote-endpoint = <&lcd_display_in>;
>>>> +};
>>>> +
>>>> +&pcie {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_pcie>;
>>>> + reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
>>>> + vpcie-supply = <®_pcie>;
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&pwm1 {
>>>> + #pwm-cells = <3>;
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_backlight_pwm>;
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&uart1 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_uart1>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbh1 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usbh1>;
>>>> + vbus-supply = <®_usb_h1_vbus>;
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&usbotg {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usbotg>;
>>>> + vbus-supply = <®_usb_otg_vbus>;
>>>> + srp-disable;
>>>> + hnp-disable;
>>>> + adp-disable;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbphy1 {
>>>> + fsl,tx-d-cal = <106>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbphy2 {
>>>> + fsl,tx-d-cal = <109>;
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&usdhc3 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usdhc3>;
>>>> + bus-width = <4>;
>>>> + cd-gpios = <&gpio7 8 GPIO_ACTIVE_LOW>;
>>>> + wp-gpios = <&gpio2 22 GPIO_ACTIVE_HIGH>;
>>>> + no-1-8-v;
>>>> + keep-power-in-suspend;
>>>> + enable-sdio-wakeup;
>>>> + vmmc-supply = <&sw2_reg>;
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&usdhc4 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_usdhc4>;
>>>> + bus-width = <8>;
>>>> + non-removable;
>>>> + no-1-8-v;
>>>> + keep-power-in-suspend;
>>>> + vmmc-supply = <&sw2_reg>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&wdog1 {
>>>> + status = "disabled";
>>>> +};
>>>> +
>>>> +&wdog2 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pinctrl_wdog>;
>>>> + fsl,ext-reset-output;
>>>> + status = "okay";
>>>> +};
>>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-draco.dts b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>>> new file mode 100644
>>>> index 0000000..fb62f31
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-draco.dts
>>>> @@ -0,0 +1,57 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +//
>>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "imx6dl.dtsi"
>>>> +#include "imx6dl-yapp4-common.dtsi"
>>>> +
>>>> +/ {
>>>> + model = "Y Soft IOTA Draco i.MX6Solo board";
>>>> + compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
>>>
>>> Is this documented?
>>
>> Just the vendor prefix, not the board names. If I am supposed to add
>> those as well I would appreciate a hint what is the correct place to
>> add it. My impression is that only evaluation boards from SoC vendors
>> are documented
>
> Ping. There is a lot of boards from various vendors that are not
> documented. That does not mean it is correct of course. So I think
> "Documentation/devicetree/bindings/arm/ysoft.txt" is the way to go?
>
> Also the format of those files does not seem really standardized. Can
> you pick one of them as a good example, please?
>
> Thank you,
> Michal
>
>>>> +
>>>> + cpus {
>>>> + /delete-node/ cpu@1;
>>>> + };
>>>> +
>>>> + memory@10000000 {
>>>> + reg = <0x10000000 0x20000000>;
>>>> + };
>>>> +};
>>>> +
>>>> +&backlight {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&lcd_display {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&leds {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&panel {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&pwm1 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +®_usb_h1_vbus {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbh1 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbphy2 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usdhc3 {
>>>> + status = "okay";
>>>> +};
>>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>>> new file mode 100644
>>>> index 0000000..799fb4c
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-hydra.dts
>>>> @@ -0,0 +1,33 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +//
>>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "imx6dl.dtsi"
>>>> +#include "imx6dl-yapp4-common.dtsi"
>>>> +
>>>> +/ {
>>>> + model = "Y Soft IOTA Hydra i.MX6DualLite board";
>>>> + compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
>>>> +
>>>> + memory@10000000 {
>>>> + reg = <0x10000000 0x80000000>;
>>>> + };
>>>> +};
>>>> +
>>>> +&leds {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&pcie {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +®_pcie {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usdhc3 {
>>>> + status = "okay";
>>>> +};
>>>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>>> new file mode 100644
>>>> index 0000000..23af972
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-ursa.dts
>>>> @@ -0,0 +1,53 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +//
>>>> +// Copyright (C) 2015-2018 Y Soft Corporation, a.s.
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "imx6dl.dtsi"
>>>> +#include "imx6dl-yapp4-common.dtsi"
>>>> +
>>>> +/ {
>>>> + model = "Y Soft IOTA Ursa i.MX6Solo board";
>>>> + compatible = "ysoft,imx6dl-yapp4-ursa", "fsl,imx6dl";
>>>> +
>>>> + cpus {
>>>> + /delete-node/ cpu@1;
>>>> + };
>>>> +
>>>> + memory@10000000 {
>>>> + reg = <0x10000000 0x20000000>;
>>>> + };
>>>> +};
>>>> +
>>>> +&backlight {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&lcd_display {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&panel {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&pwm1 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +®_usb_h1_vbus {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&switch_ports {
>>>> + /delete-node/ port@2;
>>>> +};
>>>> +
>>>> +&usbh1 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&usbphy2 {
>>>> + status = "okay";
>>>> +};
>>>> --
>>>> 2.1.4
>>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-12-11 9:27 ` Vokáč Michal
@ 2018-12-11 12:36 ` Andrew Lunn
2018-12-11 13:46 ` Vokáč Michal
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Lunn @ 2018-12-11 12:36 UTC (permalink / raw)
To: Vokáč Michal
Cc: Rob Herring, Fabio Estevam, linux-arm-kernel, linux-kernel,
NXP Linux Team, devicetree, Sascha Hauer, Shawn Guo,
Mark Rutland
> > Hi Rob, gentle ping on this.
> >
> > I would like to be sure how to proceed with this. Do you really want me
> > to move *all* nodes that are disabled in this common dtsi into the per
> > board dts?
> >
> > All the boards use identical PCB. Anything that is disabled here is not
> > present on at least one of the boards. It means it is routed on the
> > board and the SoC has the capability but the parts are not populated.
> >
> > So it is not only about the LED controller. What about the LCD, OLED,
> > backlight, USB..?
>
> Can anybody advice how to split these dts/dtsi files, please?
> I am not sure what should reside in the common dtsi and what should
> be moved into the per board dts in case my current solution is not
> appropriate.
The kirkwood-synology.dtsi might be of interest? There are a lot of
Synology NAS boxes which share a lot in common. So all the common
parts are in that .dtsi. The .dbs file for each individual model then
enables the parts its needs.
Although you have one PCB, or the different population options
considered different products, each with there own name?
Andrew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards
2018-12-11 12:36 ` Andrew Lunn
@ 2018-12-11 13:46 ` Vokáč Michal
0 siblings, 0 replies; 8+ messages in thread
From: Vokáč Michal @ 2018-12-11 13:46 UTC (permalink / raw)
To: Andrew Lunn
Cc: Rob Herring, Fabio Estevam, linux-arm-kernel, linux-kernel,
NXP Linux Team, devicetree, Sascha Hauer, Shawn Guo,
Mark Rutland
On 11.12.2018 13:36, Andrew Lunn wrote:
>>> Hi Rob, gentle ping on this.
>>>
>>> I would like to be sure how to proceed with this. Do you really want me
>>> to move *all* nodes that are disabled in this common dtsi into the per
>>> board dts?
>>>
>>> All the boards use identical PCB. Anything that is disabled here is not
>>> present on at least one of the boards. It means it is routed on the
>>> board and the SoC has the capability but the parts are not populated.
>>>
>>> So it is not only about the LED controller. What about the LCD, OLED,
>>> backlight, USB..?
>>
>> Can anybody advice how to split these dts/dtsi files, please?
>> I am not sure what should reside in the common dtsi and what should
>> be moved into the per board dts in case my current solution is not
>> appropriate.
>
> The kirkwood-synology.dtsi might be of interest? There are a lot of
> Synology NAS boxes which share a lot in common. So all the common
> parts are in that .dtsi. The .dbs file for each individual model then
> enables the parts its needs.
That is a great example Andrew, thank you! That is exactly what I am
doing. Everything that is supported by the PCB/platform is specified
in the common file. Only parts that are populated on all products are
enabled there, the other stuff is disabled. The .dts files then enable
additional stuff they need.
To me it seems reasonable to do it that way and maybe I only
misunderstood what Rob actually meant by his comment? I still do not
have his reply to that though.
> Although you have one PCB, or the different population options
> considered different products, each with there own name?
Yes, each of the three population options can be considered a different
product with different name. That is still the same as the Synology
NAS boxes, right?
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-11 13:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 15:43 [PATCH] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards Vokáč Michal
[not found] ` <5bea0e99.1c69fb81.18be0.5162@mx.google.com>
2018-11-19 14:35 ` Vokáč Michal
2018-11-27 12:19 ` Vokáč Michal
2018-12-11 9:27 ` Vokáč Michal
2018-12-11 12:36 ` Andrew Lunn
2018-12-11 13:46 ` Vokáč Michal
2018-11-28 2:39 ` Shawn Guo
2018-11-28 8:23 ` Vokáč Michal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).