linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus
@ 2018-11-21 20:16 Lyude Paul
  2018-11-28  3:47 ` Peter Hutterer
  0 siblings, 1 reply; 3+ messages in thread
From: Lyude Paul @ 2018-11-21 20:16 UTC (permalink / raw)
  To: linux-input
  Cc: Dmitry Torokhov, Benjamin Tissoires, KT Liao, Peter Hutterer,
	Edvard Holst, Arkadiusz Hiler, linux-kernel

Noticed the other day the trackpoint felt different on my P50, then
realized it was because rmi4 wasn't loading for this machine
automatically. Suspend/resume, hibernate, and everything else seem to
work perfectly fine on here.

Signed-off-by: Lyude Paul <lyude@redhat.com>
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5e85f3cca867..c42813d50591 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN005b", /* P50 */
 	"LEN0071", /* T480 */
 	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
 	"LEN0073", /* X1 Carbon G5 (Elantech) */
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus
  2018-11-21 20:16 [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus Lyude Paul
@ 2018-11-28  3:47 ` Peter Hutterer
  2018-11-29 11:16   ` Benjamin Tissoires
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Hutterer @ 2018-11-28  3:47 UTC (permalink / raw)
  To: Lyude Paul
  Cc: linux-input, Dmitry Torokhov, Benjamin Tissoires, KT Liao,
	Edvard Holst, Arkadiusz Hiler, linux-kernel

On Wed, Nov 21, 2018 at 03:16:20PM -0500, Lyude Paul wrote:
> Noticed the other day the trackpoint felt different on my P50, then
> realized it was because rmi4 wasn't loading for this machine
> automatically. Suspend/resume, hibernate, and everything else seem to
> work perfectly fine on here.
> 
> Signed-off-by: Lyude Paul <lyude@redhat.com>

Acked-by: Peter Hutterer <peter.hutterer@who-t.net>

Cheers,
   Peter

> ---
>  drivers/input/mouse/synaptics.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 5e85f3cca867..c42813d50591 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0048", /* X1 Carbon 3 */
>  	"LEN0046", /* X250 */
>  	"LEN004a", /* W541 */
> +	"LEN005b", /* P50 */
>  	"LEN0071", /* T480 */
>  	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
>  	"LEN0073", /* X1 Carbon G5 (Elantech) */
> -- 
> 2.19.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus
  2018-11-28  3:47 ` Peter Hutterer
@ 2018-11-29 11:16   ` Benjamin Tissoires
  0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2018-11-29 11:16 UTC (permalink / raw)
  To: Peter Hutterer
  Cc: Lyude Paul, open list:HID CORE LAYER, Dmitry Torokhov,
	廖崇榮,
	edvard.holst, arkadiusz.hiler, lkml

On Wed, Nov 28, 2018 at 4:47 AM Peter Hutterer <peter.hutterer@who-t.net> wrote:
>
> On Wed, Nov 21, 2018 at 03:16:20PM -0500, Lyude Paul wrote:
> > Noticed the other day the trackpoint felt different on my P50, then
> > realized it was because rmi4 wasn't loading for this machine
> > automatically. Suspend/resume, hibernate, and everything else seem to
> > work perfectly fine on here.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
>
> Acked-by: Peter Hutterer <peter.hutterer@who-t.net>

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>
> Cheers,
>    Peter
>
> > ---
> >  drivers/input/mouse/synaptics.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> > index 5e85f3cca867..c42813d50591 100644
> > --- a/drivers/input/mouse/synaptics.c
> > +++ b/drivers/input/mouse/synaptics.c
> > @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
> >       "LEN0048", /* X1 Carbon 3 */
> >       "LEN0046", /* X250 */
> >       "LEN004a", /* W541 */
> > +     "LEN005b", /* P50 */
> >       "LEN0071", /* T480 */
> >       "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> >       "LEN0073", /* X1 Carbon G5 (Elantech) */
> > --
> > 2.19.1
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-29 11:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-21 20:16 [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus Lyude Paul
2018-11-28  3:47 ` Peter Hutterer
2018-11-29 11:16   ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).