* [PATCH] x86: boot: add missing va_end to die
@ 2018-11-28 16:16 Mattias Jacobsson
2018-11-28 19:15 ` [tip:x86/boot] x86/boot: Add missing va_end() to die() tip-bot for Mattias Jacobsson
0 siblings, 1 reply; 2+ messages in thread
From: Mattias Jacobsson @ 2018-11-28 16:16 UTC (permalink / raw)
To: tglx, mingo, bp, hpa; +Cc: x86, linux-kernel, 2pi
Each call to va_start must have a corresponding call to va_end before
the end of the function. Add the missing va_end.
Found with Coccinelle.
Signed-off-by: Mattias Jacobsson <2pi@mok.nu>
---
arch/x86/boot/tools/build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index d4e6cd4577e5..07223fd42d01 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -132,6 +132,7 @@ static void die(const char * str, ...)
va_list args;
va_start(args, str);
vfprintf(stderr, str, args);
+ va_end(args);
fputc('\n', stderr);
exit(1);
}
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/boot] x86/boot: Add missing va_end() to die()
2018-11-28 16:16 [PATCH] x86: boot: add missing va_end to die Mattias Jacobsson
@ 2018-11-28 19:15 ` tip-bot for Mattias Jacobsson
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Mattias Jacobsson @ 2018-11-28 19:15 UTC (permalink / raw)
To: linux-tip-commits; +Cc: bp, mingo, 2pi, linux-kernel, mingo, tglx, hpa
Commit-ID: 69be4efeb959147ff86f22e35aea9526f9b86715
Gitweb: https://git.kernel.org/tip/69be4efeb959147ff86f22e35aea9526f9b86715
Author: Mattias Jacobsson <2pi@mok.nu>
AuthorDate: Wed, 28 Nov 2018 17:16:07 +0100
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Wed, 28 Nov 2018 20:06:07 +0100
x86/boot: Add missing va_end() to die()
Each call to va_start() must have a corresponding call to va_end()
before the end of the function. Add the missing va_end().
Found with Coccinelle.
Signed-off-by: Mattias Jacobsson <2pi@mok.nu>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20181128161607.10973-1-2pi@mok.nu
---
arch/x86/boot/tools/build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index bf0e82400358..a93d44e58f9c 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -132,6 +132,7 @@ static void die(const char * str, ...)
va_list args;
va_start(args, str);
vfprintf(stderr, str, args);
+ va_end(args);
fputc('\n', stderr);
exit(1);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-28 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 16:16 [PATCH] x86: boot: add missing va_end to die Mattias Jacobsson
2018-11-28 19:15 ` [tip:x86/boot] x86/boot: Add missing va_end() to die() tip-bot for Mattias Jacobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).