* [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs
@ 2018-07-05 20:38 Gustavo A. R. Silva
2018-11-29 0:15 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-05 20:38 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/platform/x86/dell-laptop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f1fa861..1938f11 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev,
switch (unit) {
case KBD_TIMEOUT_DAYS:
value *= 24;
+ /* fall through */
case KBD_TIMEOUT_HOURS:
value *= 60;
+ /* fall through */
case KBD_TIMEOUT_MINUTES:
value *= 60;
unit = KBD_TIMEOUT_SECONDS;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs
2018-07-05 20:38 [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-11-29 0:15 ` Darren Hart
2019-02-19 16:33 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Darren Hart @ 2018-11-29 0:15 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Matthew Garrett, Pali Rohár, Andy Shevchenko,
platform-driver-x86, linux-kernel
On Thu, Jul 05, 2018 at 03:38:07PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I've applied this patch, but not the acer or sony fall through patches
due to the pending questions there. Happy to revisit those as needed,
but closing these out of the patch queue.
> ---
> drivers/platform/x86/dell-laptop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f1fa861..1938f11 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev,
> switch (unit) {
> case KBD_TIMEOUT_DAYS:
> value *= 24;
> + /* fall through */
> case KBD_TIMEOUT_HOURS:
> value *= 60;
> + /* fall through */
> case KBD_TIMEOUT_MINUTES:
> value *= 60;
> unit = KBD_TIMEOUT_SECONDS;
> --
> 2.7.4
>
>
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs
2018-11-29 0:15 ` Darren Hart
@ 2019-02-19 16:33 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-19 16:33 UTC (permalink / raw)
To: Darren Hart
Cc: Matthew Garrett, Pali Rohár, Andy Shevchenko,
platform-driver-x86, linux-kernel
On 11/28/18 6:15 PM, Darren Hart wrote:
> On Thu, Jul 05, 2018 at 03:38:07PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> I've applied this patch, but not the acer or sony fall through patches
> due to the pending questions there. Happy to revisit those as needed,
> but closing these out of the patch queue.
>
Thanks, Darren.
I'll send separate patches for those that are still pending. Hopefully,
I'll get some feedback this time.
--
Gustavo
>> ---
>> drivers/platform/x86/dell-laptop.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index f1fa861..1938f11 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -1565,8 +1565,10 @@ static ssize_t kbd_led_timeout_store(struct device *dev,
>> switch (unit) {
>> case KBD_TIMEOUT_DAYS:
>> value *= 24;
>> + /* fall through */
>> case KBD_TIMEOUT_HOURS:
>> value *= 60;
>> + /* fall through */
>> case KBD_TIMEOUT_MINUTES:
>> value *= 60;
>> unit = KBD_TIMEOUT_SECONDS;
>> --
>> 2.7.4
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-19 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-05 20:38 [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-11-29 0:15 ` Darren Hart
2019-02-19 16:33 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).