From: Greg KH <gregkh@linuxfoundation.org>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier
Date: Thu, 29 Nov 2018 13:13:10 +0100 [thread overview]
Message-ID: <20181129121310.GB25319@kroah.com> (raw)
In-Reply-To: <20181129121110.GA25319@kroah.com>
On Thu, Nov 29, 2018 at 01:11:10PM +0100, Greg KH wrote:
> On Thu, Nov 29, 2018 at 11:52:39AM +0000, John Garry wrote:
> > On 27/11/2018 15:23, John Garry wrote:
> > > On 27/11/2018 14:43, Greg KH wrote:
> > >
> > > Hi Greg,
> > >
> > > > On Tue, Nov 27, 2018 at 10:15:32PM +0800, John Garry wrote:
> > > > > Currently sas_task.c has no license specifier, so add SPDX license
> > > > > identifier for GPL-2.0+.
> > > > >
> > > > > As mentioned in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0
> > > > > license identifier to files with no license"), files with no license in
> > > > > the kernel are under default kernel license.
> > > >
> > > > The default is GPLv2, not v2+.
> > >
> > > So sas_task.c should be v2.
> >
> > Hi Greg,
> >
> > I also note that currently we have an inconsistency in license of
> > sas_init.c:
> >
> > /*
> > * Serial Attached SCSI (SAS) Transport Layer initialization
> > *
> > * Copyright (C) 2005 Adaptec, Inc. All rights reserved.
> > * Copyright (C) 2005 Luben Tuikov <luben_tuikov@adaptec.com>
> > *
> > * This file is licensed under GPLv2.
> > *
> > * This program is free software; you can redistribute it and/or
> > * modify it under the terms of the GNU General Public License as
> > * published by the Free Software Foundation; either version 2 of the
> > * License, or (at your option) any later version.
> > *
> > * This program is distributed in the hope that it will be useful, but
> > * WITHOUT ANY WARRANTY; without even the implied warranty of
> > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > * General Public License for more details.
> > *
> > * You should have received a copy of the GNU General Public License
> > * along with this program; if not, write to the Free Software
> > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > * USA
> > *
> > */
> >
> > ...
> >
> > MODULE_AUTHOR("Luben Tuikov <luben_tuikov@adaptec.com>");
> > MODULE_DESCRIPTION("SAS Transport Layer");
> > MODULE_LICENSE("GPL v2");
> >
> > So the license specifies v2+ but module license states v2.
> >
> > I could not find a docment for guidance on this. I also note that making
> > sas_task.c v2 would mean mixing v2 and v2+ into the module.
>
> This is not the only file in the kernel with this problem.
>
> For now, we have been trusting the "written text" lines over the
> MODULE_LICENSE() lines, as that seems to be the proper way forward.
>
> > I did find an example of someone changing the license:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/i2c/busses/i2c-designware-slave.c?h=v4.20-rc4&id=15c566fcff9cc7b8fd64461d6ee6fd1bc665b444
> >
>
> Yup, not good, that should be fixed.
I take it back, the changelog for the patch explains what is happening
here, the people involved were paying attention.
greg k-h
next prev parent reply other threads:[~2018-11-29 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 14:15 [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier John Garry
2018-11-27 14:43 ` Greg KH
2018-11-27 15:23 ` John Garry
2018-11-29 11:52 ` John Garry
2018-11-29 12:11 ` Greg KH
2018-11-29 12:13 ` Greg KH [this message]
2018-11-29 12:18 ` John Garry
2018-11-29 15:49 ` James Bottomley
2018-11-29 17:31 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129121310.GB25319@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).