From: John Garry <john.garry@huawei.com>
To: James Bottomley <jejb@linux.vnet.ibm.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: <martin.petersen@oracle.com>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier
Date: Thu, 29 Nov 2018 17:31:02 +0000 [thread overview]
Message-ID: <44dc28ee-ad2e-d87d-c2d5-7beb2cf6108e@huawei.com> (raw)
In-Reply-To: <1543506541.2881.16.camel@linux.vnet.ibm.com>
On 29/11/2018 15:49, James Bottomley wrote:
> On Thu, 2018-11-29 at 11:52 +0000, John Garry wrote:
> [...]
>> Hi Greg,
>>
>> I also note that currently we have an inconsistency in license of
>> sas_init.c:
>>
>> /*
>> * Serial Attached SCSI (SAS) Transport Layer initialization
>> *
>> * Copyright (C) 2005 Adaptec, Inc. All rights reserved.
>> * Copyright (C) 2005 Luben Tuikov <luben_tuikov@adaptec.com>
>> *
>> * This file is licensed under GPLv2.
>> *
>> * This program is free software; you can redistribute it and/or
>> * modify it under the terms of the GNU General Public License as
>> * published by the Free Software Foundation; either version 2 of
>> the
>> * License, or (at your option) any later version.
>> *
>> * This program is distributed in the hope that it will be useful,
>> but
>> * WITHOUT ANY WARRANTY; without even the implied warranty of
>> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> * General Public License for more details.
>> *
>> * You should have received a copy of the GNU General Public License
>> * along with this program; if not, write to the Free Software
>> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-
>> 1307
>> * USA
>> *
>> */
>>
>> ...
>>
>> MODULE_AUTHOR("Luben Tuikov <luben_tuikov@adaptec.com>");
>> MODULE_DESCRIPTION("SAS Transport Layer");
>> MODULE_LICENSE("GPL v2");
>>
>> So the license specifies v2+ but module license states v2.
>>
>> I could not find a docment for guidance on this. I also note that
>> making sas_task.c v2 would mean mixing v2 and v2+ into the module.
>
> The point here is to get help. There are three pieces of evidence in
> the file one for v2+ and two for v2. So you can look in the git tree
> to when it was actually contributed:
>
> commit 2908d778ab3e244900c310974e1fc1c69066e450
> Author: James Bottomley <James.Bottomley@SteelEye.com>
> Date: Tue Aug 29 09:22:51 2006 -0500
>
> [SCSI] aic94xx: new driver
>
> and if you ask the original contributor he can tell you the original
> intent was v2 only.If you want to modify all the files in libsas and
> aic9xxx to have that SPDX tag.
Right, so that would involve modifying the licenses of the currently v2+
libsas files. aic9xx source files are v2 already.
>
>> At this point I'm reluctant to touch this in case I mess up, but
>> there is still the missing license in sas_task.c .
>
> Again, the tree will tell you. In this case it's
>
> commit 366ca51f30de1cbb5b356c70b7bb22051c558e41
> Author: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date: Fri Jan 18 10:47:01 2008 -0600
>
> [SCSI] libsas: abstract STP task status into a function
>
> So that file is a direct extraction from an existing v2 only file in
> aic9xxx, so it's licence is also v2 only.
ok
Thanks,
John
>
> James
>
>
> .
>
prev parent reply other threads:[~2018-11-29 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 14:15 [PATCH] scsi: libsas: Add missing license and update to SPDX license identifier John Garry
2018-11-27 14:43 ` Greg KH
2018-11-27 15:23 ` John Garry
2018-11-29 11:52 ` John Garry
2018-11-29 12:11 ` Greg KH
2018-11-29 12:13 ` Greg KH
2018-11-29 12:18 ` John Garry
2018-11-29 15:49 ` James Bottomley
2018-11-29 17:31 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44dc28ee-ad2e-d87d-c2d5-7beb2cf6108e@huawei.com \
--to=john.garry@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).