* [PATCH] perf util config : Modify size factor of snprintf
@ 2018-12-01 15:43 Sihyeon Jang
0 siblings, 0 replies; 3+ messages in thread
From: Sihyeon Jang @ 2018-12-01 15:43 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Jiri Olsa, Namhyung Kim, Sihyeon Jang
According to definition of snprintf, it gets size factor including null('\0') byte.
So '-1' is not neccessary. Also it will be helpful unfied style with other cases. (eg. builtin-script.c)
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
---
tools/perf/util/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 5ac157056cdf..bce980fa9f41 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -811,14 +811,14 @@ int config_error_nonbool(const char *var)
void set_buildid_dir(const char *dir)
{
if (dir)
- scnprintf(buildid_dir, MAXPATHLEN-1, "%s", dir);
+ scnprintf(buildid_dir, MAXPATHLEN, "%s", dir);
/* default to $HOME/.debug */
if (buildid_dir[0] == '\0') {
char *home = getenv("HOME");
if (home) {
- snprintf(buildid_dir, MAXPATHLEN-1, "%s/%s",
+ snprintf(buildid_dir, MAXPATHLEN, "%s/%s",
home, DEBUG_CACHE_DIR);
} else {
strncpy(buildid_dir, DEBUG_CACHE_DIR, MAXPATHLEN-1);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf util config : Modify size factor of snprintf
2018-12-01 15:46 Sihyeon Jang
@ 2018-12-06 17:09 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-12-06 17:09 UTC (permalink / raw)
To: Sihyeon Jang; +Cc: linux-kernel, Jiri Olsa, Namhyung Kim
Em Sun, Dec 02, 2018 at 12:46:03AM +0900, Sihyeon Jang escreveu:
> According to definition of snprintf, it gets size factor including null('\0') byte.
> So '-1' is not neccessary. Also it will be helpful unfied style with other cases. (eg. builtin-script.c)
Thanks, applied.
- Arnaldo
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
> ---
> tools/perf/util/config.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index 5ac157056cdf..bce980fa9f41 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -811,14 +811,14 @@ int config_error_nonbool(const char *var)
> void set_buildid_dir(const char *dir)
> {
> if (dir)
> - scnprintf(buildid_dir, MAXPATHLEN-1, "%s", dir);
> + scnprintf(buildid_dir, MAXPATHLEN, "%s", dir);
>
> /* default to $HOME/.debug */
> if (buildid_dir[0] == '\0') {
> char *home = getenv("HOME");
>
> if (home) {
> - snprintf(buildid_dir, MAXPATHLEN-1, "%s/%s",
> + snprintf(buildid_dir, MAXPATHLEN, "%s/%s",
> home, DEBUG_CACHE_DIR);
> } else {
> strncpy(buildid_dir, DEBUG_CACHE_DIR, MAXPATHLEN-1);
> --
> 2.17.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] perf util config : Modify size factor of snprintf
@ 2018-12-01 15:46 Sihyeon Jang
2018-12-06 17:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Sihyeon Jang @ 2018-12-01 15:46 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Jiri Olsa, Namhyung Kim, Sihyeon Jang
According to definition of snprintf, it gets size factor including null('\0') byte.
So '-1' is not neccessary. Also it will be helpful unfied style with other cases. (eg. builtin-script.c)
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sihyeon Jang <uneedsihyeon@gmail.com>
---
tools/perf/util/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 5ac157056cdf..bce980fa9f41 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -811,14 +811,14 @@ int config_error_nonbool(const char *var)
void set_buildid_dir(const char *dir)
{
if (dir)
- scnprintf(buildid_dir, MAXPATHLEN-1, "%s", dir);
+ scnprintf(buildid_dir, MAXPATHLEN, "%s", dir);
/* default to $HOME/.debug */
if (buildid_dir[0] == '\0') {
char *home = getenv("HOME");
if (home) {
- snprintf(buildid_dir, MAXPATHLEN-1, "%s/%s",
+ snprintf(buildid_dir, MAXPATHLEN, "%s/%s",
home, DEBUG_CACHE_DIR);
} else {
strncpy(buildid_dir, DEBUG_CACHE_DIR, MAXPATHLEN-1);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-06 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-01 15:43 [PATCH] perf util config : Modify size factor of snprintf Sihyeon Jang
2018-12-01 15:46 Sihyeon Jang
2018-12-06 17:09 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).