* [PATCH] Malformatted switch statment
@ 2018-10-28 16:45 Joris Gutjahr
2018-12-03 6:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joris Gutjahr @ 2018-10-28 16:45 UTC (permalink / raw)
To: davem, linux-ide, linux-kernel; +Cc: Joris Gutjahr
I fixed this coding style error I got after running
checkpatch --file on this file.
The problem was that the whole case block was on one line.
Signed-off-by: Joris Gutjahr <joris.gutjahr@gmail.com>
---
drivers/ide/amd74xx.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/amd74xx.c b/drivers/ide/amd74xx.c
index cbfe846911d1..fa39f279bf53 100644
--- a/drivers/ide/amd74xx.c
+++ b/drivers/ide/amd74xx.c
@@ -273,9 +273,15 @@ static int amd74xx_probe(struct pci_dev *dev, const struct pci_device_id *id)
amd_clock = (ide_pci_clk ? ide_pci_clk : 33) * 1000;
switch (amd_clock) {
- case 33000: amd_clock = 33333; break;
- case 37000: amd_clock = 37500; break;
- case 41000: amd_clock = 41666; break;
+ case 33000:
+ amd_clock = 33333;
+ break;
+ case 37000:
+ amd_clock = 37500;
+ break;
+ case 41000:
+ amd_clock = 41666;
+ break;
}
if (amd_clock < 20000 || amd_clock > 50000) {
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Malformatted switch statment
2018-10-28 16:45 [PATCH] Malformatted switch statment Joris Gutjahr
@ 2018-12-03 6:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-12-03 6:04 UTC (permalink / raw)
To: joris.gutjahr; +Cc: linux-ide, linux-kernel
From: Joris Gutjahr <joris.gutjahr@gmail.com>
Date: Sun, 28 Oct 2018 17:45:46 +0100
> I fixed this coding style error I got after running
> checkpatch --file on this file.
> The problem was that the whole case block was on one line.
>
> Signed-off-by: Joris Gutjahr <joris.gutjahr@gmail.com>
Frankly I think the existing code is more compact and easier
to read and understand.
Checkpatch is a tool, and it's results need be interpreated
and evaluated by human beings. It's not to be taken as the
final verdict.
I'm not applying this, sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 6:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-28 16:45 [PATCH] Malformatted switch statment Joris Gutjahr
2018-12-03 6:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).