* [PATCH] cpufreq: ia64: Remove unused header files
@ 2018-11-30 14:16 Yangtao Li
2018-12-03 4:42 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2018-11-30 14:16 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: linux-pm, linux-kernel, Yangtao Li
seq_file.h does not need to be included,so remove it.Moreover deleted a
line of meaningless return and move the module declaration to the end.
In a function whose return type is void, returning on the last line is
not required.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
index dd5440d3372d..43ac191fb46a 100644
--- a/drivers/cpufreq/ia64-acpi-cpufreq.c
+++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
@@ -16,7 +16,6 @@
#include <linux/init.h>
#include <linux/cpufreq.h>
#include <linux/proc_fs.h>
-#include <linux/seq_file.h>
#include <asm/io.h>
#include <linux/uaccess.h>
#include <asm/pal.h>
@@ -24,11 +23,6 @@
#include <linux/acpi.h>
#include <acpi/processor.h>
-MODULE_AUTHOR("Venkatesh Pallipadi");
-MODULE_DESCRIPTION("ACPI Processor P-States Driver");
-MODULE_LICENSE("GPL");
-
-
struct cpufreq_acpi_io {
struct acpi_processor_performance acpi_data;
unsigned int resume;
@@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)
pr_debug("acpi_cpufreq_exit\n");
cpufreq_unregister_driver(&acpi_cpufreq_driver);
- return;
}
+MODULE_AUTHOR("Venkatesh Pallipadi");
+MODULE_DESCRIPTION("ACPI Processor P-States Driver");
+MODULE_LICENSE("GPL");
late_initcall(acpi_cpufreq_init);
module_exit(acpi_cpufreq_exit);
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: ia64: Remove unused header files
2018-11-30 14:16 [PATCH] cpufreq: ia64: Remove unused header files Yangtao Li
@ 2018-12-03 4:42 ` Viresh Kumar
2018-12-03 4:44 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-12-03 4:42 UTC (permalink / raw)
To: Yangtao Li; +Cc: rjw, linux-pm, linux-kernel
On 30-11-18, 09:16, Yangtao Li wrote:
> seq_file.h does not need to be included,so remove it.Moreover deleted a
> line of meaningless return and move the module declaration to the end.
> In a function whose return type is void, returning on the last line is
> not required.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index dd5440d3372d..43ac191fb46a 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -16,7 +16,6 @@
> #include <linux/init.h>
> #include <linux/cpufreq.h>
> #include <linux/proc_fs.h>
> -#include <linux/seq_file.h>
> #include <asm/io.h>
> #include <linux/uaccess.h>
> #include <asm/pal.h>
> @@ -24,11 +23,6 @@
> #include <linux/acpi.h>
> #include <acpi/processor.h>
>
> -MODULE_AUTHOR("Venkatesh Pallipadi");
> -MODULE_DESCRIPTION("ACPI Processor P-States Driver");
> -MODULE_LICENSE("GPL");
> -
> -
> struct cpufreq_acpi_io {
> struct acpi_processor_performance acpi_data;
> unsigned int resume;
> @@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)
> pr_debug("acpi_cpufreq_exit\n");
>
> cpufreq_unregister_driver(&acpi_cpufreq_driver);
> - return;
> }
>
> +MODULE_AUTHOR("Venkatesh Pallipadi");
> +MODULE_DESCRIPTION("ACPI Processor P-States Driver");
> +MODULE_LICENSE("GPL");
>
> late_initcall(acpi_cpufreq_init);
> module_exit(acpi_cpufreq_exit);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: ia64: Remove unused header files
2018-12-03 4:42 ` Viresh Kumar
@ 2018-12-03 4:44 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2018-12-03 4:44 UTC (permalink / raw)
To: Yangtao Li; +Cc: rjw, linux-pm, linux-kernel
On 03-12-18, 10:12, Viresh Kumar wrote:
> On 30-11-18, 09:16, Yangtao Li wrote:
> > seq_file.h does not need to be included,so remove it.Moreover deleted a
> > line of meaningless return and move the module declaration to the end.
> > In a function whose return type is void, returning on the last line is
> > not required.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++-------
> > 1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> > index dd5440d3372d..43ac191fb46a 100644
> > --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> > +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> > @@ -16,7 +16,6 @@
> > #include <linux/init.h>
> > #include <linux/cpufreq.h>
> > #include <linux/proc_fs.h>
> > -#include <linux/seq_file.h>
> > #include <asm/io.h>
> > #include <linux/uaccess.h>
> > #include <asm/pal.h>
> > @@ -24,11 +23,6 @@
> > #include <linux/acpi.h>
> > #include <acpi/processor.h>
> >
> > -MODULE_AUTHOR("Venkatesh Pallipadi");
> > -MODULE_DESCRIPTION("ACPI Processor P-States Driver");
> > -MODULE_LICENSE("GPL");
> > -
> > -
> > struct cpufreq_acpi_io {
> > struct acpi_processor_performance acpi_data;
> > unsigned int resume;
> > @@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)
> > pr_debug("acpi_cpufreq_exit\n");
> >
> > cpufreq_unregister_driver(&acpi_cpufreq_driver);
> > - return;
> > }
> >
> > +MODULE_AUTHOR("Venkatesh Pallipadi");
> > +MODULE_DESCRIPTION("ACPI Processor P-States Driver");
> > +MODULE_LICENSE("GPL");
Well, why not move this to the end of file completely ?
> >
> > late_initcall(acpi_cpufreq_init);
> > module_exit(acpi_cpufreq_exit);
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-03 4:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-30 14:16 [PATCH] cpufreq: ia64: Remove unused header files Yangtao Li
2018-12-03 4:42 ` Viresh Kumar
2018-12-03 4:44 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).