* [PATCH -next] drm/vkms: Remove set but not used variable 'vkms_obj'
@ 2018-12-01 3:20 YueHaibing
2018-12-04 10:47 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-12-01 3:20 UTC (permalink / raw)
To: David Airlie, Haneen Mohammed, Sean Paul, Daniel Vetter,
Rodrigo Siqueira, Eric Anholt
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/vkms/vkms_plane.c: In function 'vkms_prepare_fb':
drivers/gpu/drm/vkms/vkms_plane.c:144:26: warning:
variable 'vkms_obj' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
8ce1bb0b5337 ("drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/vkms/vkms_plane.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
index e3bcea4..4188176 100644
--- a/drivers/gpu/drm/vkms/vkms_plane.c
+++ b/drivers/gpu/drm/vkms/vkms_plane.c
@@ -141,14 +141,12 @@ static int vkms_prepare_fb(struct drm_plane *plane,
struct drm_plane_state *state)
{
struct drm_gem_object *gem_obj;
- struct vkms_gem_object *vkms_obj;
int ret;
if (!state->fb)
return 0;
gem_obj = drm_gem_fb_get_obj(state->fb, 0);
- vkms_obj = drm_gem_to_vkms_gem(gem_obj);
ret = vkms_gem_vmap(gem_obj);
if (ret)
DRM_ERROR("vmap failed: %d\n", ret);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/vkms: Remove set but not used variable 'vkms_obj'
2018-12-01 3:20 [PATCH -next] drm/vkms: Remove set but not used variable 'vkms_obj' YueHaibing
@ 2018-12-04 10:47 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-12-04 10:47 UTC (permalink / raw)
To: YueHaibing
Cc: David Airlie, Haneen Mohammed, Sean Paul, Daniel Vetter,
Rodrigo Siqueira, Eric Anholt, dri-devel, linux-kernel,
kernel-janitors
On Sat, Dec 01, 2018 at 03:20:44AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vkms/vkms_plane.c: In function 'vkms_prepare_fb':
> drivers/gpu/drm/vkms/vkms_plane.c:144:26: warning:
> variable 'vkms_obj' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> 8ce1bb0b5337 ("drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/vkms/vkms_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index e3bcea4..4188176 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -141,14 +141,12 @@ static int vkms_prepare_fb(struct drm_plane *plane,
> struct drm_plane_state *state)
> {
> struct drm_gem_object *gem_obj;
> - struct vkms_gem_object *vkms_obj;
> int ret;
>
> if (!state->fb)
> return 0;
>
> gem_obj = drm_gem_fb_get_obj(state->fb, 0);
> - vkms_obj = drm_gem_to_vkms_gem(gem_obj);
> ret = vkms_gem_vmap(gem_obj);
> if (ret)
> DRM_ERROR("vmap failed: %d\n", ret);
>
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-04 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-01 3:20 [PATCH -next] drm/vkms: Remove set but not used variable 'vkms_obj' YueHaibing
2018-12-04 10:47 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).